SMF Development > Fixed or Bogus Bugs

All 2.0.2 need to make these Changes to avoid Bug

<< < (5/8) > >>

phantomm:
This is also common issue on some free hosts.
They inserting few ads, and users have problems like this from screen from first message, only thing that I can suggest (for users) is disabling smileys in theme setting :|
I hope this can be solved somehow in SMF, because free host mostly don't care about it...

emanuele:
What I have in mind a simple edit in QueryString.php:

--- Code: (find) ---function JavaScriptEscape($string)
{
global $scripturl;

return '\'' . strtr($string, array(
"\r" => '',
"\n" => '\\n',
"\t" => '\\t',
'\\' => '\\\\',
'\'' => '\\\'',
'</' => '<\' + \'/',
'script' => 'scri\'+\'pt',
'<a href' => '<a hr\'+\'ef',
$scripturl => '\' + smf_scripturl + \'',
)) . '\'';
}
--- End code ---


--- Code: (replace with) ---function JavaScriptEscape($string)
{
global $scripturl;

return '\'' . strtr($string, array(
"\r" => '',
"\n" => '\\n',
"\t" => '\\t',
'\\' => '\\\\',
'\'' => '\\\'',
'</' => '<\' + \'/',
'script' => 'scri\'+\'pt',
'<body>' => '<bo\'+\'dy>',
'<a href' => '<a hr\'+\'ef',
$scripturl => '\' + smf_scripturl + \'',
)) . '\'';
}
--- End code ---

Realinfo:
But Solved issue by changing <body id="help_popup">  to <'+'body id="help_popup">

Is there anything wrong in this..........

Arantor:
Not really, no, but the method emanuele suggests is essentially a more thorough version of the same thing that you apply in one place only, not in a bunch of places.

Realinfo:
Can we do both things............ or only one..........

<body id="help_popup">  to <'+'body id="help_popup">

and


--- Code: ---=replace with]function JavaScriptEscape($string)
{
   global $scripturl;

   return '\'' . strtr($string, array(
      "\r" => '',
      "\n" => '\\n',
      "\t" => '\\t',
      '\\' => '\\\\',
      '\'' => '\\\'',
      '</' => '<\' + \'/',
      'script' => 'scri\'+\'pt',
      '<body>' => '<bo\'+\'dy>',
      '<a href' => '<a hr\'+\'ef',
      $scripturl => '\' + smf_scripturl + \'',
   )) . '\'';
}
--- End code ---

Navigation

[0] Message Index

[#] Next page

[*] Previous page

Go to full version