Customizing SMF > Theme Site Themes

BloQcs

<< < (2/8) > >>

Orangine:
wouldn't it be a better idea to get rid of hard coded alt text from the index.template.php?

--- Code: --- if(!empty($settings['rs_icon']))
echo '
<a href="' , $scripturl , '?action=.xml;type=rss"><img src="' , $settings['images_url'] , '/icons/rs.png" alt="RSS" /></a>';

if(!empty($settings['fb_icon']))
echo '
<a href="' , $settings['fb_icon'] , '"><img src="' , $settings['images_url'] , '/icons/fb.png" alt="Facebook" /></a>';

if(!empty($settings['ln_icon']))
echo '
<a href="' , $settings['ln_icon'] , '"><img src="' , $settings['images_url'] , '/icons/ln.png" alt="LinkedIn" /></a>';

if(!empty($settings['tw_icon']))
echo '
<a href="' , $settings['tw_icon'] , '"><img src="' , $settings['images_url'] , '/icons/tw.png" alt="Twitter" /></a>';

if(!empty($settings['my_icon']))
echo '
<a href="' , $settings['my_icon'] , '"><img src="' , $settings['images_url'] , '/icons/my.png" alt="MySpace" /></a>';
--- End code ---

Bloc:
Why? Do you have other names for them in for example Spanish? ;D AFAIk Facebook is Facebook in any language. And RSS is a global term.

Mstcool:
Bloc your themes are awesome!

Orangine:

--- Quote from: Bloc on July 14, 2012, 09:37:56 PM ---Why? Do you have other names for them in for example Spanish? ;D AFAIk Facebook is Facebook in any language. And RSS is a global term.

--- End quote ---
no, but it's irrelevant since the guidelines specifically mentions this kind of hard coding

Bloc:

--- Quote from: Orangine on July 15, 2012, 06:42:09 AM ---
--- Quote from: Bloc on July 14, 2012, 09:37:56 PM ---Why? Do you have other names for them in for example Spanish? ;D AFAIk Facebook is Facebook in any language. And RSS is a global term.

--- End quote ---
no, but it's irrelevant since the guidelines specifically mentions this kind of hard coding

--- End quote ---
Heh. Well, the guidelines are just that: guides.

Navigation

[0] Message Index

[#] Next page

[*] Previous page