SMF Development > Bug Reports

Avatar resize

(1/5) > >>

Charlie82:
Please could you revise this bug?
http://www.simplemachines.org/community/index.php?topic=315835.0

It's still present in 2.0 RC5. Maths say that round() should be used, Devs said images could be too big? Maybe they overlocked the issue. Floor() distorts the reality.

Arantor:
If the devs said 18 months ago that they didn't want to fix it, I doubt they're going to change their mind. round() can easily round up, just as likely as rounding down, and that could - yes - potentially mean you get things bigger than were intended.

It isn't likely, though.

Charlie82:
When you want to round you always make things bigger or smaller, the thing is that they should be as close as possible to the intented size.

Round is the best approximation, it is in the middle:

ceil()
round()
floor()


With ceil() you can do images bigger than the intended size, not with round().
floor() is the opposite of ceil().

Arantor:
Yes, I do realise the difference between the functions. I looked into this about the time this was reported originally, and found there were odd times that it oversized, but it's very very rare that it happened.

Thing is, I still don't think the devs are going to change it, even for something as minor as this, since they refused to even move an integration hook that was suggested to be in the wrong place...

Illori:
can a developer comment on if they want to "fix" this again?

Navigation

[0] Message Index

[#] Next page