Customizing SMF > SMF Coding Discussion

Minor template bug in admin area

(1/1)

The_Altered1:
This is just in IE (hehe) for RC1

Found this while re-writing the admin templates.
On the main admin area screen, At the bottom of the "Quick admin tasks area" there is a solid black line. It really looks out of place (especially when enclosing that area with another table or div).

This might be also present in the RC2 version ( but I don't know since I'm not a charter member......yet  :D )

oops, forgot one thing: this is present in the default skin.

Cypher7:
It's not there for me...!?

Probably occured when you were re-writing the admin templates :P

The_Altered1:
My fault, it is not a black line, but if you look really close above the bottom border you will see a thin "white line"

Almost like a tr without a td in it.

The_Altered1:
Yup, I'm not seeing thigs lol. Note: this is on a fresh install without tampering with the templates on the default skin RC1

This is the code of the area in the default skins "Admin.template.php file"


--- Code: --- $row = false;
foreach ($context['quick_admin_tasks'] as $task)
{
echo '
<td style="padding-bottom: 2ex;" width="50%">
<div style="font-weight: bold; font-size: 1.1em;">', $task['link'], '</div>
', $task['description'], '
</td>';

if ($row)
echo '
</tr>
<tr valign="top" class="windowbg2">';

$row = !$row;
}

echo '
</tr>
</table>';

--- End code ---

Now this is what the Admin page area looks like when viewing source of the actual output page:


--- Code: ---<tr valign="top" class="windowbg2">
<td style="padding-bottom: 2ex;" width="50%">
<div style="font-weight: bold; font-size: 1.1em;"><a href="http://smfcreations.sytes.net/forum/index.php?action=smileys">Smileys and Smiley Sets</a></div>
Install new smiley sets or add smileys to existing ones.
</td>
<td style="padding-bottom: 2ex;" width="50%">
<div style="font-weight: bold; font-size: 1.1em;"><a href="http://smfcreations.sytes.net/forum/index.php?action=regcenter">Registration Management</a></div>
Register, approve, and manage member registration.
</td>
</tr>
<tr valign="top" class="windowbg2">
</tr>
</table>
--- End code ---

notice the
--- Code: ---</tr>
<tr valign="top" class="windowbg2">
</tr>
</table>[/
--- End code ---

This looks to be the cause of the abnormal space at the bottom. HEHE I knew I wasn't seeing things.

Have a nice day  :D

[Unknown]:
 * Administration "quick tasks" section had an extra row. (Admin.php, Admin template)

-[Unknown]

Navigation

[0] Message Index