SMF Development > Fixed or Bogus Bugs

Logic error in Display.template.php

(1/2) > >>

maestrosite.ru:
Where the Error Occurred

    File: Display.template.php
    Line: 208-209, 633-636
    Any relevant errors in the SMF error log (if so please post them)?:

Form "quickModForm" echo without check $options['display_quick_mod']

(but checkboxes and javascript handlers for this form echo only  $options['display_quick_mod'] == 1)

emanuele:
I can't find an instance of $options['display_quick_mod'] in Curve at the lines you reported.
Are you using the default theme and/or modifications?

maestrosite.ru:

--- Quote from: emanuele on February 28, 2012, 06:20:49 AM ---I can't find an instance of $options['display_quick_mod'] in Curve at the lines you reported.
Are you using the default theme and/or modifications?

--- End quote ---

Of course, not find. In this lines print 'form'-tags. In [strike]Curve[/strike] Core analog lines: 187-188, 603-604, respectively
Default themes from smf_2-0-2_install.tar.bz2

emanuele:
In Curve I have $options['display_quick_mod'] at lines 460 and 765.
And in both cases the code looks like:

--- Code: --- if (!empty($options['display_quick_mod']) && $options['display_quick_mod'] == 1 && [...]
--- End code ---
so it first check if is !empty and then the value...

maestrosite.ru:

--- Quote from: emanuele on February 28, 2012, 06:45:25 AM ---In Curve I have $options['display_quick_mod'] at lines 460 and 765.
And in both cases the code looks like:

--- Code: --- if (!empty($options['display_quick_mod']) && $options['display_quick_mod'] == 1 && [...]
--- End code ---
so it first check if is !empty and then the value...

--- End quote ---

Yes, it is.

1. Have you form with id="quickModForm" in you file ?
2. Have you conditions for display this form? for dispaly start-tag "<form..." and for end-tag "</form>" ?

upd Sorry. In my previous post, analog lines: 187-188, 603-604 - it said about Core.
For Curve - lines in first post.

Navigation

[0] Message Index

[#] Next page