SMF Development > Fixed or Bogus Bugs

Two small language string use related bugs for multilingual SMF

(1/2) > >>

agridoc:
Noticed here in simplemachines.org, tested and confirmed in SMF 2.02 installation, not tested for 1.1x.

Member's language is the language selected in a multilingual SMF installation.

- In notification email for new topic the team regards language string $txt['regards_team'] is in poster's language. In notification email for replies the team regards language string $txt['regards_team'] is correctly in email recipient's language.

- In PM, if no subject exists, the no subject string $txt['no_subject'] is used from sender's language not recipient's as it should. Can be confusing in notification emails.

Nothing serious, a notice for proper internationalization - localization of SMF.

emanuele:

--- Quote from: agridoc on April 15, 2012, 01:30:12 AM ---- In notification email for new topic the team regards language string $txt['regards_team'] is in poster's language. In notification email for replies the team regards language string $txt['regards_team'] is correctly in email recipient's language.
--- End quote ---
That sounds like a bug...
* emanuele goes check. :P

--- Quote from: agridoc on April 15, 2012, 01:30:12 AM ---- In PM, if no subject exists, the no subject string $txt['no_subject'] is used from sender's language not recipient's as it should. Can be confusing in notification emails.

--- End quote ---
That's not something I would change... The subject should be in the language of the sender...it must be.
BTW, the "no subject" is just an annoyance IMHO.

Kryzen:
I can confirm this, I've tested this on Yoshi's site (thanks Yoshi ;)) and the footer was in English rather than Spanish. ;)

agridoc:
Thank you for taking care of it  emanuele.


--- Quote from: emanuele on April 15, 2012, 06:21:42 AM ---
--- Quote from: agridoc on April 15, 2012, 01:30:12 AM ---- In PM, if no subject exists, the no subject string $txt['no_subject'] is used from sender's language not recipient's as it should. Can be confusing in notification emails.

--- End quote ---
That's not something I would change... The subject should be in the language of the sender...it must be.
BTW, the "no subject" is just an annoyance IMHO.
--- End quote ---

You are partially right. The subject should be in the language of the sender, IF EXISTENT. it's a direct string, an input by the sender.

However, IF EMPTY, the parameter $txt['no_subject'] from the recipient's language should be used to be understandable. Not so important as $txt['new_pm_subject'] in front of it is taken from recipient's language.

I agree that it might need some queries, that should be considered. I also agree that, as $txt['new_pm_subject'] exists in email subject, the notification email subject will ontain something understandable.

emanuele:

--- Quote from: agridoc on April 15, 2012, 07:12:20 AM ---
--- Quote from: emanuele on April 15, 2012, 06:21:42 AM ---
--- Quote from: agridoc on April 15, 2012, 01:30:12 AM ---- In PM, if no subject exists, the no subject string $txt['no_subject'] is used from sender's language not recipient's as it should. Can be confusing in notification emails.

--- End quote ---
That's not something I would change... The subject should be in the language of the sender...it must be.
BTW, the "no subject" is just an annoyance IMHO.
--- End quote ---

You are partially right. The subject should be in the language of the sender, IF EXISTENT. it's a direct string, an input by the sender.

However, IF EMPTY, the parameter $txt['no_subject'] from the recipient's language should be used to be understandable. Not so important as $txt['new_pm_subject'] in front of it is taken from recipient's language.
--- End quote ---

If you leave the subject field empty you receive a warning: "No subject was filled in.", so the trick is that as long as there is any thing in the field "subject", the subject exits. Even if it is "no subject".
This is not something checked after the PM is sent, it's something that is outputted on the user's window, so the user that is sending the PM has full control over the field and leaving "ho subject" he simply states that he is fine with that.

That's why I say it should not be changed...well I would remove it completely, but that's "just" me. :P

Navigation

[0] Message Index

[#] Next page

Go to full version