Advertisement:

Author Topic: Advanced Signature  (Read 13436 times)

Offline Skaty

  • Jr. Member
  • **
  • Posts: 305
Re: Advanced Signature
« Reply #60 on: January 15, 2013, 03:36:37 PM »
also i have logs like this:

8: Undefined index: 499 (also 1694,277,2165)    .......    /Sources/Subs-AdvancedSignature.php
Line: 97


do you have any idea for fix ?

Online emanuele

  • Developer
  • SMF Super Hero
  • *
  • Posts: 11,814
  • Gender: Male
  • Because Orange is Orange
Re: Advanced Signature
« Reply #61 on: January 15, 2013, 04:26:04 PM »
The code I wrote is quite ugly... ::)

I think I have an idea, but it doesn't make sense with the old code... ::)

Simple fix should be to replace:
Code: [Select]
return count($context['user_avail_signatures'][$member]);with:
Code: [Select]
return isset($context['user_avail_signatures'][$member]) ? count($context['user_avail_signatures'][$member]) : 0;doesn't make sense, but let try.

Aiutateci ad aiutarvi: spiegate bene il vostro problema: no, "non funziona" non è una spiegazione!!
1) Cosa fai,
2) cosa ti aspetti,
3) cosa ottieni.

Offline Skaty

  • Jr. Member
  • **
  • Posts: 305
Re: Advanced Signature
« Reply #62 on: January 15, 2013, 06:49:37 PM »
:)

didn't work. but i can give more clue for problem. it's mostly gave it when pm is received or send.

and it is point from this -->> index.php?pretty;action=pm   

to this file's --> Sources/PersonalMessage.php   

line -->  (1058) if($memberContext[$message['id_member_from']]['random_signature']==-2){     
and     (1060)    elseif($memberContext[$message['id_member_from']]['random_signature']==-1 && $message['signature_id']!=-2){

Online emanuele

  • Developer
  • SMF Super Hero
  • *
  • Posts: 11,814
  • Gender: Male
  • Because Orange is Orange
Re: Advanced Signature
« Reply #63 on: January 18, 2013, 04:36:48 PM »
Replace the block:
Code: [Select]
if($memberContext[$message['id_member']]['random_signature']==-2){
$message['signature_id']=-2;}
elseif($memberContext[$message['id_member']]['random_signature']==-1 && $message['signature_id']!=-2){
$message['signature_id']=-1;}
with:
Code: [Select]
if(!empty($memberContext[$message['id_member']]['random_signature']) && $memberContext[$message['id_member']]['random_signature']==-2){
$message['signature_id']=-2;}
elseif(!empty($memberContext[$message['id_member']]['random_signature']) && $memberContext[$message['id_member']]['random_signature']==-1 && $message['signature_id']!=-2){
$message['signature_id']=-1;}
Should work at least for a while...

Aiutateci ad aiutarvi: spiegate bene il vostro problema: no, "non funziona" non è una spiegazione!!
1) Cosa fai,
2) cosa ti aspetti,
3) cosa ottieni.

Offline Skaty

  • Jr. Member
  • **
  • Posts: 305
Re: Advanced Signature
« Reply #64 on: January 24, 2013, 12:34:25 PM »
Finally installed the beta version of mod. And it is working correctly. Thank you.

Offline Skaty

  • Jr. Member
  • **
  • Posts: 305
Re: Advanced Signature
« Reply #65 on: January 24, 2013, 03:49:28 PM »
Except, some signatures of some members don't appear in some topics :D

Offline Skaty

  • Jr. Member
  • **
  • Posts: 305
Re: Advanced Signature
« Reply #66 on: January 27, 2013, 02:06:10 PM »
i think i'm gonna uninstall it again :D