SMF Development > Fixed or Bogus Bugs

[4867] Most Time Online

(1/2) > >>

live627:
The Most Time Online panel in Stats shows unapproved members. In fact, it shows members regardless of their activated state.

This is, of course, SMF 2.0 RC4.

The fix is a quick one-liner.


--- Code: (Find in Stats.php, on or around line 506) ---WHERE id_member IN ({array_int:member_list_cached})' : '') . '
--- End code ---


--- Code: (Add after) --- AND is_activated = 1
--- End code ---

Arantor:
So you're not counting folks that just changed their email and are waiting on email activation, or folks that are now banned? ;)

live627:
I'm not sure if banned folks should be counted. They got banned for a reason, and would the admin want those fellows in the stats anyway? (Then might as well exclude them from the other top stats)

Re email activation: I can see that as totally unfair.

Arantor:
That's the trouble though, there are a bunch of states measured in is_activated. The list I have - and I don't think it's complete either:

0 = pending activation
1 = active
2 = something else, possibly active but awaiting reactivation
4 = pending deletion
5 = pending COPPA
10+ = same as above list +10 for being banned

live627:
Then this looks more complicated than I thought :(

Navigation

[0] Message Index

[#] Next page