Topic: Board Notification Mod - 1.2.1 released

[SabreOfParadise]

It would help much if you could provide a screenshot. Else I can only guess:

1. Check if your ManagePermissions.php file contains 'mark_notify_more' 3 times.
2. Check if your ManagePermissions.english.php file contains the following lines:
// Added by Board Notification Mod
$txt['permissionname_mark_notify_more'] = 'Request notification on new replies for subscribed boards';
$txt['permissionhelp_mark_notify_more'] = 'Addition to the notification on new topics which allows a user to receive an email every time a new reply is created on the board they subscribe to.';
3. Maybe the theme you are using overwrites one of the files mentioned above. The mod only modifies the files in the default theme.
4. Are you using English, German, Spanish or French as language for your user? If not the cause may be that the language entries for the user language don't exist. I don't know if a fallback to English exists for this case.

[rob54]

Thanks for answering. I had been out all day so unable to answer until now.

Attached is a screenshot of the Nofication area with the text missing.

1. In ManagePermissions.php file 'mark_notify_more' does appear 3 times.
2. ManagePermissions.english.php contains those lines you mention.
3. ManagePermissions.php is dated 12/10/2009 and there is a ManagePermissions.php~ also dated 12/10/2009. The date and time is the same as when I installed the mod. Likewise for ManagePermissions.english.php and ManagePermissions.english.php~.  Does that give a clue?
4. I am using English as I don't know any other language.

[SabreOfParadise]

Does that give a clue?

No, the ~ files are generated by SMF when a Mod is installed.

Did you check if your theme contains a ManagePermissions.english.php file?

Can you switch to the default theme and check if the text is shown then?

[rob54]

The theme I use (Pancar1) does not have its own ManagePermissions.english.php file.

I did already try switching back to the default theme with the same effect. I have just check again to be double sure - no text by tickbox. I think, before I posted in this thread I even tried uninstalling and deleting your mod in default, then re-uploading and re-installing again, to the same effect - no text by the tickbox.

[SabreOfParadise]

Then I have no clue. If you run an Apache web server you can check the php_error.log file for error messages.

It may also help to open the source code of the permission view, search for 'mark_notify_more' and post the complete
<tr>
      ...
</tr>
block which contains the  'mark_notify_more'

On my forum this looks like the following:

Code: [Select]

<tr class="windowbg2">
<td valign="top" width="10" style="padding-right: 1ex;">
<a href="http://forum.mydomain.com/index.php?action=helpadmin;help=permissionhelp_mark_notify_more" onclick="return reqWin(this.href);" class="help"><img src="http://forum.mydomain.com/Themes/mytheme/images/helptopics.gif" alt="Help" /></a>
</td>

<td valign="top" width="100%" align="left" style="padding-bottom: 2px;">Request notification on new replies for subscribed boards</td>
<td valign="top" style="padding-bottom: 2px;"><input type="checkbox" name="perm[board][mark_notify_more]" value="on" class="check" /></td>
</tr>

If nothing can be seen there please try to exchange your ManagePermissions.english.php with the attached one from my working testsystem. Of course, you should make a backup copy of your file first.

Did you get any error messages during the installation of the Mod?

[rob54]

Unfortunately I don't even know what an Apache web server is.

On opening the source code for the Permissions area (and I take this to mean Permissions then the Modify link for Regular Members) in the area between the <tr> tags that include 'mark_notify_more' I have

Code: [Select]

<tr class="windowbg2">
<td valign="top" width="10" style="padding-right: 1ex;">

</td>
<td valign="top" width="100%" align="left" style="padding-bottom: 2px;"></td>
<td valign="top" style="padding-bottom: 2px;"><input type="checkbox" name="perm[board][mark_notify_more]" value="on" class="check" /></td>
</tr>
but seems to have quite a bit missing compared to yours. I have changed nothing it is directly copied. There are many slightly similar areas between <tr> tags but only that one that contains 'mark_notify_more'.

I did not notice error messages during installation, but not to say there were none.

I also tried substituting your ManagePermissions.english.php to no effect.

Thanks for your assistance so far.

[SabreOfParadise]

Unfortunately I don't even know what an Apache web server is.

A web server.  => http://httpd.apache.org/

Which web server are you using?

---------------------------------------

If you look into the ManagePermissions.template.php file you'll see what is missing:

<tr class="', $alternate ? 'windowbg' : 'windowbg2', '">
                        <td valign="top" width="10" style="padding-right: 1ex;">
                           ', $permission['show_help'] ? '<a href="' . $scripturl . '?action=helpadmin;help=permissionhelp_' . $permission['id'] . '" onclick="return reqWin(this.href);" class="help"><img src="' . $settings['images_url'] . '/helptopics.gif" alt="' . $txt[119] . '" /></a>' : '', ' <= $permission['show_help'] = Empty
...
<td valign="top" width="100%" align="left" style="padding-bottom: 2px;">', $permission['name'], '</td>'; <= $permission['name'] = Empty
...
   <td valign="top" style="padding-bottom: 2px;"><input type="checkbox" name="perm[', $permission_type['id'], '][', $permission['id'], ']"', $permission['select'] == 'on' ? ' checked="checked"' : '', ' value="on" class="check" /></td>';
                        </td>';

That means that
$txt['permissionname_mark_notify_more']
and
$txt['permissionhelp_mark_notify_more']
from the ManagePermissions.english.php cannot be read. As the id works the only possibilities I see are that either these properties are not in the correct ManagePermissions.english.php (=> <WebServerRoot>/<YourSMFFolder>/themes/default/languages/ManagePermissions.english.php) or an old version of the file is read or something else is wrong with this file.

I also tried substituting your ManagePermissions.english.php to no effect.

How exactly?

I suggest you change a different property in this file and see if there are any differences in the permissions view:

E.g. change:

Code: [Select]

$txt['permissionname_mark_notify'] = 'Request notification on new topics';
to

Code: [Select]

$txt['permissionname_mark_notify'] = 'Request notification on new topics (test)';
If you don't see the '(test)' something is very wrong on your system or you are changing the wrong file.

On my test forum I see the change at once.

[rob54]

According to my hoster's cPanel the Apache Version is 2.2.13 (Unix).

The bits you show in red in ManagePermissions.template.php that are missing are indeed missing in my file. I take it you mean that text should be there. If so why would it be missing and should I insert it?

ManagePermissions.english.php is in the right place (public_html/forum/Themes/default/languages). ManagePermissions.english.php~ does not have the 'mark_notify_more' lines. But I'm guessing you don't mean that file as it is a backup as I understand. But ManagePermissions.english.php does have those lines.

When I copied your ManagePermissions.english.php over to replace mine, I did it in the usual way by dragging and dropping the file into the FTP window in the appropriate folder. I checked that it updated OK in the FTP view then switched back to my forum and did a Ctrl-F5.

I tried adding (test) where you indicated copied the file again, did a Ctrl-F5 and it made no difference i.e. I didn't see '(test)'.
 

[SabreOfParadise]

The bits you show in red in ManagePermissions.template.php that are missing are indeed missing in my file. I take it you mean that text should be there. If so why would it be missing and should I insert it?

Ehm, I don't understand you. Where would you want to insert any text?
The text I wrote in red were only descriptions of the problem.
The ManagePermissions.template.php ist correct or else the rest of the permissions would be shown wrongly, too. Therefore changing anything here would not help.

I tried adding (test) where you indicated copied the file again, did a Ctrl-F5 and it made no difference i.e. I didn't see '(test)'.

Sounds to me like an old version lies in the proxy you are using or your web browser cache. I suggest you clear the cache and bypass the proxy and look if this solves the problem.

[rob54]

I'm confused now.  Well I was already really 

I did clear the cache as you suggested but I don't know about a proxy. I know the meaning of the word itself of course but have no idea if a proxy is in use.

I've also been testing out the notifications. I subscribed myself and 2 test users (both me) to one board and was getting notifications of new topics OK. But I noticed that the notification of a post from a test user arrived at the email address for me, lacked the link to the post. Instead, in it's place it just had the name if the test account. I'm beginning to wonder if there is something more seriously amiss with the files.

[SabreOfParadise]

I'm confused now. 

Well, I'm confused, too. According to your information the files itselves are correct. If they are in the correct location, there is no proxy and your web browser doesn't get an older version from the cache I have no clue why you have such a strange output.
Plus you changed the file yourself and see no differences in the output which means there is some kind of cache with old content between client and server. I can't help you with that. Check your client and talk to your hoster regarding the server.

You could also try the following:
1. Install the backup files (with the ~) of the files changed by the Mod and delete the mod in the Package Manager.
2. Then check if the checkbox without text disappears.
If it doesn't disappear the problem definately doesn't have anything to do with the Mod.
According to your information I would bet the checkbox will not disappear.
3. Try to install the Mod again from this clean state. Watch every error or warn messages given out during installation.
4. Check if it works this time.

You could also install an Apache web server, mySQL and PHP on your own computer, install SMF there and install the Mod there to get a feeling for it and be able to watch the php_error.log.

[rob54]

Hi,

1. When you say install the backup files (~) I don't know which ones they are. And once I know, how to I install them. Is it a matter of removing the ~? TO delete the mod, presumably I don't need to uninstall first (I usually do for mods that either don't work as I though or I simply don't like).
2. OK then I can check if the tickbox goes.
3. I did uninstall and delete the mod before when it initially only showed the tickbox, then I reinstalled it. Umm I think the tickbox went I can't remember  . Presumably what you are suggesting I do will be different to that if you are expecting the tickbox not to go.
4. OK I will but I just need you to answer 1. first.

Regarding Apache etc, I don't think I want even go down that road. Far beyond by capability.

Interestingly (I don't know if it helps) but I installed another mod some time back which is to hide topic replies from Guests. That also only shows a tickbox, but works OK with the tickbox ticked. Sorry I'm saying tick and tickbox (I'm from UK) so I meant to say check etc. 

[SabreOfParadise]

1. When you say install the backup files (~) I don't know which ones they are.

You can see the files which are changed by the Mod in the file modification1.1.x.xml of the Mod:
$sourcedir/ManagePermissions.php
$sourcedir/Post.php
$sourcedir/Subs-Post.php
$languagedir/Post.english.php
$languagedir/ManagePermissions.english.php
As you don't have other languages installed that's it.
You guessed right: You simply have to change the file names and remove the ~. But previously you to move the changed files elsewhere (backup location).
If a Mod doesn't work as expected it is not safe to uninstall it. Therefore you have to restore the previous state by using the backup files. As uninstalling the Mod is now superfluous you only have to delete it.

The problem with the other Mod proves that your problem doesn't have anything to do with both Mods.

[rob54]

OK I did as you suggest in the way you suggested.

After renaming the files, I went to the Package Manager and clicked Delete and there was a warning about might not being able to uninstall. Anyway I went ahead and deleted. The checkbox with no text disappeared from the Permissions view.

Then I re-uploaded the mod and applied it and got the attached screenshot indicating the mod was already installed. I then clicked Install Now. Result, still the same - a checkbox with no text. I got not other error messages during the process apart from it skipping other language installations.

Umm, this mod seemed like a good idea as I said here in this same thread but I'm not sure now    My forum isn't yet released to any users other than me and test me's so it hasn't had a proper test.

Am I right that without the mod, a user can subscribe to a board, and receive notification of new topics in that board. Then, if the user reads the topic he has had notification on and chooses to reply, and is also set to receive notification of replies (or subscribes separately to the topic) the user will get notification of further replies and new topics in the board without the mod. Or am I just looking for a reason not to use the mod  . Or am I just not appreciating or understanding the value of the mod.

Please don't take offence as there is none intended, quite the reverse. Thanks for your time and help and support. Perhaps you (or anyone) can enlighten me more. 

[SabreOfParadise]

Umm, this mod seemed like a good idea as I said here in this same thread but I'm not sure now 

As written previously: As you have the same problem with another Mod I'm pretty sure your problem doesn't have anything to do with the Mod. Either you are doing something wrong or something is wrong on the server or some other local problem.
I never had a problem like you reported and you are the first and only one to report it (and the Mod currently has 738 downloads).
As you have the same problem with two installed Mods I really think this is a general problem of your system and I suggest you post the problem in SMF 1.x Support, too, with a link to
http://www.simplemachines.org/community/index.php?topic=313867.msg2303516#msg2303516

It looks like I cannot help you.

[rob54]

Hmm. OK. Well, I decided to try one more thing - install a second fresh instance of SMF 1.1.10 on the server. Then, before making any changes, I installed your mod to that and once again I have the same problem, the checkbox with no text.

Hmm must be something more general then. I'll try the 1.x support.

Thanks for your time.

[SabreOfParadise]

SMF 1.1.6 released. It simply adds support for SMF 1.1.11 (install/uninstall).

[ttuu]

have change in code in 1.1.5 to 1.1.6?

[SabreOfParadise]

There was no real code change, just added 1.1.11 to the install and uninstall line in the package-info.xml

[rob54]

I tried to install your mod update without success. It listed some errors (see attached) and it recommended I didn't continue. Strangely though the Package Manager listed 1.1.5 as current and 1.1.6 as old (see package list attached).

I can get rid of 1.1.6 even though there is no Uninstall or Install link by clicking Delete. For 1.1.5 (thinking I need to uninstall that then inslatt 1.1.6), there is also no Uninstall link. If I click Delete it warns (see Delete warning attached). If I go to Installed Packages there is an Uninstall link there for 1.1.5 and if that is clicked it warned there is no uninstaller and to contact the mod author.