SMF Development > Fixed or Bogus Bugs
[Minor] HTML errors in help text.
(1/1)
DaKrampus:
affected version: 2.02
Was looking at help text, to write my own for a mod, when i stumbled into a html error.
Actually you would never try to validate a help popup. Thats why probably I didnt find it.
I also did a search and didnt find it. So i post it here.
If you open help english,. Look at first variable $helptxt['manage_boards'] :
--- Code: ---$helptxt['manage_boards'] = '
<strong>Edit Boards</strong><br />
In this menu you can create/reorder/remove boards, and the categories
above them. For example, if you had a wide-ranging
site that offered information on "Sports" and "Cars" and "Music", these
would be the top-level Categories you\'d create. Under each of these
categories you\'d likely want to create hierarchical "sub-categories",
or "Boards" for topics within each. It\'s a simple hierarchy, with this structure: <br />
<ul class="normallist">
<li>
<strong>Sports</strong>
- A "category"
</li>
<ul class="normallist">
<li>
<strong>Baseball</strong>
- A board under the category of "Sports"
</li>
<ul class="normallist">
<li>
<strong>Stats</strong>
- A child board under the board of "Baseball"
</li>
</ul>
<li><strong>Football</strong>
- A board under the category of "Sports"</li>
</ul>
</ul>
--- End code ---
w3c validator would give you immediately a nested ul error.
actually you cannot do:
<ul>
<li>...
</li>
<ul>
<li>....
</li>
</ul>
</ul>
you would have to do:
<ul>
<li>...
<ul>
<li>....
</li>
</ul>
</li>
</ul>
I would say it is not worth correcting it, as no search engine will ever get there, and most browsers will correct the output automatically. A problem would arise if the page was read by visually impaired people forced to use a screen reading device.
But I think this should be corrected for some big new version (like 2.1 or 3.0)
This is the way it should be:
--- Code: ---$helptxt['manage_boards'] = '
<strong>Edit Boards</strong><br />
In this menu you can create/reorder/remove boards, and the categories
above them. For example, if you had a wide-ranging
site that offered information on "Sports" and "Cars" and "Music", these
would be the top-level Categories you\'d create. Under each of these
categories you\'d likely want to create hierarchical "sub-categories",
or "Boards" for topics within each. It\'s a simple hierarchy, with this structure: <br />
<ul class="normallist">
<li>
<strong>Sports</strong>
- A "category"
<ul class="normallist">
<li>
<strong>Baseball</strong>
- A board under the category of "Sports"
<ul class="normallist">
<li>
<strong>Stats</strong>
- A child board under the board of "Baseball"
</li>
</ul>
</li>
<li><strong>Football</strong>
- A board under the category of "Sports"</li>
</ul>
</li>
</ul>
--- End code ---
Da
emanuele:
Thanks DaKrampus for the report! :)
Yep, unlikely it will be fixed in 2.0, anyway it's not fixed in the development version!
Commit: 74bbeda7a4d1b3faf3ddb69baa11b3096e845869
Fixed list nesting in $helptxt['manage_boards'] - Thanks DaKrampus for the report [Topic 479353]
Navigation
[0] Message Index
Go to full version