Customizing SMF > SMF Coding Discussion
Possible Security Hole in Package Manager!
[Unknown]:
--- Quote from: Jeff Lewis on March 20, 2004, 02:53:46 PM ---But the point is very valid in that a safety check should be thre regardless. Anything that causes injection should be stopped.
--- End quote ---
Erm, injection? There shouldn't be injection exactly... rather file deletion/moving/overwriting. That's what Subs-Package is all about. In fact, I could - in theory - write a .mod file for /etc/passwd right now.
I realize that sanity checks could be added, and will try to add something to block dumbness, but...
-[Unknown]
David:
Basic sanity checks should be added. Things like a package is not allowed to modify anything above the install directory.
Grudge:
I agree with David - anything outside the SMF directory should be a no no IMHO...
[Unknown]:
Yes, but there are so many ways to get past it. (/~. etc.)
-[Unknown]
jack:
Can you not use the realpath function http://www.php.net/realpath to canonicalise the path to each target file & check that before accessing it?
Navigation
[0] Message Index
[*] Previous page
Go to full version