Customizing SMF > Modifications and Packages
Descriptive Links
Gryzor:
Yes, I know this is how it's supposed to work. I'm just saying that the CODE tag is supposed to be absolute - nothing should be parsed inside it otherwise it loses its meaning.
That said, I know it's not a big problem, it's not often you put a url in a CODE tag after all :)
Gryzor:
Ok, here's a strange one. Why won't the following URL work?
--- Code: ---http://www.zxsoftware.co.uk/8bitgamer/?cat=36
--- End code ---
At least in my forum it returns an empty line...
Also, I had a report from a user of mine that when linking to a zip file directly, apparently the script tries to download the entire file before deciding what to do with it. Shouldn't it
a.ignore such files, or maybe just display their filenames directly and
b.just parse the first few bytes where the title is located (in the case of a page)?
Yoshi:
Very nice mod, been looking for something like this for a moment already :)
Though I must agree with Gryzor, the [nobbc] and [code] tags should not be included in the parsing process of this mod.
Spuds:
--- Quote from: Yoshi2889 on March 28, 2012, 11:25:26 AM ---Though I must agree with Gryzor, the [nobbc] and [code] tags should not be included in the parsing process of this mod.
--- End quote ---
Well I did release it as open source ... feel free to make those changes ;) The issue as I see it is that in order to do that you need to tie in to parse_bbc, which implys the link lookup happens then and on every page load, which would be bad for page load performance or could be under some conditions. Thats why the mod does its check outside of that function, and only does the title lookup during the saving of the post, not during the rendering of the post (which happens on every page load). So not saying you could not find a way to do that smartly, just thats not the direction I chose at that time.
--- Quote from: Gryzor on March 28, 2012, 03:25:46 AM ---Ok, here's a strange one. Why won't the following URL work?
--- Code: ---http://www.zxsoftware.co.uk/8bitgamer/?cat=36
--- End code ---
At least in my forum it returns an empty line...
--- End quote ---
Don't know, I'll have to take a look and see why its doing that
--- Quote ---Also, I had a report from a user of mine that when linking to a zip file directly, apparently the script tries to download the entire file before deciding what to do with it. Shouldn't it
a.ignore such files, or maybe just display their filenames directly and
b.just parse the first few bytes where the title is located (in the case of a page)?
--- End quote ---
It should probably skip over those type of links ... no convenient (e.g. built in to smf) way to just grab the first x bits of a page to see if you got what you want or if you asked for enough really.
Gryzor:
I can live it with parsing all links, it doesn't cause any major problems for my site (though I can see it screwing up things in others.
If you could take a look at that specific link it could help, though!
As for my other request, if there's no easy way, then at least have an extension blacklist (like all the archive files) that it won't parse...?
Thanks again for a great mod!
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version