Customizing SMF > Modifications and Packages
TinyPortal - v1.0 - update Apr. 1, 2012
Bloc:
--- Quote from: IchBin™ on July 16, 2012, 03:12:54 PM ---Looks to me like it was never coded in to pick up on the review page. So none of the panels are loaded for it.
--- End quote ---
It felt like a waste really, to make it show there too, since its using AJAX to render the preview. Adding all the block coding into that..well, to what purpose? You are just previewing a post, when its saved, THATS when you need the blocks to show.
Liam_michael:
--- Quote from: Bloc on July 17, 2012, 05:04:13 AM ---
--- Quote from: IchBin™ on July 16, 2012, 03:12:54 PM ---Looks to me like it was never coded in to pick up on the review page. So none of the panels are loaded for it.
--- End quote ---
It felt like a waste really, to make it show there too, since its using AJAX to render the preview. Adding all the block coding into that..well, to what purpose? You are just previewing a post, when its saved, THATS when you need the blocks to show.
--- End quote ---
It's really not 100% important, Bloc. Just that it looks nice and consistent if it programmed there. Once the blocks disappear, everything looks so much bigger and less compact, that's why. I like things looking compact.
Bloc:
Well, ok, but it does present a resource problem, essentially loading in things you don't need. Seeing as there might be many users doing edits/replies at once(and not just a few admins doing stuff in admin section which doesn't impact things so much) it might be looking nicer, but you also make your server work harder.
That said, I believe its possible to load in the panels initially at least - if the code isn't changed by Brad/Ichbin, I'll look it up to see if its possible.
Bloc:
Open Sources/TPortal.php and find this line:
--- Code: --- // set up the layers, but not for certain actions
if(!isset($_REQUEST['preview']) && !isset($_REQUEST['quote']) && !isset($_REQUEST['xml']) && !isset($aoptions['nolayer']))
$context['template_layers'][] = $context['TPortal']['hooks']['tp_layer'];
--- End code ---
change to :
--- Code: --- // set up the layers, but not for certain actions
if(!isset($_REQUEST['quote']) && !isset($_REQUEST['xml']) && !isset($aoptions['nolayer']))
$context['template_layers'][] = $context['TPortal']['hooks']['tp_layer'];
--- End code ---
BUT - and this is important, do keep the edits of the file intact in case you need to change back - its not certain everything works good when you change that. I didn't test anymore with panels on preview, since I found it a waste to begin with. So its UNTESTED. :)
IchBin™:
Thx Bloc! I had not taken a chance to look into the code yet. Looks like that edit makes things work in the little test I just did. Agree on your sentiments previously though. :)
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version