Topic: [4364] 2.0 RC3 - urls that contain [brackets] are truncated

[rbeuker]

When you try to use a link like the one below, SMF will truncate it:

Code: [Select]

http://www.trosradar.nl/index.php?id=artikel_detail&tx_ttnews[tt_news]=27928&cHash=ad35a38d5899c4d722702bda6f8bd7dc
Example:
=27928&cHash=ad35a38d5899c4d722702bda6f8bd7dc]http://www.trosradar.nl/index.php?id=artikel_detail&tx_ttnews[tt_news]=27928&cHash=ad35a38d5899c4d722702bda6f8bd7dc

We have solved it, by manually replacing the brackets:

Code: [Select]

[  becomes %5B
]  becomes %5D
So after doing the manual changes, the link looks like:

Code: [Select]

http://www.trosradar.nl/index.php?id=artikel_detail&tx_ttnews%5Btt_news%5D=27928&cHash=ad35a38d5899c4d722702bda6f8bd7dc
And now it works:

http://www.trosradar.nl/index.php?id=artikel_detail&tx_ttnews%5Btt_news%5D=27928&cHash=ad35a38d5899c4d722702bda6f8bd7dc

Could this be fixed in RC4?

Thanks,

Ronald

[Arantor]

It only truncates it if you let it try to auto convert to URLs, and this has been discussed before, in this very board in fact.

Specifically: http://www.simplemachines.org/community/index.php?topic=363099.0
See also: http://www.simplemachines.org/community/index.php?topic=377762.0

[rbeuker]

It only truncates it if you let it try to auto convert to URLs

I'm using the

Code: [Select]

[url] and

Code: [Select]

[/url] tags to create the URL.

Does that mean that I'm trying to auto convert to URLs?
If yes, how could I prevent this auto conversion? 

[Arantor]

Hmm, I assumed you were just posting the URL itself, which would attempt to auto convert.

What *exactly* are you typing?

[rbeuker]

Wow, you're fast!   

Ok, here goes:

The first line below shows what I will enter on the 2nd line:

Code: [Select]

[url]http://www.trosradar.nl/index.php?id=artikel_detail&tx_ttnews[tt_news]=27928&cHash=ad35a38d5899c4d722702bda6f8bd7dc[/url]
=27928&cHash=ad35a38d5899c4d722702bda6f8bd7dc]http://www.trosradar.nl/index.php?id=artikel_detail&tx_ttnews[tt_news]=27928&cHash=ad35a38d5899c4d722702bda6f8bd7dc
This is a mess... 

And now another test, using the manual fix (note that, in the middle of the URL, I have replaced the opening bracket with %5B and I have replaced the closing bracket with %5E)

Code: [Select]

[url]http://www.trosradar.nl/index.php?id=artikel_detail&tx_ttnews%5Btt_news%5D=27928&cHash=ad35a38d5899c4d722702bda6f8bd7dc[/url]
http://www.trosradar.nl/index.php?id=artikel_detail&tx_ttnews%5Btt_news%5D=27928&cHash=ad35a38d5899c4d722702bda6f8bd7dc
And this works!! 


And let's also try *without* using the url tags--in other words, using the automatic conversion by SMF:

Using the original URL:
http://www.trosradar.nl/index.php?id=artikel_detail&tx_ttnews[tt_news]=27928&cHash=ad35a38d5899c4d722702bda6f8bd7dc
Nope, not working... although it looks better than the 1st URL in this message.

Using the manually fixed URL:
http://www.trosradar.nl/index.php?id=artikel_detail&tx_ttnews%5Btt_news%5D=27928&cHash=ad35a38d5899c4d722702bda6f8bd7dc
Yes, this also works!


By the way, I wholeheartedly agree that websites should not use square brackets in their URLs. Still, it would be great if SMF could handle them (in particular when the url tags are used).

Where/how could I suggest this for a 2.0 RC4 version?

[Arantor]

You've already suggested it in the right place - it's a bug, I suppose.

This bug will effect every version of SMF, if I'm not mistaken, because it's a fundamental of how the bbcode parser works.

As an interim measure you can use [html] and post raw <a href> links or the fixed ones you've found.

[MultiformeIngegno]

I can confirm this!

[rbeuker]

Grazie!

Also to Arantor, of course

[N. N.]

I think we should keep this in mind for the next version (after 2.0).
Thank you for the report and the explanations.

[rbeuker]

No problem!

Is this in the Bug Tracker yet? (I have tried finding it myself, but have not found it)

[N. N.]

It is tracked, yes, though for the time being (only for a little while longer) the project it is tracked for is not public yet.
Around the release of 2.0 gold, the data gathered for the next SMF version should be sorted out too, and it will be public as well.

[N. N.]

According to http://tools.ietf.org/html/rfc3986#section-2.2, brackets in URLs are not valid. This cannot be considered a SMF bug.

[Oya]

except there are plenty of cases where it is used in a url even in smf itself...

[N. N.]

It really should not be.
Can you please tell, to what uses do you refer?

[Oya]

ok maybe i was slightly hasty

it IS used any time you have multiple form elements with the same name but mostly these arent sent by GET

the search system in particular uses it to identify boards to be searched - for example the contextual search for this board adds:

Code: [Select]

<input type="hidden" name="brd[37]" value="37">
your mod site definitely DOES use it though - searching for smf 20rc2 and 20rc3 gives you

http://custom.simplemachines.org/mods/index.php?action=search;downloads=;smf_versions[]=54;smf_versions[]=51;bool=or;asc;start=10

while it isnt necessarily valid html it does get used in GET for search purposes

[N. N.]

If they're sent by POST it is not an issue IMHO - it is not in the URL.

Thank you for the notification about mod site... I don't seem to manage to replicate that though.

[rbeuker]

According to http://tools.ietf.org/html/rfc3986#section-2.2, brackets in URLs are not valid. This cannot be considered a SMF bug.

I disagree. The brackets are listed on the line that shows the 'gen-delims'

Code: [Select]

gen-delims  = ":" / "/" / "?" / "#" / "[" / "]" / "@"
These delimiters may not be used a lot, but they are valid according to this RFC. I assume SMF is not parsing them correctly, because it thinks there'll be some bbc tag?

Anyway, even if you insist that this is not a bug, there's still an easy fix:

Code: [Select]

[  becomes %5B
]  becomes %5D
How about agreeing on to disagree, and still implement this fix^H^H^Hworkaround?

[Mark Rose]

rbeuker is right, here. When it talks of reserved characters, they are just legal characters with special meaning. They are part of a valid URI.

[rbeuker]

Can this please be moved back to the Bug section?

[N. N.]

You're right, SMF should then be aware of them and treat them appropriately.

Moved back, to be dealt with.

[rbeuker]

Thank you, Norv!

[rbeuker]

I'm just wondering: has this been solved now? I cannot find any 4364 ticket in the bugtracker

By the way, the issue has been also reported here: http://www.simplemachines.org/community/index.php?topic=401021.0

[Arantor]

It is in there, unsolved, but it may be deferred to 2.1 if it requires rewriting the bbcode parser, which seemslikely.

[rbeuker]

Ok, thx for the update!

[spiros]

Similar issue with parenthesis here:
http://www.simplemachines.org/community/index.php?topic=422865.0