Customizing SMF > Modifications and Packages
Voter Visibility
FrizzleFried:
Yes... I for 4 errors... and manually installed those sections...
Let see if I can remember...
Display.php
edits 1 and 4.... I believe edit 4 is where the issue is as the mod that is already installed changed the code to include ['poll'] prior to each other [] in the line...
Display.template.pho
edit 3
post.php
edit 6
Most of the manual edits were simply because something else was added to the line it was looking for... but edit 4 of the DISPLAY.PHP file there was considerable difference in the code it was looking for to place the new code after and the code I found.
FrizzleFried:
RE: That one edit...
It's looking for:
--- Code: --- $context['show_view_results_button'] = $context['allow_vote'] && (!$context['allow_poll_view'] || !$context['poll']['show_results'] || !$context['poll']['has_voted']);
--- End code ---
But what is there is:
--- Code: --- $context['poll']['show_view_results_button'] = $context['poll']['allow_vote'] && (!$context['poll']['allow_poll_view'] || !$context['poll']['show_results'] || !$context['poll']['has_voted']);
--- End code ---
Dropping what it wants to add after the above code in place below the modified code does not work.
Ray Cardillo:
Yeah, when you reported that the other mod is a "multi poll" mod I automatically assumed that the other mod is changing the default behavior of one poll per topic and touching all the places required to reference/dereference each poll that might be associated with the topic. If that's the case, I think this would always have to be a "manual" edit by the installer because you would have to make sure the references to the "poll" that my mod makes also accounts for the possibility of multiple polls per topic.
So that's what you would have to do (unfortunately)... review all of the edits my mod makes... and make sure they're using that other mods style of poll referencing to make sure each operation is happening for the correct poll. If you're a dev, it's doable (but painful), otherwise it sounds like the kinda thing that is just going to have to be incompatible since it sounds like that mod is changing the storage model slightly to account for the possibility of multiple polls being present.
FrizzleFried:
--- Quote from: Ray Cardillo on May 11, 2012, 08:42:56 PM ---Yeah, when you reported that the other mod is a "multi poll" mod I automatically assumed that the other mod is changing the default behavior of one poll per topic and touching all the places required to reference/dereference each poll that might be associated with the topic. If that's the case, I think this would always have to be a "manual" edit by the installer because you would have to make sure the references to the "poll" that my mod makes also accounts for the possibility of multiple polls per topic.
So that's what you would have to do (unfortunately)... review all of the edits my mod makes... and make sure they're using that other mods style of poll indexing to make sure each operation is happening for the correct poll. If you're a dev, it's doable (but painful), otherwise it sounds like the kinda thing that is just going to have to be incompatible since it sounds like that mod is changing the storage model slightly to account for the possibility of multiple polls being present.
--- End quote ---
Yeah... being that I am a "hack" at best... I think it comes down to deciding which mod is preferable.
:)
Ray Cardillo:
--- Quote from: FrizzleFried on May 11, 2012, 08:44:35 PM ---Yeah... being that I am a "hack" at best... I think it comes down to deciding which mod is preferable.
--- End quote ---
Sorry about that... wish there was an easier way. :-\
In the community of folks I help out, I know that multiple polls per topic would cause way too much confusion, and they wouldn't want that capability at all (or could live without it for the rare cases they thought it might be useful)... whereas they absolutely require the Voter Visibility features. So like you said, it's just a matter of determining what your members need more... or will derive more benefit from... even if they don't realize it at first. :)
Just in case others find this thread, here is a list of "off label" usages that our members started doing with the Voter Visibility mod even though I didn't explicitly design for these cases:
* Public polls for parties help people determine if their click of friends are going or not (and help decide if they are going or not) and comments can be used as a task or food signup because everyone sees the results in a public poll.
* Aside from league secretaries using discrete votes, other regular members can use them (e.g., team captain or other representatives) as a way of collecting honest feedback in a semi-private way that they can use to follow up on issues privately.
* Not only can comments be used to justify a certain answer, or provide some other info, but they can also be used as an "other" poll option. I try to advise against this practice for the most part, but it can be convenient in some cases.
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version