SMF Development > Fixed or Bogus Bugs

Themes\default\Admin.template.php - template_show_settings() / toggleBBCDisabled

(1/3) > >>

Arantor:
template_show_settings() is used for the bulk of the settings pages within the ACP and includes a function in inline Javascript for toggling the bbcode panel, yet it doesn't work.

I haven't yet figured out how to wire it up so that the 'is bbcode enabled' tickbox triggers the function correctly, but either it's a function that should be removed, or it's a function that should be used.


The function probably should be removed for the time being, it cannot possibly work correctly at present.


--- Code: --- function toggleBBCDisabled(section, disable)
{
for (var i = 0; i < document.forms.bbcForm.length; i++)
{
if (typeof(document.forms.bbcForm[i].name) == "undefined" || (document.forms.bbcForm[i].name.substr(0, 11) != "enabledTags") || (document.forms.bbcForm[i].name.indexOf(section) != 11))
continue;

document.forms.bbcForm[i].disabled = disable;
}
document.getElementById("bbc_" + section + "_select_all").disabled = disable;
}
--- End code ---

The form that contains the bbcode area doesn't contain a <form> of name bbcForm.

N. N.:
Can you please tell what is the exact behavior you are experiencing, and which should it be? Or, an example test that doesn't work as expected would be helpful.
Thank you!

Arantor:
It doesn't do anything.

You have that code in the admin template, ostensibly for toggling the bbcode options in Admin > Posts and Topics > Bulletin Board Code, like it does in 1.1.x.

The idea is that if you disable bbcode entirely, the whole list of bbcodes is supposed to be disabled too. Except the function isn't even being called and even if it were it needs totally rewriting since the HTML is different.

N. N.:
On the current svn, it seems I cannot replicate it anymore. (if I understand correctly, not sure yet :) )
I disabled the checkbox "Enable bulletin board code".
On a normal member account, I logged in and posted a reply. I had no bbc tags above the postbox. I used manually a few tags, but they were displayed as written, obviously without being parsed. (as I expected)
I'd say that's okay.

Indeed, on the same Admin page, the table with tags allowed to be used, is still full of selected tags. But for that one (if that is the problem), there's the little toggle on the bottom of the table, which seems to be working fine. ("Select all tags").

If that's what you meant, and it isn't working for you, perhaps it was solved (I'll be looking into the function you pointed immediately), or perhaps you could also tell what browser you used, just to be sure.
Or, perhaps the wanted behavior changed.

Arantor:
No...

When you untick the box, the tickboxes of all the bbcodes are supposed to disable, like it does in 1.1.11.

Go to Admin > Posts and Topics > Bulletin Board Code in both 1.1.11 and 2.0 RC3, untick the 'Enable bbcode' box and see what happens.

Navigation

[0] Message Index

[#] Next page