Advertisement:

Author Topic: Bug in post indicators for recycle bin  (Read 2520 times)

Offline Douglas

  • SMF Friend
  • SMF Hero
  • *
  • Posts: 2,934
  • Gender: Male
  • Denizen Derriere Vaculity
    • @BearlyDoug on Twitter
    • Collegiate Football History like you've never seen it!
Bug in post indicators for recycle bin
« on: June 13, 2011, 02:20:57 AM »
When you click on MARK READ, it actually sets them as new topics so the new post indicators don't go away.

This is done after the posts are removed.  Click on "MARK READ" and the "new posts" indicator comes on and doesn't go away.

2.0 Gold, only one mod installed (Twitter integration).
Using quick checkboxes for moderation. No errors in error log
« Last Edit: July 17, 2011, 03:38:50 PM by emanuele »
Resident Old Phart/Old Timer on SMF. Stalk me on Twitter:  http://twitter.com/bearlydoug

Tech Admin/Webmaster for a 6.6 million post Collegiate Sports fan site and a 1.6 million post high school sports fan site.

Collegiate Football Historian:  http://gridironhistory.com Follow @GridironHistory on Twitter to learn a lot of awesome stats.

Currently working on http://NFL.gridironhistory.com. Follow @NFLonGH too!

All sites powered by SMF 2.x

Offline emanuele

  • Developer
  • SMF Super Hero
  • *
  • Posts: 11,893
  • Gender: Male
  • Because Orange is Orange
Re: Bug in post indicators for recycle bin
« Reply #1 on: July 17, 2011, 03:37:26 PM »
The problem is that when the topic is moved to the recycle board, maxMsgID is updated to the last message id excluding the recycle board, so when the mark as read button is used in the recycle board before another post is made, the recycle board is marked as unread.

The question is why the maxMsgID is changed when a post is deleted?
It's almost useless because anyway the new id_msg (and so id_last_msg) will always be higher then the previous one...am I wrong?

Aiutateci ad aiutarvi: spiegate bene il vostro problema: no, "non funziona" non è una spiegazione!!
1) Cosa fai,
2) cosa ti aspetti,
3) cosa ottieni.

Offline Illori

  • Doc Writer
  • SMF Master
  • *
  • Posts: 25,865
Re: Bug in post indicators for recycle bin
« Reply #2 on: November 18, 2011, 09:38:44 AM »
this is still happening? should this be tracked if so?

Offline emanuele

  • Developer
  • SMF Super Hero
  • *
  • Posts: 11,893
  • Gender: Male
  • Because Orange is Orange
Re: Bug in post indicators for recycle bin
« Reply #3 on: May 06, 2012, 06:32:41 AM »
Bump to get opinions in order to avoid break anything...more than I usually do! :P

So a fix would be to remove the change of maxMsgID when a post is deleted and including the recycle board in the counts of mark as read.

Aiutateci ad aiutarvi: spiegate bene il vostro problema: no, "non funziona" non è una spiegazione!!
1) Cosa fai,
2) cosa ti aspetti,
3) cosa ottieni.

Offline Spuds

  • SMF Hero
  • ******
  • Posts: 2,046
  • Gender: Male
Re: Bug in post indicators for recycle bin
« Reply #4 on: May 06, 2012, 08:44:50 PM »
I honestly don't know ... seems worrisome to me  :-X 

Would really need to look at the code to see how and where that is used.  Maybe someone familiar with that one can comment on how that var is used. 
"It is better to have tried and failed than to have failed to try, but the result's the same."
"Give me the liberty to know, to utter, and to argue freely according to conscience, above all liberties."