SMF Development > Fixed or Bogus Bugs

2.0 RC3: GM approve attachment - not shown in log.

<< < (3/5) > >>

Arantor:
Might be helpful if you tell people you're using an SVN version of SMF not the stock RC3.

The above function is *only* for the case where the attachment is not approved to start with, and has to be approved by a moderator. Pre-approved attachments don't go through the same code flow, and if you look at the code changes, the code I've added has *nothing* to do with actually approving anything, it is *literally* for when the approve-attachment part has already been done.

ѕησω:

--- Quote from: Arantor ---Might be helpful if you tell people you're using an SVN version of SMF not the stock RC3
--- End quote ---

I didn't use a SVN version for this. I did this one of my production site thats running the public release of RC3.


--- Quote from: Arantor ---The above function is *only* for the case where the attachment is not approved to start with, and has to be approved by a moderator. Pre-approved attachments don't go through the same code flow, and if you look at the code changes, the code I've added has *nothing* to do with actually approving anything, it is *literally* for when the approve-attachment part has already been done.
--- End quote ---

Thanks for clearing that up.

N. N.:
fiber: thank you for providing insight in what an admin expects to see. Please don't doubt it is very valuable and your time to give it is appreciated. And, I think you are right, I'd regard these as bugs.

Arantor: thank you for sharing your solution to the attachments approval.
Indeed, it makes sense to me to have attachments approval logged only for unapproved attachments, while if attachments are not submitted to approval queue in the first place, I would rather think there is no need to log anything of the kind.

α¢αηѕ: I'd look at this by seeing what happens if, for example, a member's group has the right to post attachments, but they're not automatically approved (Post moderation must be enabled, and "Post attachments, but hide until approved" checked for the group, while "Post attachments, without requiring approval" unchecked for them). Then, an admin or moderator with rights to approve attachments approves it.
Thank you very much for taking a look at this. :)

Arantor:
You could log individual attachments being added to a post, it's not *that* difficult to do, just as it's not that difficult to remove again. Like I said, we've done this in SimpleDesk as part of the event log on a ticket, so if you create a ticket with an attachment, you get:


--- Quote ---"Ticket name" opened. Files added: test.zip
--- End quote ---
in our action log, which can be displayed on a per ticket basis.

Since our attachment code is based heavily on SMF's but with a few tweaks I'm sure I could dig it out how it's done.

N. N.:
About logging any attachments uploading (not approvals):
I wasn't referring to difficulty, I was referring to usability and usefulness.
Usability: if the log is too full with information admins/moderators don't really need, they may find it harder to find the information they need, and less likely to gain the same benefit from the log.
Usefulness: I find it unlikely to be useful to have yet another record of what is, mostly, though not fully, already there: visible in the post itself and in the Attachments area of Admin panel. There is no usefulness that I see in logging who submitted a post, and just the same, in logging who submitted an attachment.
Unless perhaps for very particular needs (and forums), not by default.

Approval, being a moderation action, is IMHO another story altogether.
SimpleDesk, as a mod with a particular target and particular needs, is another story too.

Navigation

[0] Message Index

[#] Next page

[*] Previous page