Topic: [TRICK] displaying the "unknown action" in the who's online list

[OzzyMozzy]

That's ok at least it's not saying Unknown action anymore. thanks heaps

[ChalkCat]

Hi, me again!  As I've said earlier in this topic, this trick is working great for me.  However, I decided to sort out my error logs, so I deleted all errors, went about my business and checked back.  Within a few minutes of leaving my computer on the auto-refreshing Who's Online, I had 30 instances of this error:

http://******.com/index.php?action=who
8: Undefined variable: scripturl
File: /home/content/**/*******/html/******/Sources/Who.php
Line: 451

Line 451 is this:

Code: [Select]

// Unlisted or unknown action.
else
$data[$k] = $txt['who_thisaction'] . '<a href="' . $scripturl . '?action=' . $actions['action'] . '">' . $actions['action'] . '</a>';

Please can you help me stop this error from occurring, or is everyone else getting it and it's just something I have to accept?  As I said, there are no problems with the trick itself, it does exactly what it should.

Thank you 

[Kindred]

Hmmmmm... Really? Wonder why it does not trigger that for me.

Anyway, simple fix. Add
 global $scripturl;
Up above... At the start of the function, where the other global declarations are

[ChalkCat]

Thanks Kindred, I think I've put it in the right place 

Just emptied my error log again so I'll see what appears now.  Thanks for the fast response 

[Kindred]

now that I can get to my code from an actual computer:

Code: (find in Sources/Who.php) [Select]

function determineActions($urls, $preferred_prefix = false)
{
  global $txt, $user_info, $modSettings, $smcFunc, $context;


Code: (add after) [Select]

global $scripturl;

edit- after looking through the code, I wonder why this error was not noticed before...   because, in the core, unedited code, it looks like $scripturl is not actually defined in the determineActions function. It must have been added by another mod to my code and I missed it for the trick.   Original code in the first post has been edited.

[ChalkCat]

Woohoo!  I had put it in the right place and that seems to have sorted it!  I have left it on the WO for ages and no more errors have appeared in the log.  Brilliant, thanks Kindred 

[Cutter65]

Installed this tip today and it works great!

Thanks Kindred!

[[UGP]Jeffry]

Hello, first of all sorry for bumping this topic, but this seems to be useful and might be worth to discuss about.
So I have added the code of the first post, and now it shows

Viewing the portal

anywhere, where before Unknown Action was taking place.
Whats up to this portal thing? Can it be removed from the actions, because even if it shows that somebody is viewing the portal, they DO NOT view it. :/

Any ideas?

[Shambles]

Just change the text to read

Not viewing the portal

Doddle


Joking aside, do you actually have a portal installed?

[Kindred]

right... so, if you have a portal installed, then it sounds like the default "action" is "portal" which comes across as "viewing the portal"

(as I just realized that we have already discussed, if you read back a  few messages)

Some portals may interfere with the action list.... they assume that you are always in the portal unless you are doing something specific.