Thanks for your explanation and it does do you credit that you look for problems like this.
I'll fill you in a bit about me. I have been programming since I was 11; writing machine code on my ZX Spectrum; did O and A level computer science and studied Computer Science at University too learning wonderful languages like C and Modular 2 (most of which I have long forgotten about) and more recently I gained some Web developer & IT qualifications. Now I am in my 40s and still enjoying it every day.
That's the short version. But it's just to set your mind at ease a little really. I have spent years writing, editing and designing code. To be fair I have only been working with PHP for maybe 5 years now, I still have stuff to learn. I still have a lot to learn about the SMF system too and it's internals, but I really like the way both versions have been written.
Often rather than sift through the code and figure out what they did I simply ask if anyone knows how one bit works or why it doesn't work as expected. Sometimes that's all I need to know.
I tend not to have tunnel vision when I code, but I know what you mean. Currently I am spending hours on the security aspects of my mod and I will try not to leave a stone unturned. I am never satisfied with the code I write unless it's something simple.
But I never considered myself an expert. But I do try to do a proper job, there are no short-cuts here. That's why I said I would take people's suggestions seriously and I did; it's just that some of them I was able to dismiss. It won't stop me going back to look at it again though, now that you guys have pointed out some things to look at.
If you weren't there to pick up the pieces then you wouldn't have a job maybe lol
But I get your point.