Topic: post textarea fixed cols="600"?

[emanuele]

I'm not sure if it is intended (because of IE ) or what:

Code: [Select]

<textarea class="editor" name="', $editor_id, '" id="', $editor_id, '" rows="', $editor_context['rows'], '" cols="600" onselect="storeCaret(this);" onclick="storeCaret(this);" onkeyup="storeCaret(this);" onchange="storeCaret(this);" tabindex="', $context['tabindex']++, '" style="height: ', $editor_context['height'], '; ', isset($context['post_error']['no_message']) || isset($context['post_error']['long_message']) ? 'border: 1px solid red;' : '', '">', $editor_context['value'], '</textarea>
In the last RC it was:

Code: [Select]

<textarea class="editor" name="', $editor_id, '" id="', $editor_id, '" rows="', $editor_context['rows'], '" cols=" ', $context['browser']['is_ie8'] ? '600' : $editor_context['columns'], '" onselect="storeCaret(this);" onclick="storeCaret(this);" onkeyup="storeCaret(this);" onchange="storeCaret(this);" tabindex="', $context['tabindex']++, '" style="width: ', $editor_context['width'], '; height: ', $editor_context['height'], '; ', isset($context['post_error']['no_message']) || isset($context['post_error']['long_message']) ? 'border: 1px solid red;' : '', '">', $editor_context['value'], '</textarea>

[live627]

That was the alleged "fix" for the IE8 jumping textarea bug that broke something else.

HD&R

[Joker™]

emanuele you missed that post.

[emanuele]

Yes, I missed the entire topic (mainly because I'm more or less ignoring that board... I'm not that good with themes).

I reported it here because in the Italian board has been reported that with Chrome (12.0.741.122 and XP) the right end of textarea goes far outside the visible area and reverting to the RC5 code fix the problem.

I don't know anything about Chrome, so I don't know if it is relevant or not.

[Illori]

this should fix the problem correctly

take a look at

Hello there.

Try with this, in index.css change:

Code: [Select]

#quickReplyOptions form textarea
{
    height: 100px;
    margin: 0.25em 0 1em 0;
}

to this:

Code: [Select]

#quickReplyOptions form textarea
{
    height: 100px;
    width: 635px;
    max-width: 100%;
    min-width: 100%;
    margin: 0.25em 0 1em 0;
}
Also, if your theme isnt built for 2.0 (but it is for RC5) please read this topic with tip to update theme from RC5 to 2.0 version:
http://www.simplemachines.org/community/index.php?topic=437428.0

Regards.

[emanuele]

Not really because it's not the quick reply.

In the post page the relevant default css should be:

Code: [Select]

.editor
{
width: 100%;
max-width: 100%;
min-width: 100%;
}So the 100% should be changed to 635px?...doesn't it make useless the min and max and keep the editor at a fixed width?

[Illori]

that fix applies to both editors from what i understand and fixed the quick reply editor on my forum.

[emanuele]

In the default theme I can't find an id "quickReplyOptions" in the post page.

[Illori]

did the user clear their browser and server cache?

[Antechinus]

Yes, I missed the entire topic (mainly because I'm more or less ignoring that board... I'm not that good with themes).

I reported it here because in the Italian board has been reported that with Chrome (12.0.741.122 and XP) the right end of textarea goes far outside the visible area and reverting to the RC5 code fix the problem.

I don't know anything about Chrome, so I don't know if it is relevant or not.

It works fine in Chrome and XP. Was tested on that combo, among others. Yes, the code change you noted in the OP was intentional. Yes, it was because of bloody IE (as most things are).

Like all complaints about this so-called "regression" the problem will be caused by one of two things: either the user did not clear their browser cache after the upgrade, or they are using an older custom theme which has not had the required markup and/or css changes made correctly.

The requirement to clear cache has already been tracked as a known issue in 2.0: http://dev.simplemachines.org/mantis/view.php?id=4750

Editing custom themes after upgrading from release candidates is standard practice anyway.

[emanuele]

Thanks all and sorry for the double/triple/whatever topic.