Simple Machines Community Forum

SMF Development => Bug Reports => Fixed or Bogus Bugs => Topic started by: Kettu on July 19, 2008, 01:05:00 AM

Title: Label - Bug
Post by: Kettu on July 19, 2008, 01:05:00 AM
Hi, I couldn't find that bug around here so I open a new topic.
I was working with labels today and labeled a few private messages. After labeling a message I deleted some others and checked twice that only those messages were checked I wanted to delete. Well all checked messages have been deleted including the messages I had labeled on that page before.
Same problem, but fortunately not deleted, a few minutes later. I labeled a message with "important" and than on the same page 2 messages with another label but finally found all 3 under the last chosen label.
So I think the refreshing function there isn't working correct. The labeled messages are still checked for the system but invisible :(
Title: Re: Label - Bug
Post by: SleePy on July 19, 2008, 08:24:06 PM
This sounds more like a browser bug..

Did you try another browser?

What version of smf are you using?
Title: Re: Label - Bug
Post by: Kettu on July 25, 2008, 05:02:46 AM
Quote from: SleePy on July 19, 2008, 08:24:06 PM
This sounds more like a browser bug..

Did you try another browser?
No, I didn't because I am using Firefox version 2.0.0.16 and 3. I have tested it at 2.0.0.16 again with the same result. I'll test it with the new version as soon as I can.
But I've tested it in another way right now. I've checked all boxes at the summery and deleted the checks at those I don't want to lavel. After labelling the checkboxes at the complete messages were empty but at the summery still checked.

Quote from: SleePy on July 19, 2008, 08:24:06 PMWhat version of smf are you using?
As you see in my signature I am using 1.1.5.

Edit:
Okay, I've checked it with Firefox 3, same problem. The checkbox of the summery is still checked after labelling. Like shown in the screenshot.
Title: Re: Label - Bug
Post by: SleePy on July 26, 2008, 02:32:44 AM
Do you have any mods installed?
Quickly tested and I didn't get it to occur.
Title: Re: Label - Bug
Post by: Thantos on July 26, 2008, 12:48:28 PM
Can you try it with the default theme and see if the problem still occurs.  In addition you mind trying it with Internet Explorer?  Thanks
Title: Re: Label - Bug
Post by: Kettu on July 27, 2008, 10:29:13 AM
Quote from: SleePy on July 26, 2008, 02:32:44 AM
Do you have any mods installed?
Quickly tested and I didn't get it to occur.
I have tested it in a forum without any mods with FF 3 but error still occurs.

Quote from: Thantos on July 26, 2008, 12:48:28 PM
Can you try it with the default theme and see if the problem still occurs.  In addition you mind trying it with Internet Explorer?  Thanks
I have tried it with default: error occurs.
I have tried it with Windows and Linux: error occurs.
I have tried it with Internet Explorer on a friend's laptop with his account: error still occurs.
Title: Re: Label - Bug
Post by: SleePy on July 27, 2008, 07:37:07 PM
The code will keep messages selected if you previously selected them (to do something such as labeling the message).

It should be showing that those are selected.

Try this..
open PersonalMessage.template.php
Find:
                                        <input style="vertical-align: middle;" type="checkbox" name="pms[]" id="deletedisplay', $message['id'], '" value="', $message['id'], '" class="check" onclick="document.getElementById(\'deletelisting', $message['id'], '\').checked = this.checked;" />

Replace
                                        <input style="vertical-align: middle;" type="checkbox" name="pms[]" id="deletedisplay', $message['id'], '" value="', $message['id'], '"', $message['is_selected'] ? ' checked="checked"' : '', '  class="check" onclick="document.getElementById(\'deletelisting', $message['id'], '\').checked = this.checked;" />
Title: Re: Label - Bug
Post by: Kettu on July 28, 2008, 11:11:40 AM
Thanks SleePy, but now all checkboxes are still ckecked after labeling.
Title: Re: Label - Bug
Post by: SleePy on July 28, 2008, 12:31:01 PM
Yes, wouldn't that be the intent?
The checkboxes are there so that way you can quickly use them again to do something such as another label.
Title: Re: Label - Bug
Post by: Kettu on July 30, 2008, 10:12:00 AM
Quote from: SleePy on July 28, 2008, 12:31:01 PM
Yes, wouldn't that be the intent?
The checkboxes are there so that way you can quickly use them again to do something such as another label.
Well, it is much better than before but shouldn't it be that all messages are unmarked after successful labeling?