Simple Machines Community Forum

SMF Support => SMF 2.0.x Support => Topic started by: DukeN on March 05, 2010, 07:04:29 AM

Title: {ACTIVATIONLINKWITHOUTCODE} in emails
Post by: DukeN on March 05, 2010, 07:04:29 AM
Hi,

Lets hope there is somekind of Jedi here that can solve this problem. I tried a lot of settings and tried to change some files but didn't had any luck yet.

I got a rather big forum and i just noticted that the registration emails aren't corrent. (Every mail with " {ACTIVATIONLINKWITHOUTCODE} " isn't good.

Example (dutch email):


Hallo Username,

Je hebt nog steeds je account op XXXX Forum niet geactiveerd.

Gebruik de link hieronder om je account nu te activeren:
http://www.xxxx.nl/forums/index.php?action=activate;u=66888;code=856754682e

Mocht je problemen ondervinden met de activatie, bezoek dan {ACTIVATIONLINKWITHOUTCODE} en vul daar de code "{ACTIVATIONCODE}" in.

Met vriendelijke groet,

Het XXXX.NL Forum team.



It looks like SMF doens't know the "{ACTIVATIONLINKWITHOUTCODE}" command.

When i check the emailtemplates.dutch.php (or english) the source looks fine:
subject' => 'Welkom op {FORUMNAME}',
'body' => 'Bedankt voor je registratie op {FORUMNAME}. Je gebruikersnaam is {USERNAME}. Mocht je je wachtwoord vergeten zijn, dan kun je het opnieuw instellen via {FORGOTPASSWORDLINK}.

Voordat je in kunt loggen, dien je eerst je account te activeren. Om dit te doen, klik je op deze link:

{ACTIVATIONLINK}

Mocht je problemen ondervinden met de activatie, bezoek dan {ACTIVATIONLINKWITHOUTCODE} en vul daar de code "{ACTIVATIONCODE}" in.

{REGARDS}',


Where is the Jedi that is able to help me?

Thanks!

edit: SMF 2.0 RC2
Title: Re: {ACTIVATIONLINKWITHOUTCODE} in emails
Post by: Oldiesmann on March 05, 2010, 12:16:26 PM
Sources/Register.php

Find
$replacements = array(
'REALNAME' => $row['real_name'],
'USERNAME' => $row['member_name'],
'ACTIVATIONLINK' => $scripturl . '?action=activate;u=' . $row['id_member'] . ';code=' . $row['validation_code'],
'FORGOTPASSWORDLINK' => $scripturl . '?action=reminder',
);


Replace
$replacements = array(
'REALNAME' => $row['real_name'],
'USERNAME' => $row['member_name'],
'ACTIVATIONLINK' => $scripturl . '?action=activate;u=' . $row['id_member'] . ';code=' . $row['validation_code'],
'ACTIVATIONLINKWITHOUTCODE' => $scripturl . '?action=activate;u=' . $row['id_member'],
'ACTIVATIONCODE' => $row['validation_code'],
'FORGOTPASSWORDLINK' => $scripturl . '?action=reminder',
);
Title: Re: {ACTIVATIONLINKWITHOUTCODE} in emails
Post by: DukeN on March 05, 2010, 01:56:49 PM
No luck there...

Already have it in register.php

$replacements = array(
'REALNAME' => $row['real_name'],
'USERNAME' => $row['member_name'],
'ACTIVATIONLINK' => $scripturl . '?action=activate;u=' . $row['id_member'] . ';code=' . $row['validation_code'],
'ACTIVATIONCODE' => $row['validation_code'],
'FORGOTPASSWORDLINK' => $scripturl . '?action=reminder',
);


Any other Idea?
Title: Re: {ACTIVATIONLINKWITHOUTCODE} in emails
Post by: hadesflames on March 05, 2010, 01:57:55 PM
but the one you have doesn't include:

'ACTIVATIONLINKWITHOUTCODE' => $scripturl . '?action=activate;u=' . $row['id_member'],
Title: Re: {ACTIVATIONLINKWITHOUTCODE} in emails
Post by: Brettflan on March 24, 2010, 01:53:57 PM
I had this happen with a new German user right after the RC3 update. The user said that the activation link itself did not work. However, testing it later myself I got the German version of the activation e-mail with everything formatted properly. So it looks like it effectively fixed itself.

Have you tried registering another account with German language selected to see if you get an e-mail formatted the same as that one?

Perhaps the user registered during the upgrade process, or right afterward with some old SMF cached files still not updated/cleaned out.
Title: Re: {ACTIVATIONLINKWITHOUTCODE} in emails
Post by: chilly on March 24, 2010, 03:51:54 PM
OP wrote that the variables are not replaced and he doesnt get the link / code at all.

a not working link sounds different. i already encountered the "not working link"-problem depending on the e-mail service the user uses.
gmx and web.de cause problems cause they replace the link to point somewhere on their side and after that they redirect. that redirection doesnt use the correct link what causes the link not to work.

But the code above already shows that the replacement for activationlink without code is completely missing. id say that looks like the source of the problem