Simple Machines Community Forum

Link to Mod (http://custom.simplemachines.org/mods/index.php?mod=3805)

---

This MODification allows you to display all the membergroups a user is member of, both in topics view and in profile. You can choose whether or not to show the additional membergroups and, if you choose to show them, whether or not to show the membergroup name (in this case, only the "stars" will be shown)

Languages:
     - English

Changelog

Version 1.01 // 22-01-2014
================================================================================
! Fixed minor bug, not showing the post count group stars

Version 1.00 // 23-11-2013
================================================================================
+ First release

Legend:
--------------------------------------------------------------------------------
! Minor change or bugfix.
+ Feature addition or improvement.
- Feature or option removal.


I installed this mod but had to fight with it due to the google member map mod. I got it to work but I get the following errors each time a thread is visited.
2: Illegal string offset 'stars_img'
Apply Filter: Only show the errors from this file
File: /community/Themes/default/Display.template.php
Line: 342

2: Illegal string offset 'group'
Apply Filter: Only show the errors from this file
File: /community/Themes/default/Display.template.php
Line: 340

The following is what is found at lines 340 and 342:
<li class="membergroup">', $temp['group'], '</li>';
echo '
<li class="membergroup">', $temp['stars_img'], '</li>';

It seems like it has something to do only with additional member groups showing up in post that I have made as there are 2 "Y's" under my groups. It doesn't happen on any other posts. Any ideas what would cause this?

Hi,

I cannot reproduce that, I don't know why you're getting that.

Try to add some debug into Display.template.php
Find:
if (!empty($message['member']['additional_groups_full'])) {
Add after
if ($context['user']['is_admin'])
{
echo '<pre>';
print_r($message['member']['additional_groups_full']);
echo '</pre>';
}


This will show only to admins the full array of additional membergroups, please paste it here. It should return something like this:
Array
(
    [0] => Array
        (
            [group_id] => 2
            [group_color] => #0000FF
            [group] => Global Moderator
            [stars] => 5#stargmod.gif
            [stars_img] => *****
        )

)

I think I narrowed it down to me messing up something in Load.php trying to get it to work with the Member Map mod.

I figured it out. It's when custom profile fields are shown in topic view. Any idea what would fix it?

If I delete the text from the custom profile field or deselect "show in topic view"  to keep the field from showing, the problem goes away.

Hopefully there is a solution cause this would make a great addition to our forum.

I'm sorry, I'm working abroad this week so I can only check that after the weekend, probably.

Thank you for checking and reporting ;)

No problem. Thanks for looking into it.

Just had the change to peek it. You are correct, this is a real bug. I'll fix it shortly ;)

edit: weird issue :P fixed ;)

Just installed. Works like a charm.

Thanks!

Ahhh... Just noticed that I get errors in the error log when visiting profiles. It doesn't seem to error on my admin account but throws errors on some of the other accounts, but not all.

http://www.bayoustatefishing.com/community/index.php?action=profile;area=summary;u=49
Apply Filter: Only show the errors with the same message
8: Undefined index: additional_groups
Apply Filter: Only show the errors from this file
File: /Sources/Profile.php
Line: 166

Line 166:
'enabled' => $context['user']['is_admin'] || ($cur_profile['id_group'] != 1 && !in_array(1, explode(',',


EDIT: Seems like it throws the error if their primary membergroup is set to something other than "no primary membergroup". with nothing selected in additional membergroups. If I change it then the errors go away. Wierd thing is if I go back to the origional settings in the profile, the errors don't come back...

If that makes sense.

Ok. I'm not sure if this makes any sense but, If I visit a profile, it throws the error the first 2 visits. For some reason it doesn't throw the error on that profile on the 3rd visit.

:o Maybe some cache related issue, dunno. What's your cache configuration?

Thanks ;)

Set to "no caching"

Actually I was looking at it and you are right. I see the issue now.

It's actually strange how this slipped. I checked this over and over. Well, I think not enough :P
Give me some minutes ;)

Ok. Great! :) If possible, could you list the changes that you make? It would be easier for me to change them manually since I have other mods that affect the installation of this one through the package manager.

Fixed.

Changes:
In this case, Sources/Profile.php (a new operation)
Find:
'enabled' => $context['user']['is_admin'] || ($cur_profile['id_group'] != 1 && !in_array(1, explode(',', $cur_profile['additional_groups']))),
Replace with:
'enabled' => $context['user']['is_admin'] || ($cur_profile['id_group'] != 1 && !in_array(1, $cur_profile['additional_groups_list'])),

Good deal!! No more errors.

Thanks for the mod. Love it!!

Glad it works for you.

Thank you for reporting the issues ;-)

Thanks for showing me this mod. It installed properly on my forum.

Infortunately, I still can't see my post count based badges. Would you have any idea on how to solve this problem ?

Do your members have primary membergroups? There is an option to hide the post count membergroups if the user has a primary one. I don't remember which option is it out of my head, though...

Quote from: margarett on April 20, 2014, 05:27:23 AM
Do your members have primary membergroups? There is an option to hide the post count membergroups if the user has a primary one. I don't remember which option is it out of my head, though...

Yes they have, but the option to hide post group titles (in theme settings) is correctly unchecked.

What is weird is ff I don't assign a primary membergroup to my member, it shows correctly all groups but if I assigned a primary membergroup it doesn't work.
You have a perfect example of what I'm saying here  (http://www.lux-optima.com/tokina/76/tokina/181/). The first member has his primary membergroup assigned and the second not.

It has to be that option... If you uninstall the mod, you have the same behavior, right?

Quote from: margarett on April 20, 2014, 06:38:55 AM
It has to be that option... If you uninstall the mod, you have the same behavior, right?

I'm not sure it's coming from this option and I don't think it's coming from your mod.
If I uninstall the mod, I have still weird result.

If the option we're talking about is checked (so that mean we hide post group title), i get those result :
- Member which have a primary member group : Show the badge and the title of the primary member group
- Member which don't have a primary member (but have one additional group and one post count based group) : Show the badge and the title...of the post count based group.

If the option we're talking about is unchecked (so that mean we showpost group title), i get those result :
- Member which have a primary member group : Show the badge and the title of the primary member group AND the title of the post count based group.
- Member which don't have a primary member (but have one additional group and one post count based group) : Show the badge and the title...of the post count based group AND nothing else!

If you have some ideas of what I could check to clarify that, I would be very grateful if you can help me...but as I have the feeling this is not directly related to your mod, it's also perfectly ok if you don't.

I just would like to know if affecting a primary member have some importance, and if yes, what kind of importance ?
Thanks.

...just one more thing : the post count based group title shows correctly even when the badge of this group doesn't show !!  :o :o :o

...and if I debug (using 'print_r') exactly as you explained it above, I get no sign of post count based groups... :o

Hi.

What you have is *exactly* how SMF operates, regarding display of membergroups. To recap:

* Additional membergroups are NOT shown anywhere. They are used for permissions only and aren't displayed really anywhere.

* Primary membergroup is always shown if existent. Name and badge (if badge is defined)

* Post count membergroup depends on the primary membergroup and that setting you found:
- Not existent primary group --> name and badge (stars) of the post count group are shown
- Existent primary group --> only name of post count group is shown *if* the mentioned is unchecked. If checked, nothing is shown.

Clear now?

This is what you get with this MOD:
Array
(
    [username] => admin
    [name] => admin
    [id] => 1
..............
    [group] => Administrator
    [group_color] => #FF0000
    [group_id] => 1
    [post_group] => Newbie
    [post_group_color] =>
..............
    [additional_groups_list] => Array
        (
            [0] => 9
        )
So I don't change how SMF deals with the post count membergroups...
I don't remember anymore :P do you want to have the post count group IDs or the full info? (ie, stars and so on)

Thank you for taking your time on my problem  :)

What I would like is to see in topics view (and in profile) :
- Primary member group stars
- Additional member group stars
and
- Post count member group stars

When I debug, by using this code :
print_r($message['member']['additional_groups_full'])

I get only that :
Array
(
    [0] => Array
        (
            [group_id] => 29
            [group_color] =>
            [group] => Founder
            [stars] => 1#founder_member.png
            [stars_img] => *
        )

    [1] => Array
        (
            [group_id] => 36
            [group_color] =>
            [group] => Featured_1
            [stars] => 1#featured_1
            [stars_img] => *
        )

)

when this member belongs to :
- Admin (primary)
- Founder (additional)
- Featured (additional)
- Member 2.0 (post count)

Margarett, Congratulations, this mod is perfect. Tested and approved.

Suggestion for new feature or a new mod.

Option to display additional groups only in profile. To do this I removed the modifications made in the Display.template.php

Thank you so much, i've been trying to do something like this for a while now.
and had only came across this today.

Got everything working perfectly, the way i wanted.

However, since i've installed this, none of my member-groups have colors now.
Not entirely sure what happened.

Hi.

Membergroups usually don't have colors. So you probably had some MOD to make that happen and that is probably incompatible with this one...

Quote from: margarett on June 13, 2014, 05:18:09 AM
Hi.

Membergroups usually don't have colors. So you probably had some MOD to make that happen and that is probably incompatible with this one...

Ah, yes.
That is indeed is what is happening, this removes some calls from load that "SimpleColorizer" uses to color names.

How would someone color names in posts and profile, when using this mod?

Yup, and it should be fairly easy ;)
With this MOD installed, all relevant parameters are already there:

    [group] => Administrator
    [group_color] => #FF0000
    [group_id] => 1
    [post_group] => Newbie
    [post_group_color] => #FF00FF

So you just need to colorize your display name if "group_color" or "post_group_color" are !empty ;)

Quote from: margarett on June 19, 2014, 11:44:17 AM
Yup, and it should be fairly easy ;)
With this MOD installed, all relevant parameters are already there:

Code Select Expand


    [group] => Administrator
    [group_color] => #FF0000
    [group_id] => 1
    [post_group] => Newbie
    [post_group_color] => #FF00FF

So you just need to colorize your display name if "group_color" or "post_group_color" are !empty ;)

Oh well that's all great then, but every time i attempt something like that, it doesn't apply the color, and additionally removes the font formatting.

I'm most definitely doing something really wrong.

// Show a link to the member's profile.

if (!empty($message['member']['group_color']))
echo '

<li style="color: ',$message['member']['group_color'], ';">',$message['member']['link'],'</li>';'

</h4>';

You can't really style the "<li ...."
Best chance would be a span but that doesn't work (just tested it :P )

That needs to be filled in Display.php... $message['member']['link'] comes already "coloured" so you can't really bypass that in Display.template.php

I'm checking...

edit: I was wrong. I need to check...

edit2: Actually it is in Load.php :P
Find:
'link' => '<a href="' . $scripturl . '?action=profile;u=' . $profile['id_member'] . '" title="' . $txt['profile_of'] . ' ' . $profile['real_name'] . '">' . $profile['real_name'] . '</a>',
Replace with:
'link' => '<a ' . (empty($profile['member_group_color']) ? '' : 'style="color:' . $profile['member_group_color'] . '" ') . ' href="' . $scripturl . '?action=profile;u=' . $profile['id_member'] . '" title="' . $txt['profile_of'] . ' ' . $profile['real_name'] . '">' . $profile['real_name'] . '</a>',
Only works for primary group, though ;)

Quote from: margarett on June 19, 2014, 01:03:16 PM
You can't really style the "<li ...."
Best chance would be a span but that doesn't work (just tested it :P )

That needs to be filled in Display.php... $message['member']['link'] comes already "coloured" so you can't really bypass that in Display.template.php

I'm checking...

edit: I was wrong. I need to check...

edit2: Actually it is in Load.php :P
Find:

Code Select Expand

'link' => '<a href="' . $scripturl . '?action=profile;u=' . $profile['id_member'] . '" title="' . $txt['profile_of'] . ' ' . $profile['real_name'] . '">' . $profile['real_name'] . '</a>',
Replace with:

Code Select Expand

'link' => '<a ' . (empty($profile['member_group_color']) ? '' : 'style="color:' . $profile['member_group_color'] . '" ') . ' href="' . $scripturl . '?action=profile;u=' . $profile['id_member'] . '" title="' . $txt['profile_of'] . ' ' . $profile['real_name'] . '">' . $profile['real_name'] . '</a>',
Only works for primary group, though ;)

I've replaced that, yet it still doesn't color my names in posts
Was there anything else i had to replace?

I removed what i had in my earlier post, since it didn't work.

No, just that... Try in default theme and uninstall your colorizer mod ;)

I had the wrong 'link', it works now perfectly.


Thank you! :D

i want that (Admin of DeathMatch) and (Admin of Clanwar) show down on Admin of public

It shows up in topic view. In profile view it only shows where you now see it...

i cant edit it ??

You can. However, the lines you pointed out in the profile view are already at the place you want them in topic view.

Do you also want to move them in profile view?

hmm but only names not stars

In topic view it will show you the stars, if defined in the membergroup, and the name if you check that option in Modifications Settings.
(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fcustom.simplemachines.org%2Fmods%2Findex.php%3Faction-download%3Bmod%3D3805%3Bid%3D226376%3Bimage&hash=c1564c40bde6a9ac2e8626893cf0e5a965736011)

no i want to remove
Additional Membergroups:
    (Admin of DeathMatch)
Additional Membergroups:
    (Admin of Clanwar) on profile view

and add them like that
i use inspect element for example :D

please work it now i want it now :D

Are you serious? :o

yes :D

Quote from: SumairAli on July 07, 2014, 01:56:21 PM
please work it now i want it now :D

WOW! :o

If I were a mod author, that would be a sure way to get me to put something on hold, just on principal. Just sayin...

Everybody here works on their own time. You have to be patient when asking for assistance or when asking for something which is free. Even if you were paying for a service, most of the time there would be a wait time.

Once again, just sayin.

Quote from: SumairAli on July 07, 2014, 02:14:06 PM
yes :D

Go talk to your mom.

Quote from: SumairAli on July 07, 2014, 02:14:06 PM
yes :D

Learn some patience.
We all are VOLUNTEERS, and there's no need for demanding, for something you WANT.
Have a problem with that? TOUGH LUCK.

Quote from: BurkeKnight on July 07, 2014, 02:40:17 PM

Quote from: SumairAli on July 07, 2014, 02:14:06 PM
yes :D

Learn some patience.
We all are VOLUNTEERS, and there's no need for demanding, for something you WANT.
Have a problem with that? TOUGH LUCK.

+1 being rude and obnoxious oddly enough does not propel people into action for you. The entire project is based on volunteer help and time together will good will. You should really think twice before posting.

Sorrrrrrrrrrrrrrrrrrrrrrrrrrrrrry

Saying it like that, one would tend to doubt your sincerity. :(

Thanks for the mod :).

Using it with a simple hack to show only one additional membergroup:
if (!empty($modSettings['show_additional_groups_name']) && ($temp['group'] == "Groupname"))

It's not perfect but hell, it works and is exactly what I need!

Hi, I just tried out your mod (I have Child Board Removal and Like Posts as the only other mods and I'm using the Default theme).  I found I was getting some weird behavior with the group memberships (which disappeared when I uninstalled your mod).

I have two membership-based groups and the usual slew of point-based groups.  What I came here for was a way to show what groups a member belongs to (none, one or both) as well as showing their post-based group.

After install I looked at a test account that was a member of both groups and it showed one group's color (without a name) then showed the second group's name and color.  Going into the Forum Profile and looking at the "Group membership" area is where things got really weird.  It only showed the member as being in one of the two groups (even though they could access the forums for the other group).  The other group was back down at the bottom with "Join Group" next to it.  Then it got a bit stranger, if you selected "Registered Members" and clicked on the "Make Primary Group" button, the non-points based group was dropped and now appeared in the bottom section with "Join Group" next to it!  This time, the member really was knocked out of that group so now there are two groups at the bottom (both saying you could join them), but one was already joined and the other wasn't.

I did have one custom profile field and saw some comment about those above so I deleted it as a test - but no change.

Any idea why I was seeing this type of behavior?  I'd love to use this mod if possible.

Thanks,

Craig

FYI - I just realized that there was a button for enabling Advanced Profile Fields in the Core Features area so I turned that off and tried things again.  This time, the display was correct (i.e., a yellow star for the point-based group, then separate areas for each member-based group with names and stars).  I started to get excited that this was going to work (and loved being able to see the memberships when viewing a profile), then I went into the Profile area for my test account and, in the Group Membership area, it only showed that the member was in the Registered Members group.  Both of the other groups were down in the bottom section with "Join Group" next to them...  I was more than a little bummed, I thought I had figured it out - oh well.

:(

Hmmmm... How odd. I guess I never tried joinable groups. I need to check if I can reproduce this behavior...

That would be very appreciated (and you definitely don't need to do it NOW - lol).  :)

If it helps, the groups were set up as "Free (User may leave and join group at will)".

Thanks for the help!

Craig

Any luck duplicating the issue?  :)

Humm it really seems there's a bug in that area... As soon as I get there I see an "undefined error" after installing my MOD :(

Have to check further ;)

Thanks for looking into this!  I'd love to use this mod.  :)

Hello, after my message here (http://www.simplemachines.org/community/index.php?topic=528392.0), i repost my question because it's seems that i was wrong about this topic.

First, thank you for this mod, it's pretty nice with additional author too.

Second, i have a question/request about this mod.

There is a way to display only maybe 2 or 3 additional membergroup in topic? Because i use image rank and with 3+ additional, it's a maybe little too much.

And third, this is not an option with this mod, but there is a way or another mod who the user can choose maybe his/her X number (example 3)  favorite group to display?

Thank you  :)

@NW Dreamer: it's not forgotten by I really had no time to look at that :(

@Shadight:
First: thank you :)
Second:
a) Not really, no. It should be easily accomplished in the code, I can help you do it if you want but it's not something I'd like to add to this MOD.
b) Also not. There are no user settings for it since this is what I call an "administrative addon". It's up to the administrator to decide if and how to use. To add user settings is amazingly complex (especially because you can be part of groups that you don't even know -- permission groups behind the curtains, etc).
For both cases, you (administrator) can set a group with visibility = invisible, this will prevent said group to be shown ;)

Okay, thank you for your answers and i don't want to bother you for my first question.

Because i work on a "project" forum and i'm not sure to release it, so give you work for maybe nothing, will be stupid from me.

And okay no problem for my second question. If this thing was possible, i think It would have been a great combo with my first question.

Anyway, thank you for your help.

Finally. Released version 1.03 ;)
Version 1.03 // 02-10-2014
================================================================================
! Fixed bug: undefined index with request to join group (thanks NW Dreamer)
! Fixed bug: groups listing when "show additional membergroups" is NOT selected


Has appeared the following error in my logs.

Quotehttp://eletronicabr.com/index.php?action=profile;area=deleteaccount;save
8: Undefined index: additional_groups
Arquivo: /home/forumbr/domains/eletronicabr.com/public_html/Sources/Profile-Actions.php
Linha: 434

call_user_func   /index.php:164

deleteAccount2   Sources/Profile.php:558

error_handler   Sources/Profile-Actions.php:434

Sorry for the delay, I've been extremely busy...

I confirmed it's a bug, I'm fixing it immediatelly. Thank you

Does this mod work with the 'Core' theme?  Have a few themes I've made that are based off of it and was just curious.

It should. I haven't tried it but it passes the installation test ;)

Just installed this mod and absolutely love it.  Thank you for it!

Just noticed this popping up in my error log for "Guest" accounts.  Is there an easy fix?


8: Undefined index: additional_groups
Sources/Profile.php
Line: 321


When I had this mod installed on Leet Link's website, it was showing most of the groups for me, when I'm just a member of the following three: Admin, F@H Team Member, and Staff. It was also showing Global Mod and my three paid membergroups, and the only group it wasn't showing was the new Vendor (part of my idea to eventually add a marketplace to the site) group.

Yet when installed on LeetSpace.com (almost the same setup except for the arcade and a different theme), it worked just fine. Any ideas on why it wasn't working fine at Leet Link, and why it's working fine at LeetSpace.com? I'd love to reinstall the mod at Leet Link if I can get it working!

Thanks,
Nathan Pinno

Quote from: KyMcMan on December 14, 2014, 12:44:45 PM
Just installed this mod and absolutely love it.  Thank you for it!

Just noticed this popping up in my error log for "Guest" accounts.  Is there an easy fix?

Code Select Expand


8: Undefined index: additional_groups
Sources/Profile.php
Line: 321


Can you please give me some lines above and below line 321? I can't seem to replicate that...

Quote from: WhiteEagle on December 16, 2014, 12:48:28 AM
When I had this mod installed on Leet Link's website, it was showing most of the groups for me, when I'm just a member of the following three: Admin, F@H Team Member, and Staff. It was also showing Global Mod and my three paid membergroups, and the only group it wasn't showing was the new Vendor (part of my idea to eventually add a marketplace to the site) group.

Yet when installed on LeetSpace.com (almost the same setup except for the arcade and a different theme), it worked just fine. Any ideas on why it wasn't working fine at Leet Link, and why it's working fine at LeetSpace.com? I'd love to reinstall the mod at Leet Link if I can get it working!

Thanks,
Nathan Pinno

Not sure if I understand your problem... Is it showing groups you're not part of? :o Are you sure you don't have those groups assigned to you? You need to confirm on your database, table smf_members. There you find the "id_group" and "additional_groups" columns, check their value for your user.

Yeah, it was odd, but it's fixed now. Thanks!

Was the solution anything that might be of value for others to know?

All I did was check my own profile, then check the additional usergroups I was in, and uncheck those I wasn't in and my own (cause it was showing up twice). Don't know why the installation messed around with my profile, but it did.

Cool. Thanks for that. :)

Mekie Bruno!

Sorry for the dig but ive just installed your mod and i have a question:

How can i arrange the display order of the groups? I want at least that the Admin one to be the 1st one.

Quote from: DragoN_SAMP on March 10, 2015, 04:30:33 PM
Mekie Bruno!

Sorry for the dig but ive just installed your mod and i have a question:

How can i arrange the display order of the groups? I want at least that the Admin one to be the 1st one.

find under: (User profile) > Account Settings

then set their PRIMARY group to the one to display first.

Thanks man.

I had it set into the default smf sellection group but the i reset that to "no group" and add it in the "Aditional groups" below and all went to the right place.

Thanks.  ;)

_
Edit:

Shouldn't this be shown in the profile page too? Its working on the forum but not on the members profile pages. That or perhaps a bug from another mod..?

I think there's maybe another mod for that if not - I believe I have that conflict too and wouldn't mind fixing it / finding the other mod :P! (will updatE)

Quote from: margarett on March 03, 2014, 11:02:35 AM

Hello Margaret,

I just installed your mod to my 2.0.9 SMF Forums, and this is what happens:

(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fi.imgur.com%2FR9D9VeP.png&hash=c66036954cec3170ab8e2fb537ce53f7a058d9f0)

(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fi.imgur.com%2Fzun9y2y.png&hash=95bcd7b14848e10d25455998e1a27c70d122e412)

On both pages membergroups show double, any clue how to fix this? And is there maybe a way to show the actual images instead of the names on the profile section too?

OT: I'm looking for a way to make the username the "color in online list" from the primary membergroup, next to a post and on a profile, any mods for doing this? Fixed this part. :)

Thanks in advance. :)

Hi

I removed your other topic. No need to have the same question in multiple places, this is the place to be ;)

You have duplicate code, that's why you're having twice the content.
Check your Display.template.php. You should have this code twice:
if (!empty($message['member']['additional_groups_full'])) {
foreach($message['member']['additional_groups_full'] as $temp) {
if (!empty($modSettings['show_additional_groups_name']))
echo '
<li class="membergroup">', $temp['group'], '</li>';
echo '
<li class="membergroup">', $temp['stars_img'], '</li>';
}
}


Which means that duplicate code is spread throughout your files... You should check "Manual installation of Mods", but following backwards instructions and see if you find duplicate code. If so, remove the duplicate ;)
http://wiki.simplemachines.org/smf/Manual_installation_of_mods

Quote from: margarett on May 13, 2015, 08:15:44 AM
Hi

I removed your other topic. No need to have the same question in multiple places, this is the place to be ;)

You have duplicate code, that's why you're having twice the content.
Check your Display.template.php. You should have this code twice:

Code Select Expand

if (!empty($message['member']['additional_groups_full'])) {
foreach($message['member']['additional_groups_full'] as $temp) {
if (!empty($modSettings['show_additional_groups_name']))
echo '
<li class="membergroup">', $temp['group'], '</li>';
echo '
<li class="membergroup">', $temp['stars_img'], '</li>';
}
}


Which means that duplicate code is spread throughout your files... You should check "Manual installation of Mods", but following backwards instructions and see if you find duplicate code. If so, remove the duplicate ;)
http://wiki.simplemachines.org/smf/Manual_installation_of_mods

Alright thanks a lot!

Is there any way you know of to add the membergroup icons to a profile page though? Instead of the membergroup names?

Not sure, I'd have to dig the code through the code again :P
I can try to check it later but now I'm terribly busy, sorry :(

Quote from: margarett on May 13, 2015, 09:10:52 AM
Not sure, I'd have to dig the code through the code again :P
I can try to check it later but now I'm terribly busy, sorry :(

Alright man, thanks anyway! Lmk if you ever have the time to do so! :)

Additional member groups aren't displayed on this theme:
http://custom.simplemachines.org/themes/index.php?lemma=2833
I just have primary group displayed.
(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fi.imgur.com%2FREPYSkT.png%3F1&hash=dbc82e97ab98f6f186078a048daa3640f720c941)

Quote from: remcoo on May 13, 2015, 08:36:25 AM

Quote from: margarett on May 13, 2015, 08:15:44 AM
Hi

I removed your other topic. No need to have the same question in multiple places, this is the place to be ;)

You have duplicate code, that's why you're having twice the content.
Check your Display.template.php. You should have this code twice:

Code Select Expand

if (!empty($message['member']['additional_groups_full'])) {
foreach($message['member']['additional_groups_full'] as $temp) {
if (!empty($modSettings['show_additional_groups_name']))
echo '
<li class="membergroup">', $temp['group'], '</li>';
echo '
<li class="membergroup">', $temp['stars_img'], '</li>';
}
}


Which means that duplicate code is spread throughout your files... You should check "Manual installation of Mods", but following backwards instructions and see if you find duplicate code. If so, remove the duplicate ;)
http://wiki.simplemachines.org/smf/Manual_installation_of_mods

Alright thanks a lot!

Is there any way you know of to add the membergroup icons to a profile page though? Instead of the membergroup names?

To add the additional groups in your profile page, use the code:

if (!empty($context['member']['additional_groups_full'])) {
foreach($context['member']['additional_groups_full'] as $temp) {
if (!empty($modSettings['show_additional_groups_name']))
echo '
<li class="membergroup">', $temp['group'], '</li>';
echo '
<li class="membergroup">', $temp['stars_img'], '</li>';
}
}

:) enjoy

Quote from: dominik523 on May 17, 2015, 04:17:02 AM
Additional member groups aren't displayed on this theme:
http://custom.simplemachines.org/themes/index.php?lemma=2833
I just have primary group displayed.
(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fi.imgur.com%2FREPYSkT.png%3F1&hash=dbc82e97ab98f6f186078a048daa3640f720c941)

Confirms this and would also appreciate a fix as I'm preparing to update to the same theme soon.

Many thanks Bruno!

I just installed the Additional groups today and I'm getting an undefined index error in my Load.php file

(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fi.imgur.com%2FFbGSp8P.png&hash=06dd3afad950030ec08eb0b8432b14713562794a)

Line 1341        'additional_groups' => $profile['additional_groups'],

I use UTF-8 as my language, I noticed the editor doesn't touch the UTF8 english file so I replicated the changes in it (so the modification settings per your installer are applied currently to both modifications.english-utf8.php and in the modifications.english.php file your installer automatically does) .. This didn't seem to fix it, anytime anyone loads up a page it displays an error. However, when I look at the profiles in the forum, they appear to be displaying just fine (I do see all the displayed groups for each person) ..

Should I be concerned about this error on line 1341 of Load.php?

Howdy.

I'm now checking Redsy as I will also be using it shortly. It does show the additional membergroups but in a very weird way :P (see attachment)

@rayvon: you probably skipped a modification error in Load.php. That line is replaced with:
'additional_groups_full' => $profile['additional_groups_full'],
'additional_groups_list' => $profile['additional_groups_list'],


Quote from: margarett on May 18, 2015, 01:27:07 PM
@rayvon: you probably skipped a modification error in Load.php. That line is replaced with:

Code Select Expand

'additional_groups_full' => $profile['additional_groups_full'],
'additional_groups_list' => $profile['additional_groups_list'],


I replaced it with that code, and it's giving me a new error now.

8: Undefined index: additional_groupsApply Filter: Only show the errors from this file File: /home/newsi908/public_html/forums/Themes/default/Display.template.php
Line: 587


Line 587 of Display.template.php
if ($context['can_ban'] && empty($message['member']['is_guest']) && $message['member']['group_id'] != 1 && !in_array(1, explode(',', $message['member']['additional_groups'])))

That line doesn't exist in default SMF :o Probably a MOD that allows ban from Display?
Anyway, just replace
!in_array(1, explode(',', $message['member']['additional_groups'])))
with
!in_array(1, $message['member']['additional_groups_list']))

Quote from: margarett on May 18, 2015, 02:25:52 PM
That line doesn't exist in default SMF :o Probably a MOD that allows ban from Display?
Anyway, just replace

Code Select Expand

!in_array(1, explode(',', $message['member']['additional_groups'])))
with

Code Select Expand

!in_array(1, $message['member']['additional_groups_list']))

Ban in Post, yes I have that installed [http://custom.simplemachines.org/mods/index.php?mod=1876] ..

Trying the $message fix now .. Seems to work so far, no errors popping up immediately when I refresh a thread anymore ... Thank you!! :)

About Redsy.

The MOD probably put this in Display.template.php. If so, remove it:
//Show additional groups, if the user has some attributed
if (!empty($message['member']['additional_groups_full'])) {
foreach($message['member']['additional_groups_full'] as $temp) {
if (!empty($modSettings['show_additional_groups_name']))
echo '
<li class="membergroup">', $temp['group'], '</li>';
echo '
<li class="membergroup">', $temp['stars_img'], '</li>';
}
}
Redsy doesn't show group names, just "stars". So we'll do the same. Find:
// Show the stars if they are not in a group.
echo '
<li class="stars">', $message['member']['group_stars'], '</li>';

Add after
//Show additional groups, if the user has some attributed
if (!empty($message['member']['additional_groups_full'])) {
foreach($message['member']['additional_groups_full'] as $temp) {
if (!empty($temp['stars_img']))
echo '
<li class="stars">', $temp['stars_img'], '</li>';
}
}


Do note: this prevents the MOD from being automagically removed from this theme. But because this is such great MOD, you will not want to uninstall it ;D ;D ;D

Thanks for the fix Brun'  ;)

m'sure it will come in handy when I get everything set up!

Quote from: margarett on May 18, 2015, 02:36:28 PM
About Redsy.

The MOD probably put this in Display.template.php. If so, remove it:

Code Select Expand

//Show additional groups, if the user has some attributed
if (!empty($message['member']['additional_groups_full'])) {
foreach($message['member']['additional_groups_full'] as $temp) {
if (!empty($modSettings['show_additional_groups_name']))
echo '
<li class="membergroup">', $temp['group'], '</li>';
echo '
<li class="membergroup">', $temp['stars_img'], '</li>';
}
}
Redsy doesn't show group names, just "stars". So we'll do the same. Find:

Code Select Expand

// Show the stars if they are not in a group.
echo '
<li class="stars">', $message['member']['group_stars'], '</li>';

Add after

Code Select Expand

//Show additional groups, if the user has some attributed
if (!empty($message['member']['additional_groups_full'])) {
foreach($message['member']['additional_groups_full'] as $temp) {
if (!empty($temp['stars_img']))
echo '
<li class="stars">', $temp['stars_img'], '</li>';
}
}


Do note: this prevents the MOD from being automagically removed from this theme. But because this is such great MOD, you will not want to uninstall it ;D ;D ;D

Thank you so much Bruno for the help. I haven't find the first part. That is okay, right?
And for the second, stars, part, here's my code:
// Show the stars if they are not in a group.
echo '
<li class="stars">', $message['member']['group_stars'], '</li>';

//Show additional groups, if the user has some attributed
if (!empty($message['member']['additional_groups_full'])) {
foreach($message['member']['additional_groups_full'] as $temp) {
if (!empty($temp['stars_img']))
echo '
<li class="stars">', $temp['stars_img'], '</li>';
}
}

Did I write it correctly? Sorry I haven't worked with any web scripting so this all is really new to me.
Of course we won't uninstall it, it's awesome :)
Oh, last thing. Does SMF have any limit on number of assigned membergroups to a single member?

Indentation is quite messed but the content seems to be there.
(I'm an indentation freak :P )

QuoteOh, last thing. Does SMF have any limit on number of assigned membergroups to a single member?

Code-wise, not. But the database field where the additional membergroups is stored is a VARCHAR 255, where the membergroup IDs are stored comma-separated. With an average of 3 digits per group (2 digits for the ID and one for the comma), it should store max 85 groups.

Okay I did it. Everything works. Thank you so much Bruno! You're the best :D

Bruno (aka margarett) for President. All say "Aye"

Quote from: Shambles on May 18, 2015, 05:49:24 PM
Bruno (aka margarett) for President. All say "Aye"

Aye! :D

Umm, take notes on this... I'm installing a forum with Reseller that is somewhat similar to Redsy, so this will save some work ;D

Quote from: margarett on May 18, 2015, 05:12:07 PM
(I'm an indentation freak :P )

Python make me an indentation freak too, I edit the mods I install just to keep the right indentation on the edits and files. I edit them properly, from package_info.xml and install.xml(or what they use).

Quote from: Shambles on May 18, 2015, 05:49:24 PM
Bruno (aka margarett) for President. All say "Aye"

LOL ;D

Hey, I have installed the mod and it works great.

However, when i add-in the 2nd membership group, the 2nd membership group display on the profile in the "threads" or beside the "post" of the "threads" then it will shown as

Membership Group A

Join Date:

Membership Group B

So how can i shift the Join Date to below Membership Group B?

Thank you :)

The mod you used to show join date got in the way :P
Check Display.template.php as you need to swap the code between my mod and that other one.

Quote from: margarett on July 14, 2015, 12:49:08 PM
The mod you used to show join date got in the way :P
Check Display.template.php as you need to swap the code between my mod and that other one.

Oh i see ok. I understand what need to be done haha

Thank you  :)

Add 2.0.10 to the list!  It works great and just what I was looking for.  Thanks! :)

Im running 2.0.10 and for some reasons this mod has no effect on my forum. It doesnt show any alternate membergroups - thanks

Did you activate the functionality?
http://custom.simplemachines.org/mods/index.php?action=download;mod=3805;id=226376;image

Yes I did  :(

Then you need to check if all file edits were performed, especially the ones in Display.template.php.

Didn't you get errors while installing it?

Edit: do you use a custom theme? If so, did you choose it when installing the mod?

Your help is very appreciated and I apologize for the slow responses. Yes I did all of the above and no I didn't receive any errors during installation. I will Uninstall and re install this arvo and send a response .

Thank you again and sorry for the slow reply

member group pictures https://gyazo.com/7e84c3772330aac53ccc81ce6b1ef0af
posting profile https://gyazo.com/dfca5a79c6b216e9f3749423fb2a3d5c
normal profile https://gyazo.com/fa08ce46a01b0f626602e8affb7b7353
ok so the 2nd group pictures dont show any help?
yet it does not show the pictures

Quote from: DanMB on November 13, 2015, 06:28:30 PM
member group pictures https://gyazo.com/7e84c3772330aac53ccc81ce6b1ef0af
posting profile https://gyazo.com/dfca5a79c6b216e9f3749423fb2a3d5c
normal profile https://gyazo.com/fa08ce46a01b0f626602e8affb7b7353
ok so the 2nd group pictures dont show any help?
yet it does not show the pictures

two tests failed could that be the reason?

Quote from: DanMB on November 13, 2015, 06:42:02 PM

Quote from: DanMB on November 13, 2015, 06:28:30 PM
member group pictures https://gyazo.com/7e84c3772330aac53ccc81ce6b1ef0af
posting profile https://gyazo.com/dfca5a79c6b216e9f3749423fb2a3d5c
normal profile https://gyazo.com/fa08ce46a01b0f626602e8affb7b7353
ok so the 2nd group pictures dont show any help?
yet it does not show the pictures

two tests failed could that be the reason?

https://gyazo.com/77d7c47c6167d2221fdf8b1d92ec81cc

Well, yes...   If the mod was installed DESPITE the errors and the big red warning across the top of the screen, then it is lucky that your system works at all.   Why would you install a mod that warned your that the installation would not be complete, without knowing what to do bout correcting those missing code bits?

Quote from: Kindred on November 13, 2015, 06:57:53 PM
Well, yes...   If the mod was installed DESPITE the errors and the big red warning across the top of the screen, then it is lucky that your system works at all.   Why would you install a mod that warned your that the installation would not be complete, without knowing what to do bout correcting those missing code bits?

i did uninstall

Quote from: DanMB on November 13, 2015, 07:04:44 PM

Quote from: Kindred on November 13, 2015, 06:57:53 PM
Well, yes...   If the mod was installed DESPITE the errors and the big red warning across the top of the screen, then it is lucky that your system works at all.   Why would you install a mod that warned your that the installation would not be complete, without knowing what to do bout correcting those missing code bits?

i did uninstall

any similar ones or a patch for this?

There is no need for a patch.
The reason that it failed on some files is because some other mod has already changed the code that this mod is looking for.

The only option is to manually make the changes that fail on the tests...  And, since this mod is pretty basic, it is likely that ANY mod you use for this update would have the exact same issue with failures in the exact same spots.

ok got it to work but now is it possible to have the tags bellow the profile picture?

Quote from: DanMB on November 13, 2015, 08:32:06 PM
is it possible to have the tags bellow the profile picture?

Sure it is. The MOD adds code to Display.template.php and the place where the code is added determines where the new info shows up ;)
Right now it shows above the avatar. If you want it below the avatar, just pick this code:
//Show additional groups, if the user has some attributed
if (!empty($message['member']['additional_groups_full'])) {
foreach($message['member']['additional_groups_full'] as $temp) {
if (!empty($modSettings['show_additional_groups_name']))
echo '
<li class="membergroup">', $temp['group'], '</li>';
echo '
<li class="membergroup">', $temp['stars_img'], '</li>';
}
}
Cut it, and paste it above
// Show how many posts they have made.

Quote from: margarett on November 15, 2015, 05:13:45 PM

Quote from: DanMB on November 13, 2015, 08:32:06 PM
is it possible to have the tags bellow the profile picture?

Sure it is. The MOD adds code to Display.template.php and the place where the code is added determines where the new info shows up ;)
Right now it shows above the avatar. If you want it below the avatar, just pick this code:

Code Select Expand

//Show additional groups, if the user has some attributed
if (!empty($message['member']['additional_groups_full'])) {
foreach($message['member']['additional_groups_full'] as $temp) {
if (!empty($modSettings['show_additional_groups_name']))
echo '
<li class="membergroup">', $temp['group'], '</li>';
echo '
<li class="membergroup">', $temp['stars_img'], '</li>';
}
}
Cut it, and paste it above

Code Select Expand

// Show how many posts they have made.

so i understand you cut the 1st code and put it above the 2nd?

Yup ;)

Sent this in a PM but may aswell post here too, we're running into a problem after installing this plugin where the additional membergroups appear unchecked when you go back onto someones profile.
For example, this is before confirming the settings.
(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fpuu.sh%2FmHXlL%2Fddc9e90a8b.png&hash=340750b6d8588056b9cc2798904d8c058c8dd169)

And this is what happens whne they're confirmed.
(https://www.simplemachines.org/community/proxy.php?request=http%3A%2F%2Fpuu.sh%2FmHXha%2F992aedbe7d.png&hash=6148d249e982538a7ffdf98190973f777e93e787)

I've seen your PM, I'll check as soon as I get to the computer ;)

Quote from: margarett on January 24, 2016, 03:14:10 PM
I've seen your PM, I'll check as soon as I get to the computer ;)

Awesome, just thought I'd post just incase someone else had the issue :D

Much appreciated :)

Just a tip iiiXen ... you should always post first and then pm if someone on the support team says it's okay. Most team members ignore support requests if they haven't been posted. :)

I can't reproduce this issue. Are you sure you didn't failed any installation step?
Do you have any errors in your error log which might relate to this?

Maybe try with default theme?

Quote from: margarett on January 24, 2016, 07:20:27 PM
I can't reproduce this issue. Are you sure you didn't failed any installation step?
Do you have any errors in your error log which might relate to this?

Maybe try with default theme?

Tried it with the default theme and still the same thing, but yeah I did get an error while installing while replacing something within load.php.


Find:
mem.time_format, mem.secret_question, mem.is_activated, mem.is_activated, mem.additional_groups AS additional_groups_ori,
mem.smiley_set, mem.show_online, mem.total_time_logged_in, mem.id_post_group, mem.notify_announcements, mem.notify_regularity, mem.notify_send_body,
mem.notify_types, lo.url, mem.ignore_boards, mem.warning, mem.password_salt, mem.pm_prefs';
$select_tables = '
LEFT JOIN {db_prefix}log_online AS lo ON (lo.id_member = mem.id_member)
LEFT JOIN {db_prefix}attachments AS a ON (a.id_member = mem.id_member)';

Replace:

mem.time_format, mem.secret_question, mem.is_activated, mem.additional_groups, mem.smiley_set, mem.show_online,
mem.total_time_logged_in, mem.id_post_group, mem.notify_announcements, mem.notify_regularity, mem.notify_send_body,
mem.notify_types, lo.url, mg.online_color AS member_group_color, IFNULL(mg.group_name, {string:blank_string}) AS member_group,
pg.online_color AS post_group_color, IFNULL(pg.group_name, {string:blank_string}) AS post_group, mem.ignore_boards, mem.warning,
CASE WHEN mem.id_group = 0 OR mg.stars = {string:blank_string} THEN pg.stars ELSE mg.stars END AS stars, mem.password_salt, mem.pm_prefs';
$select_tables = '
LEFT JOIN {db_prefix}log_online AS lo ON (lo.id_member = mem.id_member)
LEFT JOIN {db_prefix}attachments AS a ON (a.id_member = mem.id_member)
LEFT JOIN {db_prefix}membergroups AS pg ON (pg.id_group = mem.id_post_group)
LEFT JOIN {db_prefix}membergroups AS mg ON (mg.id_group = mem.id_group)';


Also nothing jumps out at me with the error logs.

For future reference, *never* install a MOD with errors. Ask first ;)
If you failed that edit, the MOD will not work at all, really.

Please attach your Load.php, I'll try to fix it for you.

Quote from: margarett on January 24, 2016, 08:29:23 PM
For future reference, *never* install a MOD with errors. Ask first ;)
If you failed that edit, the MOD will not work at all, really.

Please attach your Load.php, I'll try to fix it for you.

Ooopsies :P

Here you go, thank you by the way.

Sorry for the huge delay, been terribly busy...
Try the attached file. That change conflicts with a "thanks" MOD you have also installed. I manually fixed the missing query entries.

Quote from: margarett on February 03, 2016, 07:59:49 PM
Sorry for the huge delay, been terribly busy...
Try the attached file. That change conflicts with a "thanks" MOD you have also installed. I manually fixed the missing query entries.

Thank you, we thought it would of been that mod. We've had trouble with it ever since we installed it. Managed to get rid of it completely now.

margarett, this is a great mod and I love it!

We have upgraded our forum from 1.1.x to 2.0.x and your mod replaced the previous banner mod. There was one minor thing that I have changed:
foreach($context['member']['additional_groups_full'] as $temp) {
echo '
<dt>', $txt['additional_membergroups'], ':</dt>
<dd>', $temp['group'], '</dd>';
}
to:
foreach($context['member']['additional_groups_full'] as $temp) {
if (!empty($temp['stars_img']))
echo '
<dt>', $temp['group'], ':</dt>
<dd>', $temp['stars_img'], '</dd>';
}
This little change let display only membergroups in the member's profile that have a star or badge or any kind of image plus the corresponding membergroup name (instead "Additional Membergroup" it shows the the membergroup name).
This worked for me since september without any error messages. :D :) Maybe this could be useful for other users. :)

Thank you for sharing, it's a neat modification ;)

I have a question:
When I approve a requestable membergroup, it used to be set as primary membergroup, but which code I have to change to let it set as additional membergroup?

I understand your question but that doesn't relate to this mod. You should ask that in SMF Coding board ;)

Done (http://www.simplemachines.org/community/index.php?topic=543622.0) ;)

margarett, sorry in advance, feeling a bit nooby  :D, but which lines do I need to swap to make the additional groups (just the additional) to display under the avatar instead?  :-[

Is possible to show additional membergroups only in profile?
And how about showing "Additional ..." only once with all membergroups list?

@margarett Very good modification I've used more than once with some alterations O:) so here I leave the translation to the Latin Spanish I hope you serve!

Modifications.spanish_latin.php
$txt['show_additional_groups'] = '¿Mostrar grupo(s) de miembro(s) adicional(es) en la visualización de temas y en el resumen del perfil?';
$txt['show_additional_groups_name'] = '¿Mostrar el nombre de los grupos de miembro(s) adicional(es)? Si no se selecciona, s&oacute;lo se mostrar&aacute;n las estrellas.<br /> Esto s&oacute;lo se activa si se selecciona la opci&oacute;n anterior';

and Modifications.spanish_latin-utf8.php
$txt['show_additional_groups'] = '¿Mostrar grupo(s) de miembro(s) adicional(es) en la visualización de temas y en el resumen del perfil?';
$txt['show_additional_groups_name'] = '¿Mostrar el nombre de los grupos de miembro(s) adicional(es)? Si no se selecciona, sólo se mostrarán las estrellas.<br /> Esto sólo se activa si se selecciona la opción anterior';


Regards!

Quote from: T-Bone225 on April 10, 2016, 05:39:10 AM
margarett, sorry in advance, feeling a bit nooby  :D, but which lines do I need to swap to make the additional groups (just the additional) to display under the avatar instead?  :-[

You find this in Display.template.php
//Show additional groups, if the user has some attributed
if (!empty($message['member']['additional_groups_full'])) {
foreach($message['member']['additional_groups_full'] as $temp) {
if (!empty($modSettings['show_additional_groups_name']))
echo '
<li class="membergroup">', $temp['group'], '</li>';
echo '
<li class="membergroup">', $temp['stars_img'], '</li>';
}
}
Move it ABOVE this
// Show how many posts they have made.
Do note that this will prevent the MOD from being automatically uninstalled, should you choose to do so...

---

Quote from: JerzyLS on April 10, 2016, 08:43:46 AM
Is possible to show additional membergroups only in profile?

Without major changes, find this in Display.template.php
//Show additional groups, if the user has some attributed
if (!empty($message['member']['additional_groups_full'])) {
Change to:
//Show additional groups, if the user has some attributed
if (false && !empty($message['member']['additional_groups_full'])) {
This will prevent the information to be shown in topic view, yet keep all other functionality intact.
Do note that this will prevent the MOD from being automatically uninstalled, should you choose to do so...

Quote from: JerzyLS on April 10, 2016, 08:43:46 AM
And how about showing "Additional ..." only once with all membergroups list?

It's possible but tricky. I haven't tested this (so it might break, be sure to back up your files :P ) in Profile.template.php find:
//Show additional groups, if the user has some attributed
if (!empty($modSettings['show_additional_groups']) && !empty($context['member']['additional_groups_full'])) {
echo '<dl>';
foreach($context['member']['additional_groups_full'] as $temp) {
echo '
<dt>', $txt['additional_membergroups'], ':</dt>
<dd>', $temp['group'], '</dd>';
}
echo '</dl>';
}
Replace with this
//Show additional groups, if the user has some attributed
$check = false;
if (!empty($modSettings['show_additional_groups']) && !empty($context['member']['additional_groups_full'])) {
echo '<dl>';
foreach($context['member']['additional_groups_full'] as $temp) {
echo '
<dt>', (empty($check) ? $txt['additional_membergroups'] : '&nbsp;'), ':</dt>
<dd>', $temp['group'], '</dd>';
}
$check = true;
echo '</dl>';
}
Again, this prevents the MOD from being automatically uninstalled.

---

@Rock Lee [BC], thank you. I will add your translation to a next version (if/when it comes out ;) )

First solution working fine, but the second not necessarily.

Here is my solution:

Profile.template.php

Find:


//Show additional groups, if the user has some attributed
if (!empty($modSettings['show_additional_groups']) && !empty($context['member']['additional_groups_full'])) {
echo '<dl>';
foreach($context['member']['additional_groups_full'] as $temp) {
echo '
<dt>', $txt['additional_membergroups'], ':</dt>
<dd>', $temp['group'], '</dd>';
}
echo '</dl>';
}


Replace:



        //Show additional groups, if the user has some attributed
if (!empty($modSettings['show_additional_groups']) && !empty($context['member']['additional_groups_full'])) {
echo '<dl><dt>', $txt['additional_membergroups'], ':</dt>';
foreach($context['member']['additional_groups_full'] as $temp) {
echo '
', $temp['group'], ',';
}
echo '</dl>';
}

Installed the mod fine with no errors, but when I enable the options I need to enable via the misc settings, I add someone to a additional membergroup, apply it, then check a random forum post they have posted in and it still shows only one.

Which options did you set? Did you install to your custom theme (if any)? Do your additional membergroups have stars assigned?

Quote from: margarett on July 25, 2016, 09:40:02 PM
Which options did you set? Did you install to your custom theme (if any)? Do your additional membergroups have stars assigned?

I have Show additional membergroups on Topic Display and Profile Summary? ticked and my membergorups have only 1 Star assigned, since it's an image rather than a block.

And I am using a custom theme called Greeny

and did you apply the changes to that theme during installation?

Quote from: Kindred on July 26, 2016, 07:25:08 AM
and did you apply the changes to that theme during installation?

Figured out how to fix it, but now there is another problem. I am sure you can see it right away in this picture.

(https://i.gyazo.com/0561bcbc2038fa12f9cebba3d71c8e1f.png)

Is there a way to move the Development Team picture underneath Administrator?

you need to put the code change in the right place

Quote from: Kindred on July 26, 2016, 02:32:58 PM
you need to put the code change in the right place

I'm not sure I quite understand what you're saying, can you elaborate?

You added the code for the mod... But you put it in the wrong place, therefore, it is displaying in the wrong location.

Your Display.template.php has a list of everything which is added on the "post author" area (or mini-profile as it's also called).

Your should find something like this:
// Show the post group if and only if they have no other group or the option is on, and they are in a post group.
if ((empty($settings['hide_post_group']) || $message['member']['group'] == '') && $message['member']['post_group'] != '')
echo '
<li class="postgroup">', $message['member']['post_group'], '</li>';
echo '
<li class="stars">', $message['member']['group_stars'], '</li>';

Then my MOD tries to add its code below this code. You probably added it above the avatar bit, you need to move it below the primary membergroup/post count group. Look at the code in Display.template.php, it's quite self-explanatory :)

Quote from: margarett on July 26, 2016, 07:46:40 PM
Your Display.template.php has a list of everything which is added on the "post author" area (or mini-profile as it's also called).

Your should find something like this:

Code Select Expand

// Show the post group if and only if they have no other group or the option is on, and they are in a post group.
if ((empty($settings['hide_post_group']) || $message['member']['group'] == '') && $message['member']['post_group'] != '')
echo '
<li class="postgroup">', $message['member']['post_group'], '</li>';
echo '
<li class="stars">', $message['member']['group_stars'], '</li>';

Then my MOD tries to add its code below this code. You probably added it above the avatar bit, you need to move it below the primary membergroup/post count group. Look at the code in Display.template.php, it's quite self-explanatory :)

Just looked in the .php you said, found nothing related to anything you showed above.

Attach your Display.template.php to your next post and we'll have a look for you.

margarett, thank you very much for maintaining this mod. It works well for me. This should be a standard feature. We have "Topic mover" and "Post edit" member groups who are people that can do little tasks for other members by request. It doesn't make sense to keep those member groups secret, and I don't know why SMF does it that way...but, problem solved, thanks to this mod! :)

Mostly it's done that way for performance. Getting primary group is cheap, getting multiple groups not so much.

Arantor, maybe it would be straightforward to make it optional for additional member groups to be visible? If they're invisible by default, that satisfies the need for performance. On the page where they can be made visible, there could be an explanation that making them visible will reduce performance. Then for groups like the ones I mentioned, I could make them visible, and leave the others with the default settings. For now, as long as margarett keeps maintaining this mod, my use case is satisfied.

No, it wouldn't because of the same performance issue I mentioned. That's the entire reason it's that way. It's fundamental to the way SMF's database is designed.

A user has a primary group, a post count group and "all other groups". Fetching the primary group is cheap (it always manifests as a 1-1 relationship) but trying to handle multiples... Even if SMF didn't use a single text field to store them all (it uses a string e.g, 10,12,13,15 which MySQL won't perform a join from) even creating multiples means it has to join all the members to all the groups and then sit and perform deduplication before it can process anything else.

Multiple groups however you do it has a performance impact. More groups, worse it gets.

OK, maybe I'm looking at it the wrong way. If I have a regular user that I want to have regular user permissions, but also a few extra abilities, then maybe I should make the new user groups primary for those users, instead of additional? I'm not sure what the best practice is for this kind of thing. For now, our forum is small, but ignoring performance issues will just cause problems later.

The primary / other group distinction is solely for the purposes of making threads quick to display in base SMF.

Permissions are not performance related whether you have one group or lots (at least not in any meaningful way)

It just comes back to whether you display one group or multiple and if you really want to show off peoples' roles at a more granular level than "regular member" and "moderator" you could, but my experience of forums suggests that people don't really care and that having a few (primary) moderator groups is clearer and more meaningful - moderator (moves topics), senior moderator (moves topics, closes topics), administrator (does everything) or similar.

As a general rule, most forum users simply do not care which people do specific jobs unless 1) they need something done (in which case there's the report to moderator function so the appropriate person can deal with it) or 2) they want the badge and power themselves. The latter has a habit of being toxic in forums anyway so keeping it a little simpler actually tends to help, not hurt.

Sounds like good advice, thank you Arantor.

I'm on 2.0.13 and the post count group stars aren't appearing. I feel like I'm missing something simple. I read through the entire thread here and saw a section about it but it just kind of confused me. Can someone explain to me how to fix it?

http://puu.sh/tJg6i/2efd33088c.jpg

(Peasant is the name of the post count group)

Hi,

Your mode is fabulous.
Is there any way to change code that the additional groups name has a color of that group?

http://prnt.sc/etxn7l

Is there a way, or how to, make the Stars (Icons) show up in rows of X?
I have about 25 groups (categories) on my forum.  If someone is in most of them it is a LONG list down.   
It would be nice to make them go in horizontal rows of 3 or 4, then the next row, Ect.   

Not sure if it can be done.   

Thanks in advance for your time   THIS MOD is what I needed when Stars and Badges no longer worked with me theme.

i'm getting an
8: Undefined index: additional_groups
File: /Sources/Load.php
Line: 1118

line 1118
$user_profile[$new_loaded_ids[0]]['list_additional_groups'] = cache_quick_get('membergroup_list_' . $new_loaded_ids[0], 'Subs-Membergroups.php', 'cache_getMembergroupListForProfile', array($user_profile[$new_loaded_ids[0]]['additional_groups']));

Need the whole error

Hello ! Is there a port to this fantastic mod for SMF 2.1.x ?
Thank you in advance.

since the author has not been online in years -- no

Too bad... Is there a way ton get quitely the same effect ?

Does not look like anyone has updated any of the other mods either.

Suggest you post in the mod requests board

I'll do that! Thank you!