Karma System: Database Error

[Tristan Perry]

Hello,
I have been hacking away at the Karma system, I'm adding an extra field to the log_karma table which stores what topic the karma was given in. I am then using this to display the following log file:
http://tauonline.org/karmalog.php

This is working great, if Karma is changed through a topic, although if Karma is changed via PM, the following error message is shown:

Database Error
You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near ')' at line 3
File: /home/tauonli/public_html/forums/Sources/Karma.php
Line: 97

I assumed this was the variable '$topic' was blank and so I added the following piece of code to the Karma.php file:

Code Select Expand

if($topic == '') $topic == blank;

Now, I get the same database error, and the following PHP error at the top of my PM page (If I attempt to modify Karma):

Notice: Use of undefined constant blank - assumed 'blank' in X on line 93

What I have at the moment (Which is triggering these errors) is:

Code Select Expand

// Put it in the log.
if($topic == '') $topic == blank;
db_query("
INSERT INTO {$db_prefix}log_karma
(action, ID_TARGET, ID_EXECUTOR, logTime, topic)
VALUES ($dir, $_REQUEST[uid], $ID_MEMBER, " . time() . ','.$topic.')', __FILE__, __LINE__);


Line 93 is the line (if($topic == '') ..

Any help would be greatly apprecaited,
Tau Online

 

[[Unknown]]

Instead of blank, try:

if (empty($topic))
   $topic = 0;

-[Unknown]

[Tristan Perry]

Instead of blank, try:

if (empty($topic))
   $topic = 0;

-[Unknown]

Thanks, that worked great  You seem good at PHP, you should try making a message board system or something...or wait.  Anyway thanks a lot  Also does the function empty() check if the variable has been set, but has nothing it it?