bug with smf 1.1.3 newsletter sending to wrong people; fix inside

[dcmouser]

Line 326 in ManageNews.php is:

Code Select Expand

$condition = '
when i think it should be something like:

Code Select Expand

$condition = $condition . '

The change is needed in order for the query to obey the option to only include members who have notifications enabled, see line 295-297 above:

Code Select Expand

// Opt-out?
$condition = isset($_POST['email_force']) ? '' : '
AND mem.notifyAnnouncements = 1';


Without the change, this setting is ignored.

[pongsak]

Line 326 in ManageNews.php is:
Code:

   $condition = '

I didn't see that line in ManageNews.php. 1.1.3

[dcmouser]

Its in ManageNews.php from smf_1-1-3_upgrade.tgz downloaded today.

[SleePy]

I added it to our bug tracker.

Thanks for the information.

[cferd]

I can't get newsletters to go to people who've turned off notifications with the existing code. Under what conditions exactly will newsletters go to wrong people?

Thanks.