Is Default theme for 1.1.4 invalid XHTML? (check register.template.php)

Started by TosTos, January 11, 2008, 04:51:26 AM

Previous topic - Next topic

TosTos

Hi,
Please don't laugh at me. I was writing my last theme. It was passing from validator except one page.  I checked my download, my fresh SMF, and it was giving the same problem. Then, I corrected the problem by changing a code in the default theme. Validator was saying Line 276, Column 32: value of attribute "align" cannot be "top"; must be one of "left", "center", "right", "justify", "char".

<td width="40%" align="top">



The value of the attribute is defined to be one of a list of possible values but in the document it contained something that is not allowed for that type of attribute. For instance, the "selected" attribute must be either minimized as "selected" or spelled out in full as "selected="selected""; a value like "selected="true"" is not allowed.
Then I checked default theme's register.template.php, and just wrote "center" instead of "top". Now, it is OK. http://validator.w3.org/check?uri=http%3A%2F%2Fwww.etkiweb.com%2Fdizayn%2Findex.php%3Faction%3Dregister&charset=%28detect+automatically%29&doctype=Inline&group=0 However, I am suspicious if default theme has a small typo.
I am sorry if my fresh download is broken, and if it was giving the problem.

TosTos

Another one for 1.1.4 default theme.
I corrected this code, and it worked. This time, I corrected help.template.php
<td class="smalltext" valign="middle" width="22%" class="windowbg">
I got this message from validator about the error.
Validation Output:  2 Errors

   1. Error Line 268, Column 62: duplicate specification of attribute "class".

      ...t" valign="middle" width="22%" class="windowbg">Date, time, subject and autho

      ✉

      You have specified an attribute more than once. Example: Using the "height" attribute twice on the same "img" tag.
   2. Error Line 268, Column 72: XML Parsing Error: Attribute class redefined.

      ..."middle" width="22%" class="windowbg">Date, time, subject and author of la

SleePy

Jeremy D ~ Site Team / SMF Developer ~ GitHub Profile ~ Join us on IRC @ Libera.chat/#smf ~ Support the SMF Support team!

TosTos

Can you check http://www.Your Adres.com/forum/index.php?action=register
Register template has a code <td width="40%" align="top"> and XHTML doesn't accept align="top" . Also the other file has <td class="smalltext" valign="middle" width="22%" class="windowbg"> which shouldn't have two class
My fresh one doesn't valid. It is weird.

SleePy

Ok, my inline validator wasn't catching it. I had to actually have it send it out.
For team reference the bug is 1258
Jeremy D ~ Site Team / SMF Developer ~ GitHub Profile ~ Join us on IRC @ Libera.chat/#smf ~ Support the SMF Support team!

Advertisement: