Strange errors in error log after upgrade

[Insight]

Hi All,

I just upgraded from 1.0.10 to 1.1.7 (at last) and mostly all has been good!

Now, I seem to be getting the following in my error log:

8: Undefined index: upshrink
File: /xxx/xxx/xxx/forum/Themes/default/Errors.template.php (main_above sub template - eval?)
Line: 122

8: Undefined index: upshrink
File: /xxx/xxx/xxx/forum/Themes/default/Login.template.php (main_above sub template - eval?)
Line: 122

8: Undefined index: upshrink
File: /xxx/xxx/xxx/forum/Themes/ml407themev2/BoardIndex.template.php (main_above sub template - eval?)
Line: 122

8: Undefined index: upshrink
File: /xxx/xxx/xxx/forum/Themes/ml407themev2/Display.template.php (main_above sub template - eval?)
Line: 122

As an example, here is the contents of the board index template from lines 107 - 130:

Code Select Expand

// Assuming the category hasn't been collapsed...
if (!$category['is_collapsed'])
{
/* Each board in each category's boards has:
new (is it new?), id, name, description, moderators (see below), link_moderators (just a list.),
children (see below.), link_children (easier to use.), children_new (are they new?),
topics (# of), posts (# of), link, href, and last_post. (see below.) */
foreach ($category['boards'] as $board)
{
echo '
<tr class="windowbg2">
<td class="windowbg" width="6%" align="center" valign="top"><a href="', $scripturl, '?action=unread;board=', $board['id'], '.0">';

// If the board is new, show a strong indicator.
if ($board['new'])
echo '<img src="', $settings['images_url'], '/on.gif" alt="', $txt[333], '" title="', $txt[333], '" border="0" />';
// This board doesn't have new posts, but its children do.
elseif ($board['children_new'])
echo '<img src="', $settings['images_url'], '/on2.gif" alt="', $txt[333], '" title="', $txt[333], '" border="0" />';
// No new posts at all!  The agony!!
else
echo '<img src="', $settings['images_url'], '/off.gif" alt="', $txt[334], '" title="', $txt[334], '" border="0" />';

echo '</a></td>


I can see it talking about collapsing categories etc but no mention of upshrink and I can't find it in the file either.

Anyone got any ideas? Getting lots of these errors!

[Insight]

Incidentally, it is only Guests which are causing these errors to be logged...

[JimM]

In order to actually see where this error is coming from, you need to disable template eval. Please open your phpMyAdmin, and type this following command:

Code Select Expand

INSERT INTO smf_settings VALUES ('disableTemplateEval', 1);

Clear your error log, wait for the errors to appear again and then copy them here.

Reactivate eval once you finish by doing:

Code Select Expand

DELETE FROM smf_settings WHERE variable = 'disableTemplateEval';

[Insight]

Thanks for the reply.

In the mean time I re-made the template from scratch (based on babylon with only a few layout changes, most changes were in css). This seems to have fixed it.

Next to meddle with the upshrink setting to set it to closed as default rather than open (why isn't this an admin setting? )

Then onto look at some additional anti spam (I have been running in member approval for ages anyway, another day or so won't hurt )

[JimM]

Great, if this issue is solved, please mark the topic solved by changing the message icon in your first post to the solved 'tick' mark.

[Insight]

Done Sorry, wasn't sure who was responsible for that

[JimM]

Oh, no problem, I usually send a PM to one of the Support Specialist after a couple of days.  It saves them some time not having to read all the topics.