ssi function for popup PM

aw06 · October 08, 2009, 05:38:08 PM

I need the ssi function to display the pop to a user when they have new PM .. basically exactly like how it is within SMF itself

Arantor · October 08, 2009, 05:49:58 PM

It's not really practical to make this an SSI function since it doesn't work on regular HTML.

Normal SSI functions output body HTML, this would have to be <head> HTML.

That said, put the include of SSI as your first line, then inside the <head> tag (where <title> is):

Code Select

<?php
echo '<script type="text/javascript">var msg = ' . ($context['user']['unread_messages'] > 0 ? 'true' : 'false') . ';
if(msg) {
  alert("You have new messages!");
}
</script>';
?>

Not as clean as the proper SMF one but it should work (NB not tested)

aw06 · October 08, 2009, 06:06:16 PM

ok, im using the pm informer mod

i just tried your code .. it pops up saying you have a message .. on click it does not go to the message ... and the popup comes everytime the page is refreshed.. if you you have no messages..

I replaced your code with the code from the pm informer mod ... it now goes to the message when clicked and it pop up looks just like it is in smf

Code Select

<?php echo '<script language="JavaScript" type="text/javascript"><!-- // --><![CDATA[
      if (confirm("'.$txt[318].': '.$context['pm_informer']['sender'].' \\n'.$txt[319].': '.$context['pm_informer']['subject'].' \\n  \\n' . $txt['show_personal_messages'] . '" ))
         window.location = "' . $scripturl . '?action=pm" ;
   // ]]></script>';
?>

basically they same thing happens .. it is popped up on every refresh .. and also it does not catch the subject and pm title...

you can click here to see http://shopinja.com/forum/home.php .. it also displays an error when their is infact a pm

Notice: Undefined index: pm_informer and the error is on forum/Sources/Subs.php on line 3190 ...

aw06 · October 08, 2009, 06:10:27 PM

all i need to do really if get rid of the error on the page .. i dont really need to pm popup ... i was hoping that using it would fix the error

Arantor · October 08, 2009, 06:12:24 PM

I know nothing of the PM Informer mod. You could ask about changes to that in the mod's own thread.

All my code does is advise there are new PMs, nothing more.

EDIT: The reason it doesn't work is because pm_informer doesn't exist outside of SMF, meaning it REALLY won't work in SSI setups.

What, *exactly* do you want from this?

aw06 · October 08, 2009, 06:25:11 PM

oK .. using your code .. what happens is that even after you click ok .. when you refresh the pop up returnes .. can you put the lines in your code so that the user can click and it will open the pm ?

Arantor · October 08, 2009, 06:32:14 PM

Try:

Code Select

<?php
echo '<script type="text/javascript">var msg = ' . ($context['user']['unread_messages'] > 0 ? 'true' : 'false') . ';
if(msg) {
  if(confirm("You have ' . $context['user']['unread_messages'] . ' new message(s)!")) {
    window.location = "' . $scripturl . '?action=pm";
  }
}
</script>';
?>

aw06 · October 08, 2009, 06:42:32 PM

ok that .. works .. but still getting this error message displayed on the page

Code Select

Notice: Undefined index: pm_informer in /home/xxxxxx/xxxxxxx/xxxx/Sources/Subs.php on line 3190

Seems i may have to uninstall this mod

Arantor · October 08, 2009, 06:44:01 PM

Yes, that's nothing to do with my code.

aw06 · October 08, 2009, 06:45:42 PM

can i not bypass the pm informer ?? or call it into the page somehow ? .. or add some code to hide errors from mod that dont output ssi ?

Arantor · October 08, 2009, 06:51:46 PM

No, since it's in Subs.php and is obviously broken in some way.

aw06 · October 08, 2009, 06:58:05 PM

ok , i know i should get support from the mod topic ... but can you quickly look at the codes .. perhaps you can quickly advise on a fix for it to output ssi..

./Sources/Load.php

Code Select

//Pm Warning...
function loadPmWarning()
{
	global $scripturl, $db_prefix, $ID_MEMBER, $context, $user_info, $func;

	//Gimme the newest pm, if we have.
	if(!empty($user_info['unread_messages'])) {
		$request = db_query("
			SELECT
				pm.ID_PM, pm.ID_MEMBER_FROM, pm.fromName, pm.msgtime, pm.subject, pm.body
			FROM {$db_prefix}personal_messages AS pm
				LEFT JOIN {$db_prefix}pm_recipients AS pmr ON (pmr.ID_PM = pm.ID_PM)
			WHERE pmr.is_read = 0 AND pmr.ID_MEMBER = $ID_MEMBER
			ORDER BY pm.msgtime DESC
			LIMIT 1", __FILE__, __LINE__);
		$context['pm_informer'] = array();
		while ($row = mysql_fetch_assoc($request))
		{
			//You can't be so looongggg. He he. :)
			if ($func['strlen']($row['body']) > 250)
				$row['body'] = $func['substr']($row['body'], 0, 250) . '<a href="' . $scripturl . '?action=pm#msg' . $row['ID_PM'] . '">...</a>';

			// Build the array.
			$context['pm_informer'] = array(
				'from' => $row['ID_MEMBER_FROM'],
				'sender' => $row['fromName'],
				'msgtime' => timeformat($row['msgtime'], false),
				'subject' => $row['subject'],
				'body' => parse_bbc($row['body']),
			);
		}
		mysql_free_result($request);
	}
}

./Sources/Subs.php

Code Select

if (confirm("'.$txt[318].': '.$context['pm_informer']['sender'].' \\n'.$txt[319].': '.$context['pm_informer']['subject'].' \\n  \\n' . $txt['show_personal_messages'] . '" ))

./index.php

Code Select

// Is there new pms? PM Informer...
	loadPmWarning();

Or perhaps you can tell me how to hardcode what the mod does into smf

Arantor · October 08, 2009, 07:22:12 PM

Add loadPmWarning() to SSI.php after Subs.php has been loaded; early on in SSI.php there is a set of require instructions, to Load.php and others. Add it after that.

aw06 · October 08, 2009, 07:27:13 PM

Sorry, but i dont quite follow .... what exatly should i do ?

Code Select

// Load the important includes.
require_once($sourcedir . '/QueryString.php');
require_once($sourcedir . '/Subs.php');
require_once($sourcedir . '/Errors.php');
require_once($sourcedir . '/Load.php');
require_once($sourcedir . '/Security.php');

Arantor · October 08, 2009, 07:43:34 PM

After those lines, add:

Code Select

loadPmWarning();

aw06 · October 08, 2009, 07:51:34 PM

still getting the error message

Arantor · October 08, 2009, 07:52:55 PM

No other errors too?

aw06 · October 08, 2009, 08:00:14 PM

error log is clean .. it does not show up in the error logs ... it displays at the top of the page for all to see ...

Notice: Undefined index: pm_informer in /home/xxxxxx/xxxxxxx/xxxx/Sources/Subs.php on line 3190

It goes away on refresh

Arantor · October 08, 2009, 08:02:33 PM

So, what's line 3190 of your Subs.php, and the 10 or so lines immediately above it?

aw06 · October 08, 2009, 08:07:43 PM

This is on line 3190

Code Select

if (confirm("'.$txt[318].': '.$context['pm_informer']['sender'].' \\n'.$txt[319].': '.$context['pm_informer']['subject'].' \\n  \\n' . $txt['show_personal_messages'] . '" ))

More Code above

Code Select

$context['in_maintenance'] = !empty($maintenance);
	$context['current_time'] = timeformat(time(), false);
	$context['current_action'] = isset($_GET['action']) ? $_GET['action'] : '';
	$context['show_quick_login'] = !empty($modSettings['enableVBStyleLogin']) && $user_info['is_guest'];

	if (empty($settings['theme_version']))
		$context['show_vBlogin'] = $context['show_quick_login'];

	// This is here because old index templates might still use it.
	$context['show_news'] = !empty($settings['enable_news']);

	// This is done to make it easier to add to all themes...
	if ($context['user']['popup_messages'] && !empty($options['popup_messages']) && (!isset($_REQUEST['action']) || $_REQUEST['action'] != 'pm'))
	{
		$context['html_headers'] .= '
	<script language="JavaScript" type="text/javascript"><!-- // --><![CDATA[
		if (confirm("'.$txt[318].': '.$context['pm_informer']['sender'].' \\n'.$txt[319].': '.$context['pm_informer']['subject'].' \\n  \\n' . $txt['show_personal_messages'] . '" ))
			window.location = "' . $scripturl . '?action=pm" ;
	// ]]></script>';
	}

News:

ssi function for popup PM