News:

Bored?  Looking to kill some time?  Want to chat with other SMF users?  Join us in IRC chat or Discord

Main Menu

SimpleSEF 2.0 (SMF 1.1.x and SMF 2.0)

Started by SlammedDime, December 05, 2009, 10:08:40 PM

Previous topic - Next topic

hartiberlin

Hi,
when will you have the new version with all the latest bug fixes out ?

Will I loose all my Google indexed pages, when I switch later
to this MOD and earlier now only all
URLs are in Google like index.php?topic=xxx   
?

Please SlammedDime let us know.
I need to setup a new domain and want to use
SimpleSEF for this.
Many thanks.

SlammedDime

Quote from: Am' on December 15, 2009, 11:53:06 AM
this mod stock the new url in new table in database ?
no, no urls are cached in the database.  this is not, however, a performance hit for this mod.
SlammedDime
Former Lead Customizer
BitBucket Projects
GeekStorage.com Hosting
                      My Mods
SimpleSEF
Ajax Quick Reply
Sitemap
more...
                     

SlammedDime

Quote from: hartiberlin on December 15, 2009, 02:38:21 PM
Hi,
when will you have the new version with all the latest bug fixes out ?

Will I loose all my Google indexed pages, when I switch later
to this MOD and earlier now only all
URLs are in Google like index.php?topic=xxx   
?

Please SlammedDime let us know.
I need to setup a new domain and want to use
SimpleSEF for this.
Many thanks.
i'm working on it.  I'm getting aversion for smf 1.1.x ready to release at the same time.
SlammedDime
Former Lead Customizer
BitBucket Projects
GeekStorage.com Hosting
                      My Mods
SimpleSEF
Ajax Quick Reply
Sitemap
more...
                     

hartiberlin

Hmm,
better just concentrate on RC2,
who is still using the old 1.1 anyway ??

Well, too bad, Feline just posted, that PortaMX is not supporting
or working fully with SimpleSEF.

http://portamx.com/index.php/topic,1373.0.html

Please can you try to optimize it , so it will work fully
with PortaMX ?

The problem is probably still only mostly in the single pages
URLs from PortaMX and a few other redirects, so it should it be easy to resolve
I guess.
Many thanks in advance.

Regards, Stefan.

Arantor

Quote from: hartiberlin on December 15, 2009, 04:53:59 PM
who is still using the old 1.1 anyway ??

Given that it's been around for 3 years in a stable version and we are not pushing 2.0 as ready for production sites, I'd say quite a few people, especially given the response to the recent 1.1.11 upgrade.

Mayhem30

Quote
Hmm,
better just concentrate on RC2,
who is still using the old 1.1 anyway ??

A lot more people use 1.1.x than 2.0 right now. Even when 2.0 final is released, people will opt not to switch over right away till any unforeseen bugs has been fixed.

SlammedDime

1.1.x is still very very very popular compared to 2.0.

As for PortaMx, I really don't care for the portal system all that much, I'm much more partial to SimplePortal and TinyPortal, but if Feline wants to post specific information in this topic as to what doesn't work so I can try to replicate and adjust my mod as needed.
SlammedDime
Former Lead Customizer
BitBucket Projects
GeekStorage.com Hosting
                      My Mods
SimpleSEF
Ajax Quick Reply
Sitemap
more...
                     

mirahalo

I know you're working on a new version with bug fixes,  does that version include any fix  for my issues or you couldn't find any fix or any issues for that matter :P

Yağız...

I think SimpleSEF brokes auto suggest. I can't use it on my 2 sites.

feline

Follow errors I found
1. url's like ?theme=1 or ?language=langname don't work and run in error.
2. dot in url's like ?cat.article don't work. the dot is replaced by underline.
3. url's without index.php (like url/?anytext) not handled.

Fel

rd

Whats wrong with simple urls? I love portalMX! I tried this mod once and decided to go back to simpleURL, I forgot why I went back, was a month ago (I think).

SlammedDime

Quote from: mohd7590 on December 16, 2009, 04:58:45 PM
Whats wrong with simple urls? I love portalMX! I tried this mod once and decided to go back to simpleURL, I forgot why I went back, was a month ago (I think).
You mean Pretty Urls?  This mod hasn't even been out for a month yet.  I never said anything was wrong with it.  This simply addresses the issue from a different angle.
SlammedDime
Former Lead Customizer
BitBucket Projects
GeekStorage.com Hosting
                      My Mods
SimpleSEF
Ajax Quick Reply
Sitemap
more...
                     

feline

Any advise how I can fix the errors I describe?

And Pretty URL RC1 works perfect .. also with PortaMx

Fel

SlammedDime

Quote from: Yağız... on December 16, 2009, 11:39:13 AM
I think SimpleSEF brokes auto suggest. I can't use it on my 2 sites.
Seems to work okay for me... although I am putting in a change for how this mod adjusts the smf_scripturl javascript variable, so that might solve your issue.

Quote from: feline on December 16, 2009, 03:40:37 PM
Follow errors I found
1. url's like ?theme=1 or ?language=langname don't work and run in error.
2. dot in url's like ?cat.article don't work. the dot is replaced by underline.
3. url's without index.php (like url/?anytext) not handled.

Fel

1) Easy fix, thanks
2) Can you give me a full example of how the url looks before the mod, and how it looks after? (full url with http and all)
3)Will be fixed due to my fixing (1).

Quote from: 130860 on December 15, 2009, 06:17:40 PM
I know you're working on a new version with bug fixes,  does that version include any fix  for my issues or you couldn't find any fix or any issues for that matter :P
I'm looking at your issue as I type this... I just got my baby down for a nap so I have a free hour (I hope) to play with it.
SlammedDime
Former Lead Customizer
BitBucket Projects
GeekStorage.com Hosting
                      My Mods
SimpleSEF
Ajax Quick Reply
Sitemap
more...
                     

mirahalo

oh, thank you so much  :)

feline

#135
to 2)
Original url: myurl/index.php?catname.articlename or myurl/?catname.articlename
Changed url: myurl/catname_articlename/catname_articlename/
Must have: myurl/catname.articlename/

Because the theme=nn don't work I can't test the redirect in this.
I use as example: url?index.php?theme=1;redir=?admin|area=xyz|sa=xyz
The redir url part is encoded with Javascript:
var curpage = new String(window.location);
encodeURIComponent(curpage.replace(/\;/g, "|"))

Fel

spiros

Does it support UTF-8 Greek characters? Is there a test forum somewhere?

SlammedDime

spiros, it should.  I don't have a test forum for this up yet... I may turn my site into utf8 and install this mod there, but haven't had time yet.

Fel, thanks for the info, I'll look into it.  As a suggestion though, you may want to base64_encode your redir=, and then decode it on the PHP side.
SlammedDime
Former Lead Customizer
BitBucket Projects
GeekStorage.com Hosting
                      My Mods
SimpleSEF
Ajax Quick Reply
Sitemap
more...
                     

feline

#138
Ok .. I have get it to work, with small changes.
1.. fixed shorturl like myurl/?querystring
2.. fixed dot in querystrings like myurl/index.php?dot.query

Changes on SimpleSEF.php
find (line 102)

$current_value = array_pop($url_array);

replace with

// fix for shorturl like myurl/?request
$current_value = strtr(array_pop($url_array), array('?' => ''));


find (line 198)

@ini_set('memory_limit', '64M');


Add after:

// fix for shorturl like myurl/?request
$buffer = str_replace('/?', '/index.php?', $buffer);


find (line 345)

parse_str(!empty($url_parts['query']) ? $url_parts['query'] : '', $params);


Replace with:

// fix for dot in querystrings like myurl/dot.request
parse_str(!empty($url_parts['query']) ? strtr($url_parts['query'], '.', '|') : '', $params);
$params = str_replace('|', '.', $params);


Find (line 384)

foreach ($params as $key => $value)
{
if ($value == '')
$sefstring3 .= $key . '/' . $key . '/';


Repace with:

// fix for dot in querystrings like myurl/dot.request and shorturl like /?
$key = strtr($key, array('?' => '', '|' => '.'));

if ($value == '')
$sefstring3 .= $key .'/';


Done.
The PortaMx side run SimpleSEF and above changes.

Fel

feline

Hmmm .. I see that the querystring theme=# is automatic added to the action array. But in this case that don't work and run in a error.
I fixed that with this

if (!empty($params['action']))
{
if(!in_array($params['action'], $simpleSEF['actions']) && $params['action'] != 'theme')
$simpleSEF['actions'][] = $params['action'];


Fel

Advertisement: