$grandchildbutton 'is_active' fix

Dream Portal Team · May 04, 2010, 10:59:57 AM

Link to Mod

If you're like me and have edited your top menu or have created a site menu which contains second or third layer sub-buttons for the dropdowns, you may have noticed a large number of undefined is_active in your Error Log.

This is because the template_menu() function checks for is_active for grandchildren, when it is impossible for a grandchild to be active (as it is not seen from the default menu itself).

The following modification is a fix for this problem. This will repair the issue only for the default theme and any other curve-based themes (make sure you select the option to install to custom themes!)

Dream Portal Team

Arantor · May 04, 2010, 11:26:11 AM

o.O When did the cust team start approving mods that were bug fixes?

I know I rejected at least one like that before...

Dream Portal Team · May 04, 2010, 12:35:14 PM

Dunno, they approved it apparently.

hadesflames · May 04, 2010, 11:05:03 PM

There are a few other bug fix mods by labradoodle as well. It doesn't really hurt to have em. They provide temporary fixes until official fixes are implemented.

nend · May 05, 2010, 12:12:14 AM

Theme authors must be responsible also for fixing their own themes that may have contracted the bug by using the default theme as a source. In no way should this mod be considered as a permanent fix and may only confuse users that may add new themes later on thinking their menu system has been fixed.

This comes to another conclusion after the next release of SMF there are going to be floating around themes on this site and others that have this bug in the theme code. I just want to know what the SMF team is going to do about it. Let the buggy themes be hosted here or give theme developers a option to update or be deleted.

But if their going to approve bug fixes all I ask is the mod/fix authors lock that mod for the version of SMF that bug retains too. Dream Portal Team you have done this with your mod, good work.

smp420 · May 05, 2010, 12:31:09 AM

Well as not many people use grandchild buttons, its not a major problem, and its easy to fix I doubt they will do anything about the themes already on the mod site. They will have to be updated anyways for the next release.

Nick Whetstone · May 05, 2010, 12:59:11 AM

Quote from: nend on May 05, 2010, 12:12:14 AM
I just want to know what the SMF team is going to do about it.

It is fixed in SVN.

nend · May 05, 2010, 01:30:59 AM

Quote from: Ha² on May 05, 2010, 12:59:11 AM
Quote from: nend on May 05, 2010, 12:12:14 AM
I just want to know what the SMF team is going to do about it.

It is fixed in SVN.

I already know that, was talking about the themes already floating around not made by SMF.

Arantor · May 05, 2010, 06:01:35 AM

There's nothing SMF can actually "do" about those. Any themes that have bugs need to be fixed by the theme authors.

ɔɔɔɔɔɔuɥoɾ · September 06, 2010, 11:55:06 PM

Is their a core version?

live627 · September 07, 2010, 12:37:04 AM

No, and the reason is Core by default does not work with grandchild buttons, heck, not even child buttons.

ɔɔɔɔɔɔuɥoɾ · September 07, 2010, 12:07:49 PM

Quote from: live627 on September 07, 2010, 12:37:04 AM
No, and the reason is Core by default does not work with grandchild buttons, heck, not even child buttons.

Their can be within the admin area however, also I have child buttons on my custom coded core based theme, I will have to do some testing to see if the bug exists here too

News:

$grandchildbutton 'is_active' fix