[4350] Only shows one caching engine even if multiple are available

[shinji257]

I have multiple caching systems installed on my system.  I setup both memcached and APC on the server.  When APC is disabled it will gladly show that memcached is available.  When I enable APC then it only reveals that one but memcached is never reported as being available on the server.  I do believe I have narrowed down where the bug is probably at if it is even a bug at all.

Code Select Expand


        // Detect an optimizer?
        if (function_exists('eaccelerator_put'))
                $detected = 'eAccelerator';
        elseif (function_exists('mmcache_put'))
                $detected = 'MMCache';
        elseif (function_exists('apc_store'))
                $detected = 'APC';
        elseif (function_exists('output_cache_put'))
                $detected = 'Zend';
        elseif (function_exists('memcache_set'))
                $detected = 'Memcached';
        elseif (function_exists('xcache_set'))
                $detected = 'XCache';
        else
                $detected = 'no_caching';

        $context['settings_message'] = sprintf($context['settings_message'], $txt['detected_' . $detected]);[code]
[/code]

Now then this may be purely cosmetic given the above code.  So my question comes around.  If I fill in the memcached setting field will it take advantage of both APC and memcached anyways?

Forgot this may be useful -- http://esminefield.net/phpinfo.php [nofollow]

[Kill Em All]

Sorry for getting to this late. Unfortunately, I'm unable to test this, however, I will move this to the Bug Reports board.

[live627]

I will test this in a few hours once I am in Linux

[Kill Em All]

Thanks live627, my host unfortunately doesn't have any.

[live627]

Confirmed. Says APC when I also have XCache.

[live627]

OK. Here is my proposed ix (clunky as it may be):

./Sources/ManageServer.php

Code (Find) Select Expand

if (function_exists('eaccelerator_put'))
$detected = 'eAccelerator';
elseif (function_exists('mmcache_put'))
$detected = 'MMCache';
elseif (function_exists('apc_store'))
$detected = 'APC';
elseif (function_exists('output_cache_put'))
$detected = 'Zend';
elseif (function_exists('memcache_set'))
$detected = 'Memcached';
elseif (function_exists('xcache_set'))
$detected = 'XCache';
else
$detected = 'no_caching';

$context['settings_message'] = sprintf($context['settings_message'], $txt['detected_' . $detected]);

Code (Replace with) Select Expand

$detected = array();

// Detect an optimizer?
if (function_exists('eaccelerator_put'))
$detected[] = 'eAccelerator';
if (function_exists('mmcache_put'))
$detected[] = 'MMCache';
if (function_exists('apc_store'))
$detected[] = 'APC';
if (function_exists('output_cache_put'))
$detected[] = 'Zend';
if (function_exists('memcache_set'))
$detected[] = 'Memcached';
if (function_exists('xcache_set'))
$detected[] = 'XCache';

$installed = implode(', ', $detected);

if (empty($detected))
$context['settings_message'] = sprintf($context['settings_message'], $txt['detected_no_caching']);

$context['settings_message'] = sprintf($context['settings_message'], sprintf($txt['detected_accelerators'], $installed));

./Themes/default/languages/ManageSettings.php

Code (Find) Select Expand

$txt['detected_APC'] = '<strong style="color: green">SMF has detected that your server has APC installed.</strong>';
$txt['detected_eAccelerator'] = '<strong style="color: green">SMF has detected that your server has eAccelerator installed.</strong>';
$txt['detected_MMCache'] = '<strong style="color: green">SMF has detected that your server has MMCache installed.</strong>';
$txt['detected_Zend'] = '<strong style="color: green">SMF has detected that your server has Zend installed.</strong>';
$txt['detected_Memcached'] = '<strong style="color: green">SMF has detected that your server has Memcached installed.</strong>';
$txt['detected_XCache'] = '<strong style="color: green">SMF has detected that your server has XCache installed.</strong>';

Code (Replace with) Select Expand

$txt['detected_accelerators'] = '<strong style="color: green">SMF has detected the following accelerators: %1$s</strong>';

Again, it seems clunky and slow, but it's a quick fix that works.

[Kill Em All]

I marked this in mantis. Thanks for providing a fix too live627.
http://dev.simplemachines.org/mantis/view.php?id=4350

[live627]

Glad to help! Doing that was quite fun, too.

[Acans]

Updating the topic as Confirmed.

Nice work live627

[live627]

Is it hidden for a reason? Access denied to regular members...

[Norv]

Is it hidden for a reason? Access denied to regular members...

It should be visible... I think. I'll check.

ETA: you're right, sorry about that. It was moved to an area dedicated to the next version of SMF, where not all features or issues discussed are public yet. (they would become public, in time, as the next version becomes current version).

I will see what I can do, as 2.0 final approaches, to lift some of the veil as soon as we can.

[live627]

I assumed the reason was it was moved to Saguaro.

[Norv]

Yes.
Well, as I said, I will try to see about us making at least the acknowledged or proposed bugs to solve - publicly known.

The rest is a surprise for now.

[live627]

Party poppers? haha