$smcFunc['db_create_table'] "bug"

[Oranos]

./Sources/DbPackages-mysql.php

I don't think I would call this so much as a bug, but if a table creation is successful

Code Select Expand

if(!$smcFunc['db_create_table']($table_stuff))

does not return false. The reason being smf_db_create_table() doesn't have a return unless the table already exist. The solution is rather simple.

find

Code Select Expand

// Create the table!
$smcFunc['db_query']('', $table_query,
'security_override'
);

which is actually the very last thing in the function, and replace it with

Code Select Expand

// Create the table!
return $smcFunc['db_query']('', $table_query,
'security_override'
);

This is for MySQL, I don't really have any other SQL software to test it with, but without looking at the files, I assume it's probably the same issues for postgre and litesql.

[Norv]

Noted, thank you for the report!

I would call it a bug, at code level, regarding consistency and implementing the documented interface. smf_db_create_table() is documented in the file to have a boolean return and it already does that in some cases, so it'd better do it. 

[Oranos]

Interestingly enough, I only discovered this because I'm making an overly complicated (by complicated I mean fancy) installer for my next mod

[live627]

I should note this is also in PostgreSQL and SQLite as well as MySQL.

[Joshua Dickerson]

I feel like this was changed. Is this still a bug?

[emanuele]

Yep, still a bug...well, the documentation changed, now is no more documented the return value, so if you want you can say it's fixed.

[Joshua Dickerson]

I know there was a lot of talk about it. Perhaps Norv or someone could fill us in on what the outcome was.

[emanuele]

Similar problem for db_add_index: there are a couple of return false, but never a return true.

[Illori]

should this be tracked?

[Joker™]

Code Select Expand

array(
         'security_override' => true,
)

I noticed the change in the code in the DbPackages-mysql.php for both index and table.

[Arantor]

It's quite a bit different in the other backends because they do transactions and multiple queries to build tables and whatnot, but I've just committed a change for 2.1 that makes them return true once done successfully (since they'd fall into all the normal error handling if there's any failures...)