[4838] Wrong HTTP-Header created

[Tjati]

Hi there,

I'm checking the smf code for my own forum and I found several things. But this one is really not fine:

header('HTTP/1.0 404 ' . $txt['attachment_not_found']);
I mean - are you serios?! Holy crap. I checked it against a new zip from http://download.simplemachines.org/index.php/smf_2-0-rc4_install.zip
You found it at line 1314.
The line should be:

header($_SERVER['SERVER_PROTOCOL'].' 404 Not Found');
Not only the wrong Server Protocol could be used (compare please with http://php.net/header) also there is a text var used!
And I often see that HTTP/1.0 or HTTP/1.1 is used -> you should prefer $_SERVER['SERVER_PROTOCOL'].

[Joshua Dickerson]

This should be low-hanging fruit. Anyone have any reason that this should or shouldn't be changed?