Attachments in new window

[ekoo]

Greetings.

I've got a forum with a constrained width.   Thus, when expanding image attachments, it cuts off the right side overflow.   To prevent this, I'd like to open attachments in a new window.    I tried editing the href hook in the Display.php, but it didn't take.

Any ideas on how to make attachments open in a new window vs. the same one you're in?

Thanks in advance.

[Kindred]

I tried editing the href hook in the Display.php, but it didn't take.

Please be more specific.   What do you mean "it didn't take"?

Did you also edit display.template.php?

[ekoo]

I mean, I edited the following area in Display.php: 

Code Select Expand


'href' => $scripturl . '?action=dlattach;topic=' . $topic . '.0;attach=' . $attachment['id_attach'],
'link' => '<a href="' . $scripturl . '?action=dlattach;topic=' . $topic . '.0;attach=' . $attachment['id_attach'] . '">' . htmlspecialchars($attachment['filename']) . '</a>',

I tried to add a target="_blank" to test out opening in a new window, but no luck.

I did not see anywhere in the display.template.php that had code that controlled the attachments in posts.

[Kindred]

you added the target to WHICH line?

[ekoo]

As follows:

Code Select Expand


'link' => '<a href="' . $scripturl . '?action=dlattach;topic=' . $topic . '.0;attach=' . $attachment['id_attach'] . '" target="_blank">' . htmlspecialchars($attachment['filename']) . '</a>',


Thanks.

[Kindred]

I don't have the code in front of me, but I suspect that display.template.php uses the href out of the array, not the link.

[ekoo]

Alright, I'll revisit display.template.php again and see if I can find where it's writing that.    Thanks.

[Kays]

In the Admin CP > Features and Options > Layout. You can specify the maximum size of posted images. If an attachment is lager than those dimensions, it should open it in a new window.

[Road Rash Jr.]

Highslide mod works for this without messing with the code
http://custom.simplemachines.org/mods/index.php?mod=2518
Or you could just set the attachment permissions to a smaller sized attachment so it fits the screen.

[ekoo]

In the Admin CP > Features and Options > Layout. You can specify the maximum size of posted images. If an attachment is lager than those dimensions, it should open it in a new window.

THAT is what I was looking for!   Thanks so much. 

That mod looks nice too, I may try that out, thanks.