Bug in post indicators for recycle bin

[Douglas]

When you click on MARK READ, it actually sets them as new topics so the new post indicators don't go away.

This is done after the posts are removed.  Click on "MARK READ" and the "new posts" indicator comes on and doesn't go away.

2.0 Gold, only one mod installed (Twitter integration).
Using quick checkboxes for moderation. No errors in error log

[emanuele]

The problem is that when the topic is moved to the recycle board, maxMsgID is updated to the last message id excluding the recycle board, so when the mark as read button is used in the recycle board before another post is made, the recycle board is marked as unread.

The question is why the maxMsgID is changed when a post is deleted?
It's almost useless because anyway the new id_msg (and so id_last_msg) will always be higher then the previous one...am I wrong?

[Illori]

this is still happening? should this be tracked if so?

[emanuele]

Bump to get opinions in order to avoid break anything...more than I usually do!

So a fix would be to remove the change of maxMsgID when a post is deleted and including the recycle board in the counts of mark as read.

[Spuds]

I honestly don't know ... seems worrisome to me   

Would really need to look at the code to see how and where that is used.  Maybe someone familiar with that one can comment on how that var is used. 

[Arantor]

Consolidated to Github: https://github.com/SimpleMachines/SMF2.1/issues/1398