Logic error in Display.template.php

[maestrosite.ru]

Where the Error Occurred

    File: Display.template.php
    Line: 208-209, 633-636
    Any relevant errors in the SMF error log (if so please post them)?:

Form "quickModForm" echo without check $options['display_quick_mod']

(but checkboxes and javascript handlers for this form echo only  $options['display_quick_mod'] == 1)

[emanuele]

I can't find an instance of $options['display_quick_mod'] in Curve at the lines you reported.
Are you using the default theme and/or modifications?

[maestrosite.ru]

I can't find an instance of $options['display_quick_mod'] in Curve at the lines you reported.
Are you using the default theme and/or modifications?

Of course, not find. In this lines print 'form'-tags. In [strike]Curve[/strike] Core analog lines: 187-188, 603-604, respectively
Default themes from smf_2-0-2_install.tar.bz2

[emanuele]

In Curve I have $options['display_quick_mod'] at lines 460 and 765.
And in both cases the code looks like:

Code Select Expand

if (!empty($options['display_quick_mod']) && $options['display_quick_mod'] == 1 && [...]
so it first check if is !empty and then the value...

[maestrosite.ru]

In Curve I have $options['display_quick_mod'] at lines 460 and 765.
And in both cases the code looks like:

Code Select Expand

if (!empty($options['display_quick_mod']) && $options['display_quick_mod'] == 1 && [...]
so it first check if is !empty and then the value...

Yes, it is.

1. Have you form with id="quickModForm" in you file ?
2. Have you conditions for display this form? for dispaly start-tag "<form..." and for end-tag "</form>" ?

upd Sorry. In my previous post, analog lines: 187-188, 603-604 - it said about Core.
For Curve - lines in first post.

[emanuele]

1. Have you form with id="quickModForm" in you file ?

Yes, it's at line 188

2. Have you conditions for display this form? for dispaly start-tag "<form..." and for end-tag "</form>" ?

No, not in Curve neither in Core.

[maestrosite.ru]

1. Have you form with id="quickModForm" in you file ?

Yes, it's at line 188

2. Have you conditions for display this form? for dispaly start-tag "<form..." and for end-tag "</form>" ?

No, not in Curve neither in Core.

This means that there is a logical error. One part form dispaly without conditions, other parts with conditions, isn't it?

[emanuele]

You said "logic error" I was looking for a condition...

BTW this is not a bug because the same form is used for the "quick edit", so it is necessary there on every page load.

[maestrosite.ru]

You said "logic error" I was looking for a condition...

BTW this is not a bug because the same form is used for the "quick edit", so it is necessary there on every page load.

Small fix (8 lines), and "quick edit" independents of any form

[maestrosite.ru]

Now "quick edit" fix can be load as mod http://custom.simplemachines.org/mods/index.php?mod=3374