News:

Want to get involved in developing SMF, then why not lend a hand on our github!

Main Menu

Descriptive Links

Started by Spuds, March 06, 2012, 12:02:27 PM

Previous topic - Next topic

amd2107

#20
Hi  I Need help,
When i tried to center the link, it don't retrive the title, this can fix ?

Thanks


EDIT:

If you put the url for example:

[center]www.mysite.com[/center]

[center][url]www.mysite.com[/url][/center]


The mod don't work!

But if you put it of this way:

[center]

Title post

image

etc...


[url]www.mysite.com[/url]

or

www.mysite.com


More information in the post

[/center]


It Work Now...

:P

bdtcomp

I tried this and you are right.

Put a space between the brackets and it works! I don't know if that is a hassle to do each time, I guess it is if you are doing a lot of them. I will remember this myself, and I don't know where the code for this mod is, but seems like it could be fixed fairly easy!

feline

Well .. that mod don't works correct ..
After edit, the link description is changed.
See attached images:
test-1 : create message (links with and witout SEF)
test-1-1 : message after save
test-2 : edit message (link description is changed)
test-2-1 : save without edit


feline

Well .. that mod don't works correct ..
After edit, the link description is changed.
See attached images:
test-1 : create message (links with and witout SEF)
test-1-1 : message after save
test-2 : edit message (link description is changed)
test-2-1 : save without edit


Spuds

Ummmm .. yeah thats what the mod is supposed to do,  it updates the links with the page title  ::)

Texan78

Great job Spuds! This is the first and only mod like this that works on my site. Others seem to blame it on my server which it isn't rather then investigate their code. I am glad this one works with my site.

I haven't been using it long so I haven't seen the issues others have seen. But maybe one suggestion from what I have been reading about sites with no titles. If possible if the mod doesn't parse a title from the URL have the mod set a default title to say something like "Link" so its not just posting nothing. I know other mods like this for other forums platforms do that. Just a suggestion if you're looking for a work around.

Nitesh Kunnath

Quote from: Spuds on May 26, 2012, 11:14:28 PM
Ummmm .. yeah thats what the mod is supposed to do,  it updates the links with the page title  ::)
@Spuds, bro please look into the bug which sometimes gives no title to a link and hence the link gets hidden.
Try any link with no title like this:
[url=http://google.com][/url]
Such link gets hidden......this mod sometimes doesnt give a title to certain web links (just some particular domain link) and hence the whole link gets hidden.
Apart from this issue, the mod is super awesome...hats off to you for this wonderful work :)

Texan78

Quote from: die2mrw007 on May 27, 2012, 02:12:41 AM
Try any link with no title like this:
[url=http://google.com][/url]
Such link gets hidden......this mod sometimes doesnt give a title to certain web links (just some particular domain link) and hence the whole link gets hidden.

I believe the problem with linking URL's the way you showed is because those are meant for user submitted titles verses just posting the URL and letting the mod parse a title as the mod is developed to do. If you just post a URL or embed it between URL bbc tags it will parse the title. See attachment for example.

Nitesh Kunnath

Quote from: Texan78 on May 27, 2012, 03:11:03 AM
Quote from: die2mrw007 on May 27, 2012, 02:12:41 AM
Try any link with no title like this:
[url=http://google.com][/url]
Such link gets hidden......this mod sometimes doesnt give a title to certain web links (just some particular domain link) and hence the whole link gets hidden.

I believe the problem with linking URL's the way you showed is because those are meant for user submitted titles verses just posting the URL and letting the mod parse a title as the mod is developed to do. If you just post a URL or embed it between URL bbc tags it will parse the title. See attachment for example.
I know this. Actually some members sent a link to me via PM (it isnt the root path of the domain...some particular post link from that domain) which the Descriptive mod didnt given a title and hence it got hidden to me....when I quoted the PM which he sent me, I was able to see the link which was not provided with a title on its own.

Texan78

What is the link of question that is not showing a title? I can test it on my board and see if I get the same results. Did you by chance check to see if the page being linked even had a title set in the source or did a title show in the browser?

I know there are some links that won't have titles for the exact reason it may not have one. I think the best way around that is what I described earlier for the mod to check if the link has a title and if not set a default title with some text that simply says "Link" so it's not just blank.

Nitesh Kunnath

Quote from: Texan78 on May 27, 2012, 03:30:02 AM
What is the link of question that is not showing a title? I can test it on my board and see if I get the same results. Did you by chance check to see if the page being linked even had a title set in the source or did a title show in the browser?

I know there are some links that won't have titles for the exact reason it may not have one. I think the best way around that is what I described earlier for the mod to check if the link has a title and if not set a default title with some text that simply says "Link" so it's not just blank.
Yes, you got it now exactly. The members there at my forum will not be knowing about this thing and they will simply copy paste the link and send. The receiver will get a blank PM (though not blank actually). I received many complaints from users stating that the links they send doesnt get delivered to receiver and hence I disabled this mod for time being until I find a solution for this.

Is there any way to modify the mod such that the links having no title should be set into exception and thus it will not parse via this descriptive mod purpose.
Or make those No-Title link with default Title as "Link" or something.


The reason for this here is that, people will not be bothered to verify the link which they post whether it is having a title or not and thus the receiver of such links will always get a blank message giving the forum a bad impression of a BUG for them!

Eclipse16V

I have included a small problem with links to a comma.
Such is for example from the link:
http://www.yourdomain.com/index.php?t=test,domain

Later, he sees but then like this:
Your Domain,domain
I worked with:
SMF 2 in German

Shop:
SID Giessen

Kindred

one of my staff has encountered an off glitch with this mod.

It works perfectly for me...
When he moves a post, however, the auto-generated post with link to the new location uses the correct title but points to a completely different thread
Слaва
Украинi

Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

Spuds

Quote from: Eclipse16V on May 27, 2012, 06:51:40 AM
I have included a small problem with links to a comma.
Such is for example from the link:
http://www.yourdomain.com/index.php?t=test,domain

Later, he sees but then like this:
Your Domain,domain
Yes I know people hate to hear this but thats "how it works" .... it stops at a ',' since it does not know if its part of the link, or part of the text around the link.  So it plays it safe in that regard (since you can't always depend on folks to put a space after the comma) .... you can adjust the regex in the program if you don't want the default behavior but I'm not going to change that for the mod since it might gab normal text as a link.

Spuds

Quote from: die2mrw007 on May 27, 2012, 02:12:41 AM
[url=http://google.com][/url]
Such link gets hidden.....
I think plain old SMF would show a blank link for a BBC URL set up like that ... I think the mod would try to find a title and insert one for you, but if it could not it would leave it as is, a blank link.  I guess I could repair them, e.g. turn them in to
[url=http://google.com]http://google.com[/url]

Spuds

Quote from: Texan78 on May 27, 2012, 03:30:02 AM
What is the link of question that is not showing a title? I can test it on my board and see if I get the same results. Did you by chance check to see if the page being linked even had a title set in the source or did a title show in the browser?

I know there are some links that won't have titles for the exact reason it may not have one. I think the best way around that is what I described earlier for the mod to check if the link has a title and if not set a default title with some text that simply says "Link" so it's not just blank.
The mod does check for blank titles, or no titles found, in which case it leaves the link as it was entered.   Obviously there have been reports of blank titles, or probably some non displayable junk in the title, so it would "disapear"   However to fix that I need specific links to see what it might be doing before I can do that.

Spuds

Quote from: Kindred on May 27, 2012, 09:35:35 AM
one of my staff has encountered an off glitch with this mod.

It works perfectly for me...
When he moves a post, however, the auto-generated post with link to the new location uses the correct title but points to a completely different thread
Hummm ... interesting.  I don't think I ever ran that usage case in testing, will have to take a look !

Nitesh Kunnath

Quote from: Kindred on May 27, 2012, 09:35:35 AM
one of my staff has encountered an off glitch with this mod.

It works perfectly for me...
When he moves a post, however, the auto-generated post with link to the new location uses the correct title but points to a completely different thread
Yes, yes, this same thing happened with me too... Though I was not knowing why it was showing wrong description....Now after your report, I got it clear that its due to "thread location move"

Nitesh Kunnath

Quote from: Spuds on May 27, 2012, 09:59:14 AM
Quote from: die2mrw007 on May 27, 2012, 02:12:41 AM
[url=http://google.com][/url]
Such link gets hidden.....
I think plain old SMF would show a blank link for a BBC URL set up like that ... I think the mod would try to find a title and insert one for you, but if it could not it would leave it as is, a blank link.  I guess I could repair them, e.g. turn them in to
[url=http://google.com]http://google.com[/url]
can something be done to such links? such no title link gets hidden in post
now, check this one (just an example)
Google

Now the "No title version here:


See here, the link is hidden....just Quote my post to see the exact content or if moderation capability, do click on modify on my post and see the content. The link is actually there but hidden

Texan78

Quote from: die2mrw007 on May 27, 2012, 03:52:00 PM
Now the "No title version here:
[url=http://google.com][/url]

Because as I explained this morning that is the code for the user inputted titles. The mod won't parse a title because it's expecting user input. Look carefully at what you posted... If you don't assign it a title then it will be blank, the mod will not parse a title that it's expecting a user to input.

It should be this....


[url=http://google.com]Google[/url]


Advertisement: