Topic: [5000] Bug in code tag

[Akyhne]

Code: [Select]

echo ' »';

[Akyhne]

Code: [Select]

foreach ($context['linktree'] as $link_num => $tree)
{
if (isset($board_info['cat']) && $tree['name'] !== $board_info['cat']['name'] || !isset($board_info['cat']))
{
echo '
<li', ($link_num == count($context['linktree']) - 1) ? ' class="last"' : '', '>';

// Show something before the link?
if (isset($tree['extra_before']))
echo $tree['extra_before'];

// Show the link, including a URL if it should have one.
echo $settings['linktree_link'] && isset($tree['url']) ? '
<a href="' . $tree['url'] . '"><span>' . $tree['name'] . '</span></a>' : '<span>' . $tree['name'] . '</span>';

// Show something after the link...?
if (isset($tree['extra_after']))
echo $tree['extra_after'];

// Don't show a separator for the last one.
if ($link_num != count($context['linktree']) - 1)
echo ' »';

echo '
</li>';
}
}

[Akyhne]

Code: [Select]

foreach ($context['linktree'] as $link_num => $tree)
{
if (isset($board_info['cat']) && $tree['name'] !== $board_info['cat']['name'] || !isset($board_info['cat']))
{
echo '
<li', ($link_num == count($context['linktree']) - 1) ? ' class="last"' : '', '>';

// Show something before the link?
if (isset($tree['extra_before']))
echo $tree['extra_before'];

// Show the link, including a URL if it should have one.
echo $settings['linktree_link'] && isset($tree['url']) ? '
<a href="' . $tree['url'] . '"><span>' . $tree['name'] . '</span></a>' : '<span>' . $tree['name'] . '</span>';

// Show something after the link...?
if (isset($tree['extra_after']))
echo $tree['extra_after'];

// Don't show a separator for the last one.
if ($link_num != count($context['linktree']) - 1)
echo ' &#187;';

echo '
</li>';
}
}

[Akyhne]

Hmm, if you look at the code above, there's a difference. When posting the code example from quick reply, the part echo echo ' & # 1 8 7;'; gets replaced with echo ' »';
If you post from the reply window, it is saved as is.

I scream bug!

[emanuele]

Code: [Select]

echo ' »';quickreply

[emanuele]

Code: [Select]

echo ' »';post page

[emanuele]

echo ' »';

[emanuele]

Okay, at the moment inconsistency is not a problem in 2.1: in both cases the code is converted to ».

Now back to the issue. The cause is smc_saveEntities.
This javascript function is used to:

Code: [Select]

value.replace(/&#/g, '&#');in every element of the form posted...from the editor, not from the quick reply because the quick reply doesn't use the editor.

Now, my question is: is there any advantage doing this replacement client-side instead of server-side?
Probably the fact that client-side we should know which fields must be processed?

[Akyhne]

FYI, I tracked this one: http://dev.simplemachines.org/mantis/view.php?id=5000

EDIT: Ooh, bug no 5000. Is that a good thing or a bad one, lol

[emanuele]

I know, but I prefer discuss things here for two reasons:
1) everybody can help here,
2) I still don't know how to post highlighted code with mantis.

[emanuele]

xref: http://www.simplemachines.org/community/index.php?topic=400012.msg3392614#msg3392614