Quoting a post doesn't work in Chrome (fix included)

Started by zioth, July 10, 2013, 09:24:12 PM

Previous topic - Next topic

zioth

Using Chrome:
1) Reply to a post (full reply, not quick reply).
2) Do not click on the editor.
3) Click on the "insert quote" button on any of the previous posts.
4) The quote is not inserted.

If you click on the editor first, it works. This problem is actually bigger than just quotes. None of the editor buttons work if you haven't clicked on the editor. So you can't, for example, insert a smily.

The fix is in editor.js:

// Set the focus for the editing window.
smc_Editor.prototype.setFocus = function(force_both)
{
   if (!this.bRichTextEnabled)
      this.oTextHandle.focus();
   else if (is_ff || is_opera)
      this.oFrameHandle.focus();
   else
      this.oFrameWindow.focus();

   else
      this.oFrameDocument.body.focus();
}

Oldiesmann

Thanks for the report :)

On a side note, this isn't an issue with the new editor in 2.1.
Michael Eshom
Christian Metal Fans

Shambles

Seems like this has come full circle...


Quote from: Nao 尚 on June 11, 2010, 09:26:40 AM
Try editing editor.js

// Set the focus for the editing window.
smc_Editor.prototype.setFocus = function(force_both)
{
if (!this.bRichTextEnabled)
this.oTextHandle.focus();
else
this.oFrameWindow.focus();
}


Replace that block with:

// Set the focus for the editing window.
smc_Editor.prototype.setFocus = function(force_both)
{
if (!this.bRichTextEnabled)
this.oTextHandle.focus();
else if (is_ff || is_opera)
this.oFrameHandle.focus();
else
this.oFrameWindow.focus();
}


This is what I committed a couple of weeks ago. Try it if you'd like.

Arantor

Especially as it works in Chrome in 2.0 when trying to reproduce. I'd almost suggest it's a Chrome bug that was since fixed.

zorer

Hi, My SMF it's the v.2.0.9 upgraded from the 2.0.4 and worked well until now, the theme it's Anecdota_20g

i tried this fix and worked. But.... after a few hours working nice now the buttons from the BBCODE are not working, if i change the theme they are working nice, i don't know how to fix it.

Looks some php or js are wrong, but i don't have any idea how to fix it.

In firefox works great anyway, but the Chrome/Opera users only can posts text, the buttons like "quote" or "code" are not working (means you push and nothing happens).

Thanks for any help.

vietravel247.com

Quote from: zorer on January 12, 2015, 07:02:26 PM
Hi, My SMF it's the v.2.0.9 upgraded from the 2.0.4 and worked well until now, the theme it's Anecdota_20g

i tried this fix and worked. But.... after a few hours working nice now the buttons from the BBCODE are not working, if i change the theme they are working nice, i don't know how to fix it.

Looks some php or js are wrong, but i don't have any idea how to fix it.

In firefox works great anyway, but the Chrome/Opera users only can posts text, the buttons like "quote" or "code" are not working (means you push and nothing happens).

Thanks for any help.
I have the same problem.

Kindred

well, are you using an old version of Chrome?

And are you on SMF 2.0.9?

If the answer is yes...  then your solution is -- UPDATE --

if the answer is no...  then you don't actually have the same problem.
Слaва
Украинi

Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

sakis11111

same problem here guys. It seems that nothing works. Any new trick?

Arantor


sakis11111

sorry for my delay to answer Aran

version 2.0.12

mods installed and working nicely all of them

1.   Ohara YouTube Embed   1.2.7     [ Uninstall ] [ List Files ] [ Delete ]
2.   Sisyphus   1.2     [ Uninstall ] [ List Files ] [ Delete ]
3.   Global Headers Footers   2.0.1     [ Uninstall ] [ List Files ] [ Delete ]
4.   Social Share Topics And Posts   1.0     [ Uninstall ] [ List Files ] [ Delete ]
5.   Buddy Page   2.1     [ Uninstall ] [ List Files ] [ Delete ]
6.   Descriptive Links   1.2     [ Uninstall ] [ List Files ] [ Delete ]
7.   Default Signature   1.0   [ List Files ] [ Delete ]
8.   Better Profile Menu   1.10     [ Uninstall ] [ List Files ] [ Delete ]
9.   ENotify   3.0     [ Uninstall ] [ List Files ] [ Delete ]
10.   Advance Fake Guests n Users Online (fguo)   1.0     [ Uninstall ] [ List Files ] [ Delete ]
11.   Hide ip stuff for users   1.05     [ Uninstall ] [ List Files ] [ Delete ]
12.   SMFPacks Shoutbox   1.0.5     [ Uninstall ] [ List Files ] [ Delete ]
13.   New Topic Button   1.0     [ Uninstall ] [ List Files ] [ Delete ]
14.   Signature Prompt   1.0   [ List Files ] [ Delete ]
15.   Fake Topic Views   0.1     [ Uninstall ] [ List Files ] [ Delete ]
16.   Change All Subjects   1.3     [ Uninstall ] [ List Files ] [ Delete ]
17.   OneAll Social Login   1.0   [ List Files ] [ Delete ]
18.   Profile Comments   2.2     [ Uninstall ] [ List Files ] [ Delete ]
19.   Member Notepad   1.0.1     [ Uninstall ] [ List Files ] [ Delete ]
20.   Board Viewers Mod   1.2.1.1b     [ Uninstall ] [ List Files ] [ Delete ]
21.   JDALIP - Join Date And Location In Posbit   1.3.2     [ Uninstall ] [ List Files ] [ Delete ]
22.   Add Favicon.ico Support   1.3     [ Uninstall ] [ List Files ] [ Delete ]
23.   Language on Register   1.0     [ Uninstall ] [ List Files ] [ Delete ]
24.   Footer Menu   1.1.2     [ Uninstall ] [ List Files ] [ Delete ]
25.   Simple .htaccess Cache Mod   2.7     [ Uninstall ] [ List Files ] [ Delete ]
26.   Reply Button In Every Post   1.0     [ Uninstall ] [ List Files ] [ Delete ]
27.   AvatarSelect   1.2.1     [ Uninstall ] [ List Files ] [ Delete ]
28.   Scrolling Buttons   0.3     [ Uninstall ] [ List Files ] [ Delete ]
29.   Reason For Editing Mod   2.3.2   [ List Files ] [ Delete ]
30.   Groupdocs Viewer .NET   1.0     [ Uninstall ] [ List Files ] [ Delete ]
31.   WYSIWYG Quick Reply   2.3     [ Uninstall ] [ List Files ] [ Delete ]
32.   Alternate User Posting   1.0.1     [ Uninstall ] [ List Files ] [ Delete ]
33.   SMF 2.0.12 Update   1.0     [ Uninstall ] [ List Files ] [ Delete ]
34.   Send Locked Topics To Bottom   1.0     [ Uninstall ] [ List Files ] [ Delete ]
35.   Default Avatar   2.3     [ Uninstall ] [ List Files ] [ Delete ]
36.   Say Thanks   1.3.6     [ Uninstall ] [ List Files ] [ Delete ]
37.   Social Login   3.5     [ Uninstall ] [ List Files ] [ Delete ]
38.   Remove Topic: From The Thread Title   1.2     [ Uninstall ] [ List Files ] [ Delete ]
39.   Separate the sticky topics   1.0.1     [ Uninstall ] [ List Files ] [ Delete ]
40.   Font Awesome   1.0.1     [ Uninstall ] [ List Files ] [ Delete ]
41.   Remove Re From Post Title   1.0     [ Uninstall ] [ List Files ] [ Delete ]
42.   Super Simple Thread Tags   1.2     [ Uninstall ] [ List Files ] [ Delete ]
43.   Invitation Message In Your Face (IMIYF)   0.3.2     [ Uninstall ] [ List Files ] [ Delete ]

sakis11111

fixed!!

The problem was with the buddy page mod. Uninstall it and all are fine. Solved

Advertisement: