News:

Bored?  Looking to kill some time?  Want to chat with other SMF users?  Join us in IRC chat or Discord

Main Menu

News fader height varies

Started by Krashsite, April 01, 2014, 01:10:46 AM

Previous topic - Next topic

Sir Osis of Liver

Not really a bug, but kind of annoying.  If multiple news items have different number of lines, the fader box jumps up and down when it switches from one to another.  Can be fixed by adding cr's to shorter items, but would be better if it maintained same height for all items, based on item with most lines.
Ashes and diamonds, foe and friend,
 we were all equal in the end.

                                     - R. Waters

Antes

Current newsfader has no adaptive height model (unfortunately), that's why i like to change newsfader with a new news holder (I'm currently trying bxSlider).

You can find my work here (SMF 2.1); https://github.com/Antes/kittenground/tree/new-news

Sir Osis of Liver

Ashes and diamonds, foe and friend,
 we were all equal in the end.

                                     - R. Waters

Antechinus

Just set a fixed height in the css. :P

Sir Osis of Liver

If you set a fixed height, the box will either be too big for short items, or too small for long items.  Best thing would be if height were adjusted automatically to longest item, with a max height to scroll very long items.
Ashes and diamonds, foe and friend,
 we were all equal in the end.

                                     - R. Waters

Antechinus

Ok, min-height then. Or auto overflow. Or height + CSS resize. Or all of the above.

Sir Osis of Liver

Will try it if I get a chance.
Ashes and diamonds, foe and friend,
 we were all equal in the end.

                                     - R. Waters

Advertisement: