News:

Wondering if this will always be free?  See why free is better.

Main Menu

@mention members

Started by Dragooon, May 02, 2014, 01:07:58 PM

Previous topic - Next topic

Kimmie

Quote from: Kimmie on August 31, 2014, 01:07:06 PM
Not sure if this has been mentioned before (no pun intended..lol), but if someone has a blank space in their name, the drop down list will not find them. How do I fix this?


Thanks :)



Quote from: Kimmie on October 05, 2014, 02:25:39 PM
Just noticed that if you modify an existing post and add a mention, it doesn't notify them of it at the top like it does when you add a mention to a new post. It still lists it on their mentions page, just not the notification at the top . This is causing some of my mods to miss mentions unless they go to their mentions page to look and see if they have been mentioned.

Is there a way to fix this? Thanks :)


Any idea when these two issues will be fixed? Thanks )

Mr. Jinx

#341
Quote from: Kimmie on August 31, 2014, 01:07:06 PM
Not sure if this has been mentioned before (no pun intended..lol), but if someone has a blank space in their name, the drop down list will not find them. How do I fix this?
Try this: http://www.simplemachines.org/community/index.php?topic=522005.msg3704608#msg3704608
Please note: "Themes/default/mentions.js" should be "Themes/default/scripts/mentions.js"

Mr. Jinx

#342
Quote from: butch2k on October 02, 2014, 07:04:11 AM
In mentions_process_store replace the $subject by an $emailsubject at two places:


loadLanguage('Mentions');

$emailsubject= str_replace(array_keys($replacements), array_values($replacements), $txt['mentions_subject']);
$body = str_replace(array_keys($replacements), array_values($replacements), $txt['mentions_body']);
sendmail($mention['email_address'],$emailsubject, $body);

Thanks for this correction!

Anyone know how to fix if a username is starting with a special character?
For example @<username> doesn't work.

Kimmie

Quote from: Mr. Jinx on October 28, 2014, 02:20:32 PM
Quote from: Kimmie on August 31, 2014, 01:07:06 PM
Not sure if this has been mentioned before (no pun intended..lol), but if someone has a blank space in their name, the drop down list will not find them. How do I fix this?
Try this: http://www.simplemachines.org/community/index.php?topic=522005.msg3704608#msg3704608
Please note: "Themes/default/mentions.js" should be "Themes/default/scripts/mentions.js"


I do not feel comfortable  completely changing someone else's files like that. If it worked I would assume the mod auth would have already updated the mod with the changes. Thnks anyways.

Mr. Jinx

??? Dragooon is the creator of this mod, and he is suggesting the change. If you don't trust him, why did you install it anyway?

Mr. Jinx

Dutch translation:

Download: Mentions.dutch.php

and

In Modifications.dutch.php add:
$txt['mentions'] = 'Vermeldingen';
$txt['scheduled_task_removeMentions'] = 'Verwijder vermeldingen die gezien zijn';
$txt['scheduled_task_desc_removeMentions'] = 'Verwijdert vermeldingen die gezien zijn en ouder dan het opgegeven aantal dagen';

Dragooon

Quote from: Kimmie on October 31, 2014, 07:54:35 PM
Quote from: Mr. Jinx on October 28, 2014, 02:20:32 PM
Quote from: Kimmie on August 31, 2014, 01:07:06 PM
Not sure if this has been mentioned before (no pun intended..lol), but if someone has a blank space in their name, the drop down list will not find them. How do I fix this?
Try this: http://www.simplemachines.org/community/index.php?topic=522005.msg3704608#msg3704608
Please note: "Themes/default/mentions.js" should be "Themes/default/scripts/mentions.js"


I do not feel comfortable  completely changing someone else's files like that. If it worked I would assume the mod auth would have already updated the mod with the changes. Thnks anyways.
Uh I haven't had much time to support the mod due to real life and 2.1 (whatever little time I am getting I'm trying to put into 2.1) but that change should help with things. I would've suggested pulling the JS directly from 2.1 but I don't remember what changes there are between 2.0 and 2.1 (if any) so for now I'd avoid that.

aquagrrl

Sorry to intrude - I'm getting no drop down at all when installing this mod. I have a custom theme - is there possibly something I need to put in my theme to make it work? I didn't see any instructions indicating as such. Conversely, any known conflicting mods?

I see you're busy, just hoping you have time to point me in the right direction. Tried both WYSIWYG and without.

Rain Forest

Quote from: aquagrrl on November 07, 2014, 03:01:24 PM
Sorry to intrude - I'm getting no drop down at all when installing this mod. I have a custom theme - is there possibly something I need to put in my theme to make it work? I didn't see any instructions indicating as such. Conversely, any known conflicting mods?

I see you're busy, just hoping you have time to point me in the right direction. Tried both WYSIWYG and without.

Did you put the mentions.css in your customtheme/css/ folder?

Also put the mentions.js & jquery.atwho.js in your customtheme/scripts folder and Mentions.english.php and Mentions.english-utf8.php in your customtheme/languages folder.

aquagrrl

I feel like a dolt.  :-[ There are two mentions mods, and had the other installed. Not sure why it didn't work, but I installed this one, which was the one I wanted all along and after refreshing, it worked perfectly. Those files didn't need to be installed in the custom theme.

Thanks for the help though! It was looking for files that didn't exist that tipped me off I was doing something wrong.

gorbi

I am sorry, is it possible to implement the combination @all?

Mr. Jinx

Anyone know how to fix if a username is starting with a special character?
For example @<username> doesn't work.

Dragooon

To those having problems with UTF-8 usernames and spaces etc, can you try the attached package?

butch2k

Dragoon could you take into account my PR for fixing incorrect email subject when multiple users are mentionned in one post.

Dragooon

Quote from: butch2k on November 27, 2014, 05:25:15 AM
Dragoon could you take into account my PR for fixing incorrect email subject when multiple users are mentionned in one post.
Ah I missed it before, I've merged it on GH. I'll post an updated 1.1.3 if the one I attached checks out.

Elizabeth II

Could you look into an issue where mentions in profile don't go away once read? Also I've noticed that [1] appears randomly on occasions when I haven't even been mentioned.

waplist

It doesnt work properly .it doesnt show error when creating post but shows error when modifying post.it shows parse_mentions error even when i dont mention anyone

br360

My site is https, and when I get a mention, I'll go into profile>>Mentions and everything is fine. However, as soon as I open any of the topics in the "Posts mentioning  my username" in my profile, the link in my browser now becomes http. Any idea how I can fix this?

Mr. Jinx

Quote from: waplist on November 28, 2014, 01:12:17 PM
It doesnt work properly .it doesnt show error when creating post but shows error when modifying post.it shows parse_mentions error even when i dont mention anyone
What version are you using? The one from the modification site, or the one Dragooon just posted?

Quote from: br360 on November 29, 2014, 02:30:25 AM
My site is https, and when I get a mention, I'll go into profile>>Mentions and everything is fine. However, as soon as I open any of the topics in the "Posts mentioning  my username" in my profile, the link in my browser now becomes http. Any idea how I can fix this?
My site is also https only, but mention links are fine. They are all https.
Anyway, don't you have redirects setup? I have redirected all http urls to https in case someone is using http. It's also better for search enginges to prevent duplicate content. Make sure you make a permanent (301) redirection.

waplist

@Mr.Jinx i downloaded it from mod site. Version is 1.1.2
Is it latest?

Advertisement: