2.0.9 - Another Package Manager Bug

Started by Burke ♞ Knight, October 06, 2014, 11:39:01 PM

Previous topic - Next topic

Burke ♞ Knight

Package manager, new install, readme files for mods are not visible or they are, but bbc not parsed.
Tested with several mods, that know have readme as files and have their bbc parsed on 2.0.8 test site.

Illori

are you sure the mods have bbc or html in their readme's? links to the mods you tested?

margarett

Just tested with Breeze, readme is parsed.
Ultimate menu, also.
Se forem conduzir, não bebam. Se forem beber... CHAMEM-ME!!!! :D

QuoteOver 90% of all computer problems can be traced back to the interface between the keyboard and the chair

Burke ♞ Knight

Try team page, default avatar and even my Group Key Order and Style mod.
They show their readme parsed in 2.0.8 but not in clean 2.0.9 install.

Note: Not all mods are effected, so maybe it is how the package file is set to do the readme?

Illori

you have some html in your readme, i think that is tripping up the package manager now. i believe it no longer accepts html. if you used the entities i think it work work fine.

Burke ♞ Knight

Quote from: Illori on October 07, 2014, 06:53:12 AM
you have some html in your readme

Well, that mod kind of needs it....LOL
Usually, I make sure all my readme files are BBC only, as I know I can't post html on the forum here, and never knew that could in the readme files for mods, especially when it never parsed it... LOL

Now to figure out how to do my little note where the HTML will not be a bother:

[size=12pt][color=red][b]Be sure to close the HTML tags in reversed order.
Example: In Start Box: <strong><em>
In End Box: </em></strong>[/b][/color][/size][hr]

Burke ♞ Knight

Do not know why this topic got moved, as just because one of the mods had HTML, does not mean the issue is solved.
Default avatar does not have HTML, although it does have < & > in it:

If a user's has not selected or uploaded any avatar, then this mod shows a standard avatar on post pages.

Settings to enable it can be found at
Modification Settings » Miscellaneous.

The default_avatar.png images is located in
themes\<theme you are using>\images\default_avatar.png

Now with the new version you can simply change the image path through settings panel only. You just have to place the image url and click save, the url image will become default image automatically.


Also, Team Page:

[table]
[tr]
[td]
[color=#006400][size=16pt][b]Team Page[/b][/size][/color]
This mod gives you a fully customizable team page for your forum.
[iurl=http://custom.simplemachines.org/mods/index.php?mod=2167]Link to Mod[/iurl] | [iurl=http://www.simplemachines.org/community/index.php?action=post;topic=339954.0]Comment On This Mod[/iurl]

[b]Updated on:[/b] 19th July 2012
[b]Current Author:[/b] [url=http://www.simplemachines.org/community/index.php?action=profile;u=254071]Diego Andrés[/url]
[/td]
[td]
[b]Author:[/b] [url=http://custom.simplemachines.org/mods/index.php?action=profile;u=227037]Dream Portal[/url]
[b]Original creator:[/b] [url=http://custom.simplemachines.org/mods/index.php?action=profile;u=111571]ccbtimewiz[/url]
[b]Type:[/b] [url=http://custom.simplemachines.org/mods/index.php?action=search;type=1]New Feature[/url]
[b]Available since:[/b] 22th September 2009
[b]Latest version:[/b] 3.6
[b]Compatible with:[/b] SMF 2.0, SMF 2.0.1, SMF 2.0.2
[b]Available languages:[/b] [size=1][img]http://www.simplemachines.org/site_images/lang/english.gif[/img] [img]http://www.simplemachines.org/site_images/lang/spanish_es.gif[/img][/size]
[/td]
[/tr]
[/table]
[hr]

[color=#228B22][b][size=12pt]What does it do?[/size][/b][/color]
[i]Team Page[/i] enable a customizable page to show the members of the team of your forum. You can choose which membergroups to show in your team page, and also change some settings for the page.

[color=#228B22][b][size=12pt]How to use[/size][/b][/color]
To use [i]PM Informer[/i], [url=http://custom.simplemachines.org/mods/index.php?mod=2167]download the package from the SMF customization site[/url], and install it via your [url=http://docs.simplemachines.org/index.php?topic=95]Package Manger[/url].
It should add a new page in your forum displaying the members of the team. You can also set your own settings in the [color=maroon]*[/color] admin center for customize your team page.

[size=1][color=maroon][b]*[/b][/color] = Settings are located in
[i]Admin > Configuration > Manage Team Page [b](2.0)[/b][/i][/size]

[color=#228B22][b][size=12pt]Support & comments[/b][/color]
If you have a problem with this mod, want to comment, or have any question, please [url=http://www.simplemachines.org/community/index.php?action=post;topic=339954.0]post to the modification support topic[/url] and I will reply as soon as possible.

[color=#228B22][b][size=12pt]Other information[/size][/b][/color]
[b]Translation of this mod[/b]
o I am always happy to get translations of my work so that more users can use it. If you have translated this modification, please [url=http://www.simplemachines.org/community/index.php?action=post;topic=339954.0]post the translation in the support topic[/url].
Please make sure you have translated everything, and that there are no spelling misstakes etc.
Also, please post both a non-UTF8 version and a UTF8 version.
[b]Credits[/b]
o Thanks [url=http://custom.simplemachines.org/mods/index.php?action=profile;u=111571]ccbtimewiz[/url], the original creator.

[color=#228B22][b][size=12pt]Changelog[/size][/b][/color]
[size=7pt][color=blue]>[/color] Added Spanish translation[/size]
[size=7pt][color=green]+[/color] Now you can show the group description[/size]
[size=7pt][color=pink]*[/color] Added SMF 2.0.2 support[/size]
[size=7pt][color=brown]$[/color] New version [b]3.6[/b][/size]
[size=10pt]3.6 | [b]July 19 2012[/b][/size]
[size=7pt][color=brown]$[/color] Team Page taken over by Diego Andrés[/size]

[hr]
[table]
[tr]
[td][b]Changelog legend[/b]
[color=green]+[/color] New feature
[color=red]-[/color] Feature removal
[color=limeGreen]![/color] Bugfix
[color=blue]>[/color] New language
[color=orange]<[/color] Removed language
[color=pink]*[/color] New version support
[color=brown]$[/color] Initial release / Big update[/td]
[td]
[b]Versionnames[/b]
[i]Format: $.o.x.![/i]
[i]Example: 3.2.4.1[/i]

$ New version
o New features added
x Bugfix
! Small bugfix / New version support

[/td]
[td]
[b]Passed versions of this mod[/b]
2.0.2
2.0.1
2.0
[/td]
[/tr]
[/table]
[hr]

live627

QuoteDo not know why this topic got moved
Because this is not a bug.

HTML should no longer be allowed in the README as it's a source of a possible XSS attack. Most forum admins aren't competent enough to review code that they blindly put on their websites, and don't catch rogue code until it's too late.

Prevention is better than a cure.

Burke ♞ Knight

Look at my last post.
Those 2 mods do NOT have html!

Yes, they have some special characters, like < and > but not html.

Arantor

Yes but those *count* towards it.

And, funnily enough, < and > IS HTML.

Burke ♞ Knight

Well, they are used for more than html.
When telling where to do settings in admin panel, modders usually use them:

Admin > Features > Blah >blah >blah

So now what are we all supposed to do?
Change all our readme files due to a change that we all never even knew was coming?

Not me. I'll be removing my mods from the mod site, before I do that....LOL

live627

Quote from: BurkeKnight on October 07, 2014, 04:16:16 PM
Look at my last post.
Those 2 mods do NOT have html!

Yes, they have some special characters, like < and > but not html.
Use entities.

Arantor

QuoteChange all our readme files due to a change that we all never even knew was coming?

Because it was so blatantly done to spite you, obviously ::)

Or not, as it happened. I know what was changed. I seem to recall being one of the people involved in making a recommendation on this and it wasn't done to be annoying but because security is more important than you learning to type four characters instead of one.

Then again you could be on Discourse where you have to do that all the time in any post you ever want to use < or >.

Burke ♞ Knight

Well, a little warning of such a change would be useful.
However, it has already decided something for me that I've been debating for a few months now.
So what is done is done, just would have been nice to have had some warning, or at least them updating the info topics on mod making. ;)

Arantor

So in future we have to tell you what's done before it's actually done?

Next you'll be telling me that if you make a mod for 2.1 beta 1, they have to tell you before they make any changes for beta 2 and beyond...

Sorry, IMO it's not their responsibility to go through and deal with that.

Burke ♞ Knight

Not saying that, but if there is a change that will effect things like a readme file being displayed, a little note on the topics THEY have for mod makers would not be too much to ask for.

Arantor

No, you *are* saying that.

You are expecting them to tell you about every change before it goes live. That is what you are saying.

This is also why the changelog is a thing and appears as soon as a new version is deployed - and they can't tell  you AHEAD of time for something like this because advising people 'hey, there's a vulnerability in this function' before there's a patch is like handing a loaded gun to miscreants and saying 'please please don't shoot me with that gun'.

Yes, such a thing could *now* be updated but you are really making a big deal out of something that, frankly, is a tiny matter and you are actually being unreasonable about it.

Burke ♞ Knight

No, it is NOT what I am saying.
I don't give a dang about the little stuff.
It's what can make things like important notes about mod installations, that can be found in the readme files, that I care about.

Okay, I( understand why not say something before the update, but when I started this topic, it got moved, before it was actually explained. That is why I am seeming to be "unreasonable".

It's not the change, but how things are being dealt with at times, that has me so pissed off.
Look at all the ones in the Quality control topic, which you are the OP on.

But, does not matter now. My mind is made up.
I'm sending some of my mods to someone else, and the rest that are mine alone, will only be on my site from now on, and I'll be removing them from the mod site here, and more likely, closing my account. Not just due to this, but mainly due to a friend getting banned for 3 days for a post that was not even half as bad as I've seen some team members post, just because it was directed at a team member.

So, in closing, I wont be troubling people here any more after I get things set and leave.

Arantor

If you are referring to what I think you are referring, there was so so much more to it than that.

Burke ♞ Knight

There are also personal reasons, between me and someone high up in the team, that seems to have an issue with me, and takes any chance to be rude and disrespectful to me. I have decided that it was enough to make up my mind on the future of my sites, and what I do with my time.

I've been a big supporter of SMF for many years, and the way things have been, even in just the last 2 months, makes me wonder why I am focusing so much time and effort here. Now I truly understand what you have been saying all this time, my friend. How easy it is to try to get away, and then get pulled back in. But, with how things have been lately, I don't see any real future for me here at SMF. That is what is really getting to me. I can code mods that edit files, but I can't grasp the danged hooks, and such. It's time to face it, my skills are limited to what is now considered taboo, and I'll never get to the coding level to continue. So may as well just be done, and make my departure.

Advertisement: