SMF 2.0.10: Setting "Number of star images:' to 0 clears "Star image filename:"

Started by SeniorSausages, May 28, 2015, 09:32:25 PM

Previous topic - Next topic

SeniorSausages

SMF 2.0.10.

In Membergroups configuration, setting the "Number of star images:" option to 0 on any given membergroup also seems to delete the "Star image filename:" field data.

I feel this filename should be retained, even if it is not used.


Steve

I don't know that I'd consider it a bug as it's not something that is not working as designed.
DO NOT pm me for support!

margarett

Nop, it's totally by design ;)

$_POST['stars'] = (empty($_POST['star_count']) || $_POST['star_count'] < 0) ? '' : .......................

It's not a bug, really. You can debate whether it is the right thing to do or not :P but it works as intented ;)
This happens because the name of the image is not stored in any place by itself. Stars are stored in the database as number#imagename as are used throughout the code as such. You can suggest such change for 2.1 in GH but it won't be changed for 2.0 ;)
Se forem conduzir, não bebam. Se forem beber... CHAMEM-ME!!!! :D

QuoteOver 90% of all computer problems can be traced back to the interface between the keyboard and the chair

Illori

Quote from: margarett on May 29, 2015, 11:42:36 AM
You can suggest such change for 2.1 in GH but it won't be changed for 2.0 ;)

in 2.1 there is a drop down to select the image, so this does not apply.

margarett

Se forem conduzir, não bebam. Se forem beber... CHAMEM-ME!!!! :D

QuoteOver 90% of all computer problems can be traced back to the interface between the keyboard and the chair

Steve

DO NOT pm me for support!

Advertisement: