ShelfLife - [responsive][2.0.x][free]

Started by Bloc, August 19, 2015, 04:44:57 AM

Previous topic - Next topic

Antechinus

Yeah I saw your list of cell codes after posting that. I can see the sense in the overall idea. I just like code naming to be as clear as possible right from the start. It make things easier on my brain. :D

TBH I'm also not keen on class names like "dark_notice" etc because they become meaningless as soon as someone changes the presentation. If somebody decides they want it light (like some bloke from Norway, for example) you suddenly have a class name which is just going to be confusing rather than helpfully descriptive. Same goes for things like floatleft and floatright, which I think were a mistake in 2.0.x.  I try to avoid things like that, and prefer to use a name that says what it does in essence, rather than how it happens to look at the time. I think this is a good overall principle to stick to.

Anyway it's certainly lean CSS. I can see what you're trying to do and generally I like it. I'm kinda curious how something with more extravagant use of CSS for styling would weigh in on the same basic codebase.

BTW, personal preference here but I think having the next/previous topic links directly beneath the page index is just plain evil gui layout. People will instinctively expect them to be next/previous pages, and TBH the lack of such links is one of the most primitive and annoying things about 2.0.x. It's also impossible to fix without a mod, AFAIK.

Bloc

Naming is one thing - naturally I made names that feel "right" to me, it might not be that for others. I think that it is the basic premise, that of not using too much specific names, that really is to learn from it. Complex styling, sure, but re-use the styles as much as possible, thats my motto. Theres a reason why Wordpress themes are so abundant, its only a very limited set of classes in the default theme(well, it was, not sure now) so those that want complex, can make that - but for others its easy to jump in. Never been that in SMF lol.

On another note, I'll really stepped out on my next theme..I doubt much CSS will be left :D ..or maybe not. But it certainly will break with my themes so far, and be kind of "out there". :P :)

Kindred

GPL is a pain in the butt and is - overall - one of the worst OS licenses out there, IMO...

I'm not sure about v2 -- I know that v3 has issues with compatibility though... even with BSD

the biggest problem with GPL is that it considers itself "viral" and almost anything it touches must also become GPL...
Слaва
Украинi

Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

Bloc

Which for me is just fine. SMF is BSD, the theme is GPL2, any theme based on it or forked, will also need to be GPL2 or some equivalent. Don't see the problem here tbh.

Antechinus

Quote from: Bloc on August 27, 2015, 12:21:55 PMOn another note, I'll really stepped out on my next theme..I doubt much CSS will be left :D ..or maybe not. But it certainly will break with my themes so far, and be kind of "out there". :P :)
:popcorn: :D

Ken.

Quote from: Antechinus on August 27, 2015, 07:22:55 PM
Quote from: Bloc on August 27, 2015, 12:21:55 PMOn another note, I'll really stepped out on my next theme..I doubt much CSS will be left :D ..or maybe not. But it certainly will break with my themes so far, and be kind of "out there". :P :)
:popcorn: :D

Butter!  8)
"If you don't have a stack of failures in your shop, you aren't trying hard enough". --Richard Raffin.


stmaxx

QuoteNaming is one thing - naturally I made names that feel "right" to me, it might not be that for others. I think that it is the basic premise, that of not using too much specific names, that really is to learn from it. Complex styling, sure, but re-use the styles as much as possible, thats my motto. Theres a reason why Wordpress themes are so abundant, its only a very limited set of classes in the default theme(well, it was, not sure now) so those that want complex, can make that - but for others its easy to jump in. Never been that in SMF lol.

On another note, I'll really stepped out on my next theme..I doubt much CSS will be left :D ..or maybe not. But it certainly will break with my themes so far, and be kind of "out there". :P :)

I myself agree with this, and not that Bloc needs a signature in his themes/work, but this tells me right off that this was done by one of best, if not the best. working with ones own style, is part of the art and purpose of doing! IMHO
re-using CSS and HTML code you make is also a good thing!

Maxx




ilookpair


GO LIVE

Nice and clean, Love it

I noticed no updates since Aug 2015
Have the bugs been worked out?
Do you still plan to support SMF 2.1?

Bloc

No, for now I will not do any 2.1 themes. There are still things being worked at in the 2.1 beta and some of choices made for themes there is not something I encourage. Maybe in the future when 2.1 is stable.(and I have no choice than to use whats there lol)

Shelf-life for 2.0 have been dormant for some time, but I might re-visit it using the CSS in ModernStyle theme.

whoey

Nice work with this! Will there be any further updates with this theme?

I've installed it to have a play around as we are planning on moving away from the core theme + mobile theme + tapatalk we currently have to one responsive catchall theme.

Logo wouldn't change via theme settings even though it had the url (http://mysite.tld/logo.png) but overwriting the theme provided "shelflife" logo.png did it.

Seems to work with EZportal as well, but we are running a bunch of other mods I haven't added or checked yet.

whoey

noticed I was not getting avatars on posts in desktop mode except in profiles

Display.template.php line 255:
<span onclick="showExtra(\'avvy_extra'.$message['id'].'\');" class="roundavatar_full" style="cursor: pointer;"><img src="', $message['member']['avatar']['href'], '" alt="" /></span>';
theme default was ', $message['member']['avatar']['url'], ' which came up blank, where as ', $message['member']['avatar']['href'], ' works...

whoey

Also reply/quote buttons/links missing from all at once/one at a time PM modes, only have buttons for conversation mode.

Bloc

The PM bugs are corrected in the new version which has been added to the SMF themesite, awaiting approval.
A demo can be had at http://www.bjornhkristiansen.com/demo/index.php?demo=4

whoey

I've been modding and fixing/adding a number of things that are missing from the theme. Sadly I haven't been tracking most of it.

Bloc

Thats ok. :) We'll see what comes up when I will check it.

Bloc


Ken.

"If you don't have a stack of failures in your shop, you aren't trying hard enough". --Richard Raffin.


whoey

To start I'd like to say thanks for your hard work, the rest of this may sound like criticism, but it's actually meant as feedback to make this theme even better.

So installed the new posted v2.0.3 version on a test setup to compare with the (now heavily modified plus mods) v1.01 I was working with before.

I see you've put in dropdown menus now. While that might be an improved experience for desktops it really makes the mobile experience even more horrible. (just try navigating around the admin section, the menus squash up and are all on top of each other making it pointless to even try) Not that the old step by step menus system works well on a mobile device without a lot of @media styling overrides, actually that goes for a lot more than just the menus. A mobile menu would take this theme to a whole new level, after all responsiveness is the whole point of this theme is it not?

Another major thing for me is the missing alternating background in posts... IIRC it looks like most of the code is there, but it's just not being called up or rendered correctly. That would make it all much easier to read. On a mobile device it's really a mess as most of the time you end up with an avatar taking 1/3 of the screen width, and then the actual post is below a large 2/3 blank area, making for a lot of scrolling (and user complaints!). On my modified version I shrank avatars and put it all on the same row in two columns instead of the over under default.

Hope this is useful info and doesn't sound like a rant... I can appreciate what went into it so far...

Bloc

Its def. WIP so any errors have to be worked out. I'll look over the issues.

EDIT:the menu system used in Alpha centauri is what I aim to use in Shelflife, but it will be sometime before its ready. And true, the old style with dropline menu in ShelfLife wasn't  much bettter in this theme either, not for mobile use.

Advertisement: