Is it possible to add #SOMETHING to links generated by constructPageIndex?

[Biology Forums]

Is it possible to add #ID to links generated by constructPageIndex?

If so, how?

[live627]

Which ones? All of them?

[Matthew K.]

Since your question is "can you", the answer is yes. To be more helpful, you'll need to explain to us what you're trying to do.

[Biology Forums]

Cool!

I have the following code:

Code Select Expand

$maxComments = 10; // Hard-coded; should this be configurable?

// Make sure the starting place makes sense and construct our friend the page index.
$context['start'] = (int)$_REQUEST['start'];
$context['page_index'] = constructPageIndex($scripturl . '?action=profile;u=' . $memID, $context['start'], $commentCount, $maxComments, false);

I'd like: http://myurl.com/index.php?action=profile;u=6;start=20#comments

How would I incorporate the fragment (#)?

[Matthew K.]

On the train currently, so I'm not able to write the code for you, but I'll mark this unread and when I get back to my place I'll write the code if no one else has.

[Biology Forums]

Thank you

[Biology Forums]

Bump

[Pipke]

You want it to use it on one page (ie. once on the script you posted) or on all the pages wich uses the smf 'pagination' function constructPageIndex?

[Biology Forums]

Thanks -- on all pages

[Pipke]

ok if i understand you right here goes:

in Sources/Subs.php

Code (find) Select Expand


$base_link = '<a class="navPages" href="' . ($flexible_start ? $base_url : strtr($base_url, array('%' => '%%')) . ';start=%1$d') . '">%2$s</a> ';


Code (replace with) Select Expand


$base_link = '<a class="navPages" href="' . ($flexible_start ? $base_url : strtr($base_url, array('%' => '%%')) . ';start=%1$d') . '#comments">%2$s</a> ';


url will be then: 
http://myurl.com/index.php?action=profile;u=6;start=20#comments
or
http://myurl.com/index.php?topic=1.10#comments

[Matthew K.]

Pipke, that's almost correct. You also need some conditional on whether #comments should be set or not.

[Biology Forums]

I think I misunderstood you. This will put #comment on every constructPageIndex in the forum.

[Pipke]

Thanks -- on all pages

I think I misunderstood you. This will put #comment on every constructPageIndex in the forum.

yes, you said on all?

[Biology Forums]

Let me be clear, on all for where the function is embedded.

I.e. if it is embedded in page.template.php, it shows #comment on every page for the page index on page.template.php. Otherwise, I could have figured it out

Thanks

[Pipke]

try this then:

in Sources/Subs.php

Code (find) Select Expand


function constructPageIndex($base_url, &$start, $max_value, $num_per_page, $flexible_start = false)


Code (replace with) Select Expand


function constructPageIndex($base_url, &$start, $max_value, $num_per_page, $flexible_start = false, $comments = null)


and do...

Code (find) Select Expand


$base_link = '<a class="navPages" href="' . ($flexible_start ? $base_url : strtr($base_url, array('%' => '%%')) . ';start=%1$d') . '">%2$s</a> ';


Code (replace with) Select Expand


$base_link = '<a class="navPages" href="' . ($flexible_start ? $base_url : strtr($base_url, array('%' => '%%')) . ';start=%1$d') . ($comments ? '#comments' : '') .'">%2$s</a> ';


now use your code as this:

Code Select Expand


$maxComments = 10; // Hard-coded; should this be configurable?

// Make sure the starting place makes sense and construct our friend the page index.
$context['start'] = (int)$_REQUEST['start'];
$context['page_index'] = constructPageIndex($scripturl . '?action=profile;u=' . $memID, $context['start'], $commentCount, $maxComments, false, $comments = true);


Let me know if that worked out for you?

[Biology Forums]

Great idea. What I did was:

Code Select Expand

function constructPageIndex($base_url, &$start, $max_value, $num_per_page, $flexible_start = false, $fragment = null)

and

Code Select Expand

$base_link = '<a class="navPages" href="' . ($flexible_start ? $base_url : strtr($base_url, array('%' => '%%')) . ';start=%1$d') . ($fragment ? $fragment : '') .'">%2$s</a> ';

Thanks for the idea