1.1 rc2 - Default theme invalid xhtml 1.0 (minor problem)

[TestMonkey]

Around line 279 of the default theme that ships with the 1.1 rc2 smf install, it's missing a closing </span>.
Causing the forum to not validate is not a major deal figured you guys should know, hadn't seen anyone point this out so tossing it here.

[Dannii]

I think this has been fixed in the cvs. Thanks for pointing it out still.

[bloc]

It has. If i remember correctly there was a missing span around the loginbox.

[ismile]

Can I please be directed to the fixes? The Upgrades I downloaded last week cause errors with Xhtml and Css in the new default theme.

[Deaks]

issmile best wait for the final.

Member this isnt the stable version yet.

[TestMonkey]

It has. If i remember correctly there was a missing span around the loginbox.

That was indeed where the missing span was located

Can I please be directed to the fixes? The Upgrades I downloaded last week cause errors with Xhtml and Css in the new default theme.

To fix the default theme
Open - Themes\default\ index.template.php up in a text editor..
Around line 269
--Find

Code Select Expand


// Otherwise they're a guest - this time ask them to either register or login - lazy bums...
else
{
echo '

--Change to

Code Select Expand


// Otherwise they're a guest - this time ask them to either register or login - lazy bums...
else
{
echo '</span>


That seems to allow it to validate not sure if their is possibly a better location to close the span ..
but that seems to work.

[bloc]

It was more or less how it was fixed - by adding the missing </span>.