SSI bug?

[J. S.]

In SSI.php we have:

Code Select Expand

function ssi_recentPosts($num_recent = 8, $exclude_boards = null, $output_method = 'echo')

that fill return 8 results, all the time. Try http://www.simplemachines.org/community/SSI.php?ssi_function=recentPosts;limit=10 and you`ll see only 8 results. The ;limit=X option is good for nothing.
That $num_recent should have a default value, like 5, and if in the url I have a limit then $num_recent = $limit.

[kegobeer]

The SSI function works perfectly.  You don't pass the limit in the URL, you pass the limit when you call the function.

[J. S.]

The SSI function works perfectly.  You don't pass the limit in the URL, you pass the limit when you call the function.

meaning?

[xduugu]

<?php ssi_recentPosts($num_recent, $exclude_boards) ?>

[Kindred]

more specifically...

<?php ssi_recentPosts(10,null,'echo') ?>

or

<?php ssi_recentPosts(10) ?>

[Orstio]

If you want to use "limit" in the query string like that, you could also do this:

<?php ssi_recentPosts($_REQUEST['limit']) ?>

[Leipe Po]

better use $_POST or $_GET,

$_REQUEST doesnt care if somebody uses a form or by url, witch give you less control...

[Rudolf]

Actually with SMF you need to use $_REQUEST if I am not mistaken.
Some developer correct me if I do.

[Leipe Po]

$_GET or $_POST works just as perfectly