Simple ImageShack (latest release: v3.1.3)

Started by Rik©, June 03, 2005, 02:50:34 PM

Previous topic - Next topic

Rik©

Quote from: ProfDrDenis on May 04, 2010, 11:55:46 AM
by the way, the mod put in the Modifications.english.php

$txt['permissionhelp_sis_view'] = 'Enabling this permission adds an ImageShack.us upload field to the post template';

this makes an error see the attach file

better is to put it in the Help.english.php like this

$helptxt['permissionhelp_sis_view'] = 'Enabling this permission adds an ImageShack.us upload field to the post template';

than it works fine  ;D
You're right about the wrong ,  at the end of the board-permissions array (group permissions is correct), i will fix it soon.
But the place of the $helptxt is correct....
Quote from: http://docs.simplemachines.org/index.php?topic=998.0New language entries
Each new permission will need at least three new language entries. $txt['permission...'] entries go in ManagePermissions.language.php and $txt['cannot...'] entries go in Errors.language.php, or if you're writing a mod put them all in Modifications.language.php.

But thanks for the bug report, i'll fix it tonight.

-Rik©

Arantor

That tutorial is for 1.1.x, it's a bit different in 2.0...
Perhaps it would have been better if I'd simply never bothered. Y'all clearly would be less unhappy that way.

Rik©

Quote from: Arantor on May 04, 2010, 12:52:38 PM
That tutorial is for 1.1.x, it's a bit different in 2.0...
sorry, wrong quote  ;D

Quote from: http://www.simplemachines.org/community/index.php?topic=345127.0The only thing remaining to do is to define the text that will be displayed. This can be done in the ManagePermissions.{language}.php, but is ideally better placed in Modifications.{language}.php.

-Rik©

Arantor

That quote looks AWFULLY familiar, I have no idea about that ;D

The reason I encourage using Modifications.{language}.php is because in the event of non English languages, Modifications.english.php is ALWAYS loaded, irrespective of the language, so you won't get the issues you got in 1.1.x with 'missing' language strings.
Perhaps it would have been better if I'd simply never bothered. Y'all clearly would be less unhappy that way.

aw06

:: ShopinJA.com Powered by SMF 1.1.19 | Ig-Oh Theme by Koni | 70 Rock Solid Error Free Mods | Many Custom Edits & Tweaks ::
- Host Unlimited Websites - Free Website Builder & Templates - Unlimited Disk Space & Bandwidth

Rik©

Quote from: aw06 on May 04, 2010, 02:10:56 PM
So ric there is a bug for 2.0 ? ??
Yes, a 'medium' one, but like i said a fix will be released soon (after i've finished my coffee  ;D ).

-Rik©

aw06

Quote from: Rik© on May 04, 2010, 03:12:23 PM
Quote from: aw06 on May 04, 2010, 02:10:56 PM
So ric there is a bug for 2.0 ? ??
Yes, a 'medium' one, but like i said a fix will be released soon (after i've finished my coffee  ;D ).

-Rik©

ok kool, seems invisible thou, seeing now errors .. can you also post the changes so i can just update it manually..
:: ShopinJA.com Powered by SMF 1.1.19 | Ig-Oh Theme by Koni | 70 Rock Solid Error Free Mods | Many Custom Edits & Tweaks ::
- Host Unlimited Websites - Free Website Builder & Templates - Unlimited Disk Space & Bandwidth

Rik©

I wouldn't recommend updating manually, this way you will get errors when uninstalling with the package-manager.

-Rik©

Rik©

Quote from: Arantor on May 04, 2010, 10:50:39 AM
The mod isn't wrong - if it's guaranteed to be the last item in the permissions array. But it should end in a comma in case it isn't.
I think it's not guaranteed (other mods may also add their permission as last item). So i'll add a comma just like the original last item in te original ManagePermissions.php
'post_attachment' => array(false, 'attachment', 'attach'),

-Rik©

aw06

Quote from: Rik© on May 04, 2010, 05:40:23 PM
I wouldn't recommend updating manually, this way you will get errors when uninstalling with the package-manager.

-Rik©

ook ... but i don't plan on uninstalling lol
:: ShopinJA.com Powered by SMF 1.1.19 | Ig-Oh Theme by Koni | 70 Rock Solid Error Free Mods | Many Custom Edits & Tweaks ::
- Host Unlimited Websites - Free Website Builder & Templates - Unlimited Disk Space & Bandwidth

Rik©

Decided to postpone the release of SIS v3.1.2
The 'permission array bug' reported by ProfDrDenis has been degraded to low (minor) priority.
QuoteThis is most often used for cosmetic issues that don't inhibit the functionality or main purpose of the project/mod.
This will give me some time to add the supported languages to the settings/admin panel (as planned for this release).

-Rik©

ProfDrDenis

#591
an other idea (and I hope my english is not to bad)

after the upload you have the screen like my attach. Is this possible that the user dont copy, paste they only click what they want and than its inside the editor?

I hope you understand what I mean

Rik©

Quote from: ProfDrDenis on May 06, 2010, 06:38:02 AM
an other idea (and I hope my english is not to bad)

after the upload you have the screen like my attach. Is this possible that the user dont copy, paste they only click what they want and than its inside the editor?

I hope you understand what I mean
Ich verstehe es  ;)
The auto-insert (at cursor) feature is a much requested feature.
But it will take some time to add (i'll have to rewrite aprox 80% the mod).

-Rik©


Here's a short list of (requested) features that are planned to be included in the future:
- auto-insert
- bulk uploading
- resize/optimize image
- profile support (avatar)



ProfDrDenis

Quote from: Rik© on May 06, 2010, 07:21:06 AM
Ich verstehe es  ;)

thats nice.

Its a nice mod. so dont sleep, dont drink to much coffee, lets rock and make alles finish

aw06

This mod has the potential with those features to be one of the greats :)
:: ShopinJA.com Powered by SMF 1.1.19 | Ig-Oh Theme by Koni | 70 Rock Solid Error Free Mods | Many Custom Edits & Tweaks ::
- Host Unlimited Websites - Free Website Builder & Templates - Unlimited Disk Space & Bandwidth

LondonDragon

After I install this mod I can no longer access the Permissions section on admin panel or add another aboard!! Get this error:

QuoteParse error: syntax error, unexpected T_CONSTANT_ENCAPSED_STRING, expecting ')' in /home/lfkccouk/public_html/Sources/ManagePermissions.php  on line 1559

If I remove it, then its all fine again!

Any help appreciated. Thanks

Arantor

Care to attach your ManagePermissions.php with the mod installed? I suspect it's the same thing as discussed above about not having a , at the end of the edit.
Perhaps it would have been better if I'd simply never bothered. Y'all clearly would be less unhappy that way.

Rik©

Quote from: Arantor on May 06, 2010, 06:04:58 PM
I suspect it's the same thing as discussed above about not having a , at the end of the edit.
It probably is.
Looks like i'll have to release v3.1.2 today....

-Rik©

Rik©

#598
Quote from: Rik© on May 06, 2010, 06:38:37 PM
Quote from: Arantor on May 06, 2010, 06:04:58 PM
I suspect it's the same thing as discussed above about not having a , at the end of the edit.
It probably is.
Looks like i'll have to release v3.1.2 today....

-Rik©
Released....

-Rik©

LondonDragon

Thanks for the update :)

Now everytime I try to upload an image I get this error:

Quote
  Oops, something went wrong
(XML return failed)

Click here to try again

Any ideas? Thanks

Advertisement: