News:

Wondering if this will always be free?  See why free is better.

Main Menu

Members Online Today

Started by Doug Heffernan, April 19, 2022, 05:57:48 PM

Previous topic - Next topic

FrizzleFried

Mystery solved!  I really aught to document these things (as I have started to do with all the little tweaks I implement so I don't have to come back here and re-look them up over and over as I did for more time than I care to admit).

;)


Michael Vail

Love this mod, now if I can just figure out to how to make it a Tiny Portal Block.  Wink Wink @rjen :-)

Great Work Doug! Thank you!

Dave J

Hi Doug,

Thanks for creating this mod.

One thing which is an issue for me is the sub_bar text colour, see attached.

It's OK and matches everything in the default curve theme but in a couple of the other themes the colour is different.

Is there a way to fix this please?

Doug Heffernan

Quote from: Dave J on April 27, 2022, 08:34:48 AMHi Doug,

Thanks for creating this mod.

One thing which is an issue for me is the sub_bar text colour, see attached.

It's OK and matches everything in the default curve theme but in a couple of the other themes the colour is different.

Is there a way to fix this please?

I use only the default theme. What themes are those? Looking at the screesnhot it looks like they have altered the default method for the info center. You can check their code and make the adjustment in this mod accordingly. You will have to edit the MembersOnlineToday.template.php file for that.

Arantor

Actually I don't think that's the case here.

The other item headers are links to thinks, the default theme just restyles the links to the same colour but Dave's theme doesn't.

If the mod emitted a link header rather than text (maybe linking to who's online?) it would look like the others.
Perhaps it would have been better if I'd simply never bothered. Y'all clearly would be less unhappy that way.

Doug Heffernan

#25
@Dave J, please redownload the newly attached package and let me know how it will go.

Dave J

Quote from: Doug Heffernan on April 27, 2022, 09:09:10 AM
Quote from: Arantor on April 27, 2022, 08:42:33 AMActually I don't think that's the case here.

The other item headers are links to thinks, the default theme just restyles the links to the same colour but Dave's theme doesn't.

If the mod emitted a link header rather than text (maybe linking to who's online?) it would look like the others.

You are right. I had changed the <span class="main_icons people"></span> code to use the img src, because for some reason that did not work on the forum of a client of mine. And I forgot to change it back in the mod here. Thank you for your post as that reminded me of that.

@Dave J, please redownload the newly attached package and let me know how it will go.

Doug,

Do you mean redownload from here https://custom.simplemachines.org/index.php?mod=4322 or did you mean to attach a new file to the post?

Doug Heffernan

Quote from: Dave J on April 27, 2022, 09:34:53 AM
Quote from: Doug Heffernan on April 27, 2022, 09:09:10 AM
Quote from: Arantor on April 27, 2022, 08:42:33 AMActually I don't think that's the case here.

The other item headers are links to thinks, the default theme just restyles the links to the same colour but Dave's theme doesn't.

If the mod emitted a link header rather than text (maybe linking to who's online?) it would look like the others.

You are right. I had changed the <span class="main_icons people"></span> code to use the img src, because for some reason that did not work on the forum of a client of mine. And I forgot to change it back in the mod here. Thank you for your post as that reminded me of that.

@Dave J, please redownload the newly attached package and let me know how it will go.

Doug,

Do you mean redownload from here https://custom.simplemachines.org/index.php?mod=4322 or did you mean to attach a new file to the post?

Yes, I meant to redownload the mod from there.

Dave J

Quote from: Doug Heffernan on April 27, 2022, 10:25:56 AMYes, I meant to redownload the mod from there.

I've done that Doug, and it makes no difference, the text is still hardly seen, and although the other themes are affected it's just the colouring in those.

If it helps I did an inspect of the block and the images attached are what is shown. The name in front of the screenshot is the name of the theme.

I've also attached the other themes affected.

This is not a deal breaker Doug, as it's for admin only, but it would be nice to have it all looking the same colour in the themes.

Doug Heffernan

Quote from: Dave J on April 27, 2022, 10:44:50 AMI've done that Doug, and it makes no difference, the text is still hardly seen, and although the other themes are affected it's just the colouring in those.

Can you please post the download link to one of those themes?

The text displays fine to the dark themes from what I see at the screenshots above.

Arantor

If you've only changed the icon to be a reference back to the sprite this won't solve the problem.

Again, each of the headers in the info centre are links to other pages - except for your mod. Thus your mod doesn't get the right styling.

See the elements in Dave's screenshots, the Users Online item is a link, Stats is a link, Members Online Today is not a link, so it gets a different style.
Perhaps it would have been better if I'd simply never bothered. Y'all clearly would be less unhappy that way.

Dave J

Quote from: Arantor on April 27, 2022, 10:58:26 AMIf you've only changed the icon to be a reference back to the sprite this won't solve the problem.

Again, each of the headers in the info centre are links to other pages - except for your mod. Thus your mod doesn't get the right styling.

See the elements in Dave's screenshots, the Users Online item is a link, Stats is a link, Members Online Today is not a link, so it gets a different style.

I was going to mention that myself, but as I'm not a coder, I though you guys might think I'm being stupid...it wouldn't be the first time, it's also the reason I deliberately expanded the inspect code lines

Doug Heffernan

Quote from: Dave J on April 27, 2022, 11:02:19 AMI was going to mention that myself, but as I'm not a coder, I though you guys might think I'm being stupid...it wouldn't be the first time, it's also the reason I deliberately expanded the inspect code lines

Try to change this code:

<span class="main_icons people"></span> ', $txt['members_logged_today'], '
to the following at the MembersOnlineToday.template.php file.

<a href="' . $scripturl . '?action=who"><span class="main_icons people"></span> ', $txt['members_logged_today'], '</a>
And add $scripturl to the list of the global variables.

After you make the edits, save the changes. That will link it to the who is online page. You can change the url to link to wherever you want.

Quote from: Dave J on April 27, 2022, 11:02:19 AMI though you guys might think I'm being stupid

No one is going to think that. Do not let that kind of thinking to stop you from asking questions. We have all been there and still learn new things all the time as we go along.

Dave J

Great thanks Doug, that works fine for all the themes.

Much appreciate the help


Doug Heffernan

Quote from: Dave J on April 27, 2022, 01:05:22 PMGreat thanks Doug, that works fine for all the themes.

Much appreciate the help


No problem :)

Costa

Portuguese_pt translation.
Hugo Costa - Costa Planet
Todas as MP's a pedir ajuda são sujeitas a radioactividade, microondas, queimadas e atiradas borda fora.

"At least someone appreciates the fact that I am doing and not thinking..."
"Laziness is counter-revolutionary."

Doug Heffernan

Quote from: Costa on June 02, 2022, 08:12:24 AMPortuguese_pt translation.

Thank you for the translation. It has been included in the mod.

Costa

Hugo Costa - Costa Planet
Todas as MP's a pedir ajuda são sujeitas a radioactividade, microondas, queimadas e atiradas borda fora.

"At least someone appreciates the fact that I am doing and not thinking..."
"Laziness is counter-revolutionary."

Advertisement: